Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-roll ads not blocked on breitbart videos #1318

Closed
LaurenWags opened this issue Sep 27, 2018 · 7 comments
Closed

pre-roll ads not blocked on breitbart videos #1318

LaurenWags opened this issue Sep 27, 2018 · 7 comments

Comments

@LaurenWags
Copy link
Member

Description

Pre-roll ads are not being blocked on videos in breitbart articles.

Steps to Reproduce

  1. Clean profile, navigate to breitbart.
  2. Open a page with a video.
  3. Using default shields, attempt to view video.

Actual result:

Pre-roll ad observed. Changing FP to Block All does not change this.

Expected result:

No pre-roll ad.

Reproduces how often:

easily

Brave version (chrome://version info)

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X

Reproducible on current release:

pre-roll ad on video not observed on 0.24.0

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

Found while testing #1111
Issue is similar to #1145 for pre-roll ads on YT videos.

cc @brave/legacy_qa for verification on other platforms

@LaurenWags LaurenWags added bug feature/shields/adblock Blocking ads & trackers with Shields labels Sep 27, 2018
@LaurenWags LaurenWags added this to the 1.0 (0.56.x) milestone Sep 27, 2018
@kjozwiak
Copy link
Member

kjozwiak commented Oct 4, 2018

cc @brave/legacy_qa for verification on other platforms

Managed to reproduce on all three platforms as well. It doesn't always happen, but the pre-roll ads are appearing often enough. Enabling Block all Cookies and Block All Fingerprints doesn't resolve the issue either.

  • macOS 10.13.6 x64 - Reproduced
  • Win 10 x64 - Reproduced
  • Ubuntu 18.04 x64 - Reproduced

Example of the pre-roll ads:

screen shot 2018-10-03 at 8 50 49 pm

Used the following build:

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X

@rebron rebron modified the milestones: 1.0, 1.x Backlog Oct 16, 2018
@rebron
Copy link
Collaborator

rebron commented Oct 16, 2018

@LaurenWags can you recheck if this is still an issue.

@LaurenWags
Copy link
Member Author

@rebron yes, still occurs for me with

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X

@kjozwiak
Copy link
Member

Still reproducible under Win 10 x64 as using the following build:

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Windows

screen shot 2018-10-16 at 5 44 58 pm

@ryanbr
Copy link

ryanbr commented Oct 28, 2020

@LaurenWags Should be resolved, can you re-check?

@LaurenWags
Copy link
Member Author

@ryanbr appears fixed for me using below build

Brave | 1.17.55 Chromium: 86.0.4240.111 (Official Build) dev (x86_64)
-- | --
Revision | b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS | macOS Version 10.14.6 (Build 18G6032)

@ryanbr
Copy link

ryanbr commented Oct 30, 2020

Cheers for confirming @LaurenWags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants