-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change gaia URL to be no-thanks.invalid #1312
Comments
Verified passed with
Used test plan from brave/brave-core#512 to verify that on Dev build (0.55.6) prior to fix the gaia URL displays accounts.google.com/etc... (ex. Line 17) Verified with 0.55.10 Beta build the gaia URL displays no-thanks.invalid/etc... (ex. Line 17) and that accounts.google.com/ListAccounts/etc... link is not found. Additionally, verified gmail (opening emails, clicking on links), drive, google+, worked without issue. Verification Passed on
Went through verification using the following build under
Using the STR form the PR, ensured that the following links are being used under
Also verified that before the fix under
Additionally, went through the following cases using
Verification passes on
verified |
Got a notice from little snitch that a request was being made to no-thanks.invalid just now. Seems like this domain shouldn't exist but was resolving to
(Bit confused why I get a few IP's here and a NXDOMAIN but this was copy/pasted.) |
@RyanJarv FWIW here's my output of same
|
NXDOMAIN behavior is DNS provider dependent, I would say it's best not to rely on NXDOMAIN being returned if initiating the request is a concern. cc: @bbondy |
We don't want gaia requests going to Google, so we should change the request endpoint from accounts.google.com to
https://no-thanks.invalid
The text was updated successfully, but these errors were encountered: