Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update link to Brave Talk on new-tab page widget #16289

Closed
stephendonner opened this issue Jun 9, 2021 · 1 comment · Fixed by brave/brave-core#9331
Closed

Update link to Brave Talk on new-tab page widget #16289

stephendonner opened this issue Jun 9, 2021 · 1 comment · Fixed by brave/brave-core#9331
Assignees
@stephendonner
Labels
feature/new-tab OS/Desktop QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.28.x - Release

Comments

@stephendonner
Copy link

Description

Update link to Brave Talk on new-tab page widget

Steps to Reproduce

  1. new profile
  2. launch Brave nightly
  3. open a new-tab page
  4. hover over/click on the video-camera icon
  5. look at the link

Actual result:

Link currently goes to https://together.brave.com/widget

Screen Shot 2021-06-08 at 5 35 06 PM

Expected result:

Link should go to https://talk.brave.com/widget, which now exists and is a carbon copy of together.brave.com/widget

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.27.48 Chromium: 91.0.4472.88 (Official Build) nightly (x86_64)
Revision 109e9cd038b94a631aea7d40ee3d56c1278f2597-refs/branch-heads/4472@{#1385}
OS macOS Version 11.4 (Build 20F71)

/cc @mattmcalister @mrose17 @karenkliu @rebron @petemill
@stephendonner stephendonner mentioned this issue Jun 9, 2021
Closed
@petemill petemill self-assigned this Jun 11, 2021
stephendonner added a commit to stephendonner/brave-core that referenced this issue Jul 3, 2021
@stephendonner
Update new-tab page's Brave Talk URL; fixes brave#16289
07e67c3 
Fix brave/brave-browser#16289.
@stephendonner stephendonner mentioned this issue Jul 3, 2021
Merged
24 tasks
@stephendonner stephendonner added this to the 1.28.x - Nightly milestone Jul 3, 2021
@LaurenWags
Copy link
Member

Verified passed with

Brave | 1.28.82 Chromium: 92.0.4515.93 (Official Build) nightly (x86_64)
-- | --
Revision | 6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS | macOS Version 10.15.7 (Build 19H1217)

Verified STR from description.

Screen Shot 2021-07-29 at 3 09 25 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephendonner stephendonner

Labels
feature/new-tab OS/Desktop QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.28.x - Release
Development

Successfully merging a pull request may close this issue.

Update new-tab page's Brave Talk URL; fixes #16289 stephendonner/brave-core
3 participants
@stephendonner @petemill @LaurenWags