Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Clear cookies and site data when you quit Brave" reverted to original Chromium name #17153

Closed
Tonev opened this issue Jul 25, 2021 · 2 comments
Labels
closed/invalid closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/settings OS/Desktop

Comments

@Tonev
Copy link
Contributor

Tonev commented Jul 25, 2021

Description

It looks like the latest Chromium upgrade reverted the name of the feature to its original Chromium name:
Clear cookies and site data when you quit Brave -> Clear cookies and site data when you close all windows.

The feature is found at brave://settings/cookies.

Steps to Reproduce

  1. Open Brave.
  2. Type brave://settings/cookies in the address bar.
  3. Check feature's name.

Actual result:

Feature's name is Clear cookies and site data when you close all windows since the latest Chromium upgrade.

Expected result:

Unless developers intentionally reverted feature's name, it should be Clear cookies and site data when you quit Brave.

Reproduces how often:

Easily

Brave version (brave://version info)

Brave 1.27.108 Chromium: 92.0.4515.107 (Official Build) (64-bit)
Revision 87a818b10553a07434ea9e2b6dccf3cbe7895134-refs/branch-heads/4515@{#1634}
OS Windows 7 Service Pack 1 (Build 7601)
JavaScript V8 9.2.230.20
User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.107 Safari/537.36
Command Line "C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe" --enable-dom-distiller --disable-domain-reliability --no-pings --origin-trial-public-key=bYUKPJoPnCxeNvu72j4EmPuK7tr1PAC7SHh8ld9Mw3E=,fMS4mpO6buLQ/QMd+zJmxzty/VQ6B1EUZqoCU04zoRU= --sync-url=https://sync-v2.brave.com/v2 --lso-url=https://no-thanks.invalid --variations-server-url=https://variations.brave.com/seed --enable-features=WebUIDarkMode,LegacyTLSEnforced,SafetyTip,AutoupgradeMixedContent,WinrtGeolocationImplementation,PrefetchPrivacyChanges,PasswordImport,ReducedReferrerGranularity --disable-features=NotificationTriggers,HandwritingRecognitionWebPlatformApiFinch,FlocIdComputedEventLogging,HandwritingRecognitionWebPlatformApi,IdleDetection,AutofillEnableAccountWalletStorage,FledgeInterestGroupAPI,EnableProfilePickerOnStartup,TextFragmentAnchor,AutofillServerCommunication,LiveCaption,InterestCohortFeaturePolicy,FledgeInterestGroups,WebOTP,PrivacySandboxSettings,FederatedLearningOfCohorts,SignedExchangeSubresourcePrefetch,EnablePasswordsAccountStorage,InterestCohortAPIOriginTrial,FirstPartySets,NetworkTimeServiceQuerying,SubresourceWebBundles,SignedExchangePrefetchCacheForNavigations,TrustTokens,DirectSockets,LangClientHintHeader --flag-switches-begin --enable-features=WebUIDarkMode,LegacyTLSEnforced,SafetyTip,AutoupgradeMixedContent,WinrtGeolocationImplementation,PrefetchPrivacyChanges,PasswordImport,ReducedReferrerGranularity,EphemeralStorage --flag-switches-end
Executable Path C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe
Profile Path C:\Users\User\AppData\Local\BraveSoftware\Brave-Browser\User Data\Default
Variations AdRewardsStudy:NextPaymentDayEphemeralStorageStudy:EnabledNativeCosmeticFilteringStudy:EnabledPermissionLifetimeReleaseStudy:Enabled

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

I believe the change happened here: brave/brave-core@2195b1e#diff-ea9438378234d255cac10399b4b40451179915ffb8b03fd41721d689e373f10eL41

@bsclifton
Copy link
Member

cc: @brave/chromium-src-reviewers

@bsclifton bsclifton added feature/settings needs-investigation A bug not 100% confirmed/fixed labels Jul 26, 2021
@rebron
Copy link
Collaborator

rebron commented Feb 9, 2024

Closing. The setting was removed in Chromium 121 see: brave://settings/cookies and had been redundant with our more accessible Clear Browsing Data dialog on Exit option that we added ourselves (not available with Chrome).

@rebron rebron closed this as completed Feb 9, 2024
@rebron rebron added closed/invalid closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. and removed needs-investigation A bug not 100% confirmed/fixed labels Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/invalid closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/settings OS/Desktop
Projects
None yet
Development

No branches or pull requests

3 participants