Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add promotional card for Gemini in Brave Rewards settings page #17315

Closed
emerick opened this issue Aug 3, 2021 · 2 comments · Fixed by brave/brave-core#9623
Closed

Add promotional card for Gemini in Brave Rewards settings page #17315

emerick opened this issue Aug 3, 2021 · 2 comments · Fixed by brave/brave-core#9623

Comments

@emerick
Copy link
Contributor

emerick commented Aug 3, 2021

Add a promotional card for Gemini in the Brave Rewards settings (brave://rewards) in the bottom right, where the TAP Network card typically goes (bottom right corner).

@stephendonner
Copy link

stephendonner commented Aug 4, 2021

Verified PASSED using

Brave 1.29.50 Chromium: 92.0.4515.131 (Official Build) nightly (x86_64)
Revision 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS macOS Version 11.5.1 (Build 20G80)

Confirmed:

  1. new profile has both Gemini and Tap
  2. confirmed the card URL is https://www.gemini.com/brave
  3. clicking on the x removes Gemini, which persists after restart
  4. clicking on the x removes Tap, which persists after restart
  5. upgrading from 1.27.109 adds Gemini (Gemini at top and Tap, below it, displayed)
  6. upgrading from 1.27.109 with Tap removed adds Gemini
example example example example example example
Screen Shot 2021-08-04 at 2 45 51 PM Screen Shot 2021-08-04 at 3 08 43 PM Screen Shot 2021-08-04 at 2 54 53 PM Screen Shot 2021-08-04 at 2 55 40 PM Screen Shot 2021-08-04 at 2 46 01 PM Screen Shot 2021-08-04 at 2 54 53 PM

Verification passed on


Brave | 1.29.60 Chromium: 92.0.4515.131 (Official Build) beta (64-bit)
-- | --
Revision | 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS | Windows 10 OS Version 2009 (Build 19043.1165)

  1. new profile has both Gemini and Tap
  2. confirmed the card URL is https://www.gemini.com/brave
  3. clicking on the x removes Gemini
  4. clicking on the x removes Tap
example example
image image

Verified both clean and upgraded profiles.

  • Installed 1.28.102 and ensured only TAP card is shown in the brave://rewards page, upgraded the profile to 1.29.60 and ensured Gemini card is also shown along with TAP card in brave://rewrads page

Verified PASSED using the testplan from brave/brave-core#9623 with

Brave 1.29.68 Chromium: 92.0.4515.159 (Official Build) beta (64-bit)
Revision 0185b8a19c88c5dfd3e6c0da6686d799e9bc3b52-refs/branch-heads/4515@{#2052}
OS Linux
  1. new profile has both Gemini and Tap
  2. confirmed the card URL is https://www.gemini.com/brave
  3. clicking on the x removes Gemini
  4. clicking on the x removes Tap
example example
Screen Shot 2021-08-25 at 10 01 40 AM Screen Shot 2021-08-25 at 9 55 59 AM

Verified both clean and upgraded profiles.

  • Installed 1.28.106 and ensured only TAP card is shown in the brave://rewards page, upgraded the profile to 1.29.68 and ensured Gemini card is also shown along with TAP card in brave://rewards page

@LaurenWags
Copy link
Member

#17383 can be tested along side this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment