Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add promo card for Gemini #9623

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Add promo card for Gemini #9623

merged 1 commit into from
Aug 3, 2021

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Aug 3, 2021

Resolves brave/brave-browser#17315

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Clean profile
  • Start browser
  • Visit brave://rewards
  • Ensure that Gemini-specific promo card appears, clicking it takes you to the appropriate URL (https://www.gemini.com/brave), and clicking 'x' dismisses the card

@emerick emerick requested a review from a team as a code owner August 3, 2021 11:51
@emerick emerick self-assigned this Aug 3, 2021
@emerick emerick requested review from deeppandya and zenparsing and removed request for deeppandya August 3, 2021 11:51
@emerick emerick force-pushed the rewards-gemini-promo-card branch from bee02b3 to 6bb1e14 Compare August 3, 2021 13:47
Copy link
Collaborator

@szilardszaloki szilardszaloki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emerick emerick merged commit 8ad052e into master Aug 3, 2021
@emerick emerick deleted the rewards-gemini-promo-card branch August 3, 2021 17:42
@emerick emerick added this to the 1.29.x - Nightly milestone Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add promotional card for Gemini in Brave Rewards settings page
2 participants