Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocking parent-child segment will also block parent segment #17670

Closed
btlechowski opened this issue Aug 24, 2021 · 1 comment · Fixed by brave/brave-core#9852
Closed

Blocking parent-child segment will also block parent segment #17670

btlechowski opened this issue Aug 24, 2021 · 1 comment · Fixed by brave/brave-core#9852
Assignees
@tmancey
Labels
bug feature/ads OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No QA/Test-Plan-Specified release-notes/exclude
Milestone
1.30.x - Release

Comments

@btlechowski
Copy link

So for technology & computing-software, parent segment technology & computing is blocked and parent-child segment technology & computing-software is blocked. Thus user will not get ads from technology & computing-software and technology & computing

Steps to Reproduce

  1. Follow steps Blocked notification ad - parent-child segment from https://github.com/brave/internal/issues/794

Actual result:

technology & computing is not in eligible ads for parent segments:

[13491:13491:0824/234328.344100:VERBOSE1:eligible_ad_notifications.cc(87)] Get eligible ads for parent-child segments:
[13491:13491:0824/234328.344327:VERBOSE1:eligible_ad_notifications.cc(89)]   personal finance-personal finance
[13491:13491:0824/234328.344473:VERBOSE1:eligible_ad_notifications.cc(89)]   home-appliances
[13491:13491:0824/234328.344597:VERBOSE1:eligible_ad_notifications.cc(89)]   food & drink-vegetarian
[13491:13491:0824/234328.345571:VERBOSE1:eligible_ad_notifications.cc(100)] No eligible ads for parent-child segments
[13491:13491:0824/234328.345728:VERBOSE1:eligible_ad_notifications.cc(122)] Get eligible ads for parent segments:
[13491:13491:0824/234328.345891:VERBOSE1:eligible_ad_notifications.cc(124)]   personal finance
[13491:13491:0824/234328.346036:VERBOSE1:eligible_ad_notifications.cc(124)]   home
[13491:13491:0824/234328.346194:VERBOSE1:eligible_ad_notifications.cc(124)]   food & drink
[13491:13491:0824/234328.347023:VERBOSE1:eligible_ad_notifications.cc(135)] No eligible ads for parent segments
[13491:13491:0824/234328.347186:VERBOSE1:eligible_ad_notifications.cc(147)] Get eligble ads for untargeted segment
[13491:13491:0824/234328.348202:VERBOSE1:eligible_ad_notifications.cc(159)] No eligible ads for untargeted segment
[13491:13491:0824/234328.349213:VERBOSE1:ad_notification_serving.cc(121)] Ad notification not served: No eligible ads found

Expected result:

technology & computing is in eligible ads for parent segments:

[13491:13491:0824/234328.344100:VERBOSE1:eligible_ad_notifications.cc(87)] Get eligible ads for parent-child segments:
[13491:13491:0824/234328.344327:VERBOSE1:eligible_ad_notifications.cc(89)]   personal finance-personal finance
[13491:13491:0824/234328.344473:VERBOSE1:eligible_ad_notifications.cc(89)]   home-appliances
[13491:13491:0824/234328.344597:VERBOSE1:eligible_ad_notifications.cc(89)]   food & drink-vegetarian
[13491:13491:0824/234328.345571:VERBOSE1:eligible_ad_notifications.cc(100)] No eligible ads for parent-child segments
[13491:13491:0824/234328.345728:VERBOSE1:eligible_ad_notifications.cc(122)] Get eligible ads for parent segments:
[13491:13491:0824/234328.345891:VERBOSE1:eligible_ad_notifications.cc(124)]   technology & computing
[13491:13491:0824/234328.346036:VERBOSE1:eligible_ad_notifications.cc(124)]   personal finance
[13491:13491:0824/234328.346194:VERBOSE1:eligible_ad_notifications.cc(124)]   home
[13491:13491:0824/234328.347023:VERBOSE1:eligible_ad_notifications.cc(135)] No eligible ads for parent segments
[13491:13491:0824/234328.347186:VERBOSE1:eligible_ad_notifications.cc(147)] Get eligble ads for untargeted segment
[13491:13491:0824/234328.348202:VERBOSE1:eligible_ad_notifications.cc(159)] No eligible ads for untargeted segment

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.29.67 Chromium: 92.0.4515.159 (Official Build) beta (64-bit)
Revision 0185b8a19c88c5dfd3e6c0da6686d799e9bc3b52-refs/branch-heads/4515@{#2052}
OS Linux

cc @tmancey @moritzhaller @jsecretan @rebron @brave/legacy_qa
@tmancey tmancey self-assigned this Aug 24, 2021
@tmancey tmancey added release-notes/exclude priority/P3 The next thing for us to work on. It'll ride the trains. priority/P2 A bad problem. We might uplift this to the next planned release. bug and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Aug 24, 2021
@tmancey tmancey mentioned this issue Aug 25, 2021
Merged
24 tasks
@tmancey tmancey added this to the 1.30.x - Nightly milestone Aug 26, 2021
@tmancey tmancey mentioned this issue Aug 26, 2021
Closed
4 tasks
@btlechowski btlechowski mentioned this issue Aug 27, 2021
Closed
@btlechowski btlechowski added QA/No and removed QA/Yes labels Aug 27, 2021
@btlechowski
Copy link
Author

Issue is still reproducible. Logged #17738. Set this as QA/No.

@btlechowski btlechowski mentioned this issue Aug 27, 2021
Closed
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug feature/ads OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No QA/Test-Plan-Specified release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.30.x - Release
Development

Successfully merging a pull request may close this issue.

Fixes blocking parent-child segment will also block parent segment brave/brave-core
2 participants
@tmancey @btlechowski