Fixes blocking parent-child segment will also block parent segment #9852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmancey
force-pushed
the
issues/17670
branch
3 times, most recently
from
57aefc0 to
595e5be
Compare
aseren
reviewed
Aug 25, 2021
| const std::vector<std::string> segment_components = SplitSegment(segment); | ||
| bool ParentSegmentsMatch(const std::string& lhs, const std::string& rhs) { | ||
| const std::vector<std::string> lhs_segment_components = SplitSegment(lhs); | ||
| const std::string lhs_parent_segment = lhs_segment_components.front(); |
There was a problem hiding this comment.
Maybe we should add DCHECK here that components are not empty
tmancey
force-pushed
the
issues/17670
branch
2 times, most recently
from
1f49439 to
908661f
Compare
tmancey
force-pushed
the
issues/17670
branch
6 times, most recently
from
6df91da to
7bd019b
Compare
aseren
approved these changes
Aug 25, 2021
tmancey
force-pushed
the
issues/17670
branch
2 times, most recently
from
e8d6076 to
89b759c
Compare
bsclifton
force-pushed
the
issues/17670
branch
from
89b759c to
954776d
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#17670
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
See brave/brave-browser#17670