Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run go-ipfs with brave agent version suffix #18505

Closed
lidel opened this issue Oct 2, 2021 · 5 comments · Fixed by brave/brave-core#10363
Closed

Run go-ipfs with brave agent version suffix #18505

lidel opened this issue Oct 2, 2021 · 5 comments · Fixed by brave/brave-core#10363
Assignees
Labels
feature/web3/ipfs OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/include

Comments

@lidel
Copy link

lidel commented Oct 2, 2021

go-ipfs 0.10.0 shipped with support for running ipfs daemon with custom --agent-version-suffix (ipfs/kubo#8419)

Soon, we will be running our ipfs-desktop nodes with --agent-version-suffix=desktop, and it would be useful to run Brave instances with --agent-version-suffix=brave to have better insight into metrics / DHT distribution / usage patterns.

Agent Version can be read via ipfs id | jq .AgentVersion:

  • go-ipfs/0.10.0/ - standalone go-ipfs binary
  • go-ipfs/0.10.0/desktop - node managed by IPFS Desktop
  • go-ipfs/0.10.0/brave - node managed by Brave

@bbondy @autonome Thoughts?
I remember we wanted to do this a while ago, but it was not possible without recompiling go-ipfs.
(Now it's just a runtime flag which we could enable after upgrading Brave to go-ipfs 0.10.0)

@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Oct 4, 2021
@bbondy
Copy link
Member

bbondy commented Oct 4, 2021

Posted a security review to make sure this is ok, but I don't see a problem with doing this.

@stephendonner
Copy link

stephendonner commented Oct 6, 2021

Verified FIXED using

Brave 1.32.46 Chromium: 94.0.4606.71 (Official Build) nightly (x86_64)
Revision 1d32b169326531e600d836bd395efc1b53d0f6ef-refs/branch-heads/4606@{#1256}
OS macOS Version 11.6 (Build 20G165)

Steps:

  1. new profile
  2. launched Brave
  3. opened brave://ipfs and clicked Install and start (confirmed I got go-ipfs 0.9.1)
  4. in Terminal.app, entered ps ax | grep go-ipfs
  5. confirmed I didn't see --agent-version-suffix=brave in the output
  6. new profile
  7. launched Brave with --use-dev-goupdater-url
  8. opened brave://ipfs and clicked Install and start (confirmed I got go-ipfs 0.10.0)
  9. in Terminal.app, entered ps | ax | grep go-ipfs
  10. confirmed I saw --agent-version-suffix=brave in the output
  11. confirmed brave shows up now under Node info on brave://ipfs
before fix (Version: go-ipfs/0.9.1/) after fix (Version: go-ipfs/0.10.0/brave)
Screen Shot 2021-10-06 at 1 58 17 PM Screen Shot 2021-10-06 at 1 58 50 PM

go-ipfs 0.9.1

stephendonner@Stephens-MacBook-Pro ~ % ps ax | grep go-ipfs 51152 s000 S+ 0:02.36 /Users/stephendonner/Library/Application Support/BraveSoftware/Brave-Browser-Nightly/nljcddpbnaianmglkpkneakjaapinabi/1.0.6/go-ipfs_v0.9.1_darwin-amd64 daemon --migrate=true --enable-gc --routing=dhtclient

go-ipfs 0.10.0

stephendonner@Stephens-MacBook-Pro ~ % ps ax | grep go-ipfs 51007 s000 S+ 0:40.59 /Users/stephendonner/Library/Application Support/BraveSoftware/Brave-Browser-Nightly/nljcddpbnaianmglkpkneakjaapinabi/1.0.54/go-ipfs_v0.10.0_darwin-amd64 daemon --migrate=true --enable-gc --routing=dhtclient --agent-version-suffix=brave

@kjozwiak
Copy link
Member

Adding QA/Blocked as the above will require a 1.31.x RC which I'm hoping to kick off tonight 👍 We'll need 1.31.84 or higher. @stephendonner mind doing a quick spot check on the RC once it's done? Thanks!

@LaurenWags
Copy link
Member

Removing QA/Blocked since 1.31.84 is available - https://github.com/brave/brave-browser/releases/tag/v1.31.84

@stephendonner
Copy link

Verified PASSED using

Brave 1.31.84 Chromium: 95.0.4638.40 (Official Build) (x86_64)
Revision e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS macOS Version 11.6 (Build 20G165)

Steps:

  1. new profile
  2. launched Brave
  3. opened brave://ipfs and clicked Install and start (confirmed I got go-ipfs 0.10.0)
  4. in Terminal.app, entered ps | ax | grep go-ipfs
  5. confirmed I saw --agent-version-suffix=brave in the output
  6. confirmed brave shows up now under Node info on brave://ipfs

Screen Shot 2021-10-13 at 8 36 51 AM

stephendonner@Stephens-MBP ~ % ps ax | grep go-ipfs
20619   ??  S      0:02.36 /Users/stephendonner/Library/Application Support/BraveSoftware/Brave-Browser/nljcddpbnaianmglkpkneakjaapinabi/1.0.10/go-ipfs_v0.10.0_darwin-amd64 daemon --migrate=true --enable-gc --routing=dhtclient --agent-version-suffix=brave
20628 s000  S+     0:00.00 grep go-ipfs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/ipfs OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants