-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run go-ipfs with brave agent version suffix #18505
Comments
Posted a security review to make sure this is ok, but I don't see a problem with doing this. |
Verified
|
Brave | 1.32.46 Chromium: 94.0.4606.71 (Official Build) nightly (x86_64) |
---|---|
Revision | 1d32b169326531e600d836bd395efc1b53d0f6ef-refs/branch-heads/4606@{#1256} |
OS | macOS Version 11.6 (Build 20G165) |
Steps:
- new profile
- launched Brave
- opened
brave://ipfs
and clickedInstall and start
(confirmed I gotgo-ipfs 0.9.1
) - in
Terminal.app
, enteredps ax | grep go-ipfs
- confirmed I didn't see
--agent-version-suffix=brave
in the output - new profile
- launched Brave with
--use-dev-goupdater-url
- opened
brave://ipfs
and clickedInstall and start
(confirmed I gotgo-ipfs 0.10.0
) - in
Terminal.app
, enteredps | ax | grep go-ipfs
- confirmed I saw
--agent-version-suffix=brave
in the output - confirmed
brave
shows up now underNode info
onbrave://ipfs
before fix (Version: go-ipfs/0.9.1/) |
after fix (Version: go-ipfs/0.10.0/brave) |
---|---|
go-ipfs 0.9.1
stephendonner@Stephens-MacBook-Pro ~ % ps ax | grep go-ipfs 51152 s000 S+ 0:02.36 /Users/stephendonner/Library/Application Support/BraveSoftware/Brave-Browser-Nightly/nljcddpbnaianmglkpkneakjaapinabi/1.0.6/go-ipfs_v0.9.1_darwin-amd64 daemon --migrate=true --enable-gc --routing=dhtclient
go-ipfs 0.10.0
stephendonner@Stephens-MacBook-Pro ~ % ps ax | grep go-ipfs 51007 s000 S+ 0:40.59 /Users/stephendonner/Library/Application Support/BraveSoftware/Brave-Browser-Nightly/nljcddpbnaianmglkpkneakjaapinabi/1.0.54/go-ipfs_v0.10.0_darwin-amd64 daemon --migrate=true --enable-gc --routing=dhtclient --agent-version-suffix=brave
Adding |
Removing |
Verified
|
Brave | 1.31.84 Chromium: 95.0.4638.40 (Official Build) (x86_64) |
---|---|
Revision | e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624} |
OS | macOS Version 11.6 (Build 20G165) |
Steps:
- new profile
- launched Brave
- opened brave://ipfs and clicked Install and start (confirmed I got go-ipfs 0.10.0)
- in Terminal.app, entered
ps | ax | grep go-ipfs
- confirmed I saw
--agent-version-suffix=brave
in the output - confirmed
brave
shows up now under Node info onbrave://ipfs
stephendonner@Stephens-MBP ~ % ps ax | grep go-ipfs
20619 ?? S 0:02.36 /Users/stephendonner/Library/Application Support/BraveSoftware/Brave-Browser/nljcddpbnaianmglkpkneakjaapinabi/1.0.10/go-ipfs_v0.10.0_darwin-amd64 daemon --migrate=true --enable-gc --routing=dhtclient --agent-version-suffix=brave
20628 s000 S+ 0:00.00 grep go-ipfs
go-ipfs 0.10.0 shipped with support for running
ipfs daemon
with custom--agent-version-suffix
(ipfs/kubo#8419)Soon, we will be running our ipfs-desktop nodes with
--agent-version-suffix=desktop
, and it would be useful to run Brave instances with--agent-version-suffix=brave
to have better insight into metrics / DHT distribution / usage patterns.Agent Version can be read via
ipfs id | jq .AgentVersion
:go-ipfs/0.10.0/
- standalone go-ipfs binarygo-ipfs/0.10.0/desktop
- node managed by IPFS Desktopgo-ipfs/0.10.0/brave
- node managed by Brave@bbondy @autonome Thoughts?
I remember we wanted to do this a while ago, but it was not possible without recompiling go-ipfs.
(Now it's just a runtime flag which we could enable after upgrading Brave to go-ipfs 0.10.0)
The text was updated successfully, but these errors were encountered: