Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --agent-version-suffix for ipfs binaries 0.10.0+ #10363

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Oct 5, 2021

Resolves brave/brave-browser#18505

  • Added --agent-version-suffix for ipfs binaries 0.10.0+
  • Extract version to check from filename

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • clear profile, install 0.9.1 node or older
  • check go-ipfs command line, should be without agent-version-suffix command line
  • update it to 0.10.0 with --use-dev-goupdater-url
  • check go-ipfs command line has --agent-version-suffix=brave

@spylogsster spylogsster merged commit 1f19abc into master Oct 5, 2021
@spylogsster spylogsster deleted the issue-18505 branch October 5, 2021 17:39
@spylogsster spylogsster added this to the 1.32.x - Nightly milestone Oct 5, 2021
spylogsster pushed a commit that referenced this pull request Oct 8, 2021
spylogsster pushed a commit that referenced this pull request Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run go-ipfs with brave agent version suffix
2 participants