Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] OpenSearch toggle is missing #18521

Closed
Madis0 opened this issue Oct 4, 2021 · 3 comments · Fixed by brave/brave-core#10415
Closed

[Regression] OpenSearch toggle is missing #18521

Madis0 opened this issue Oct 4, 2021 · 3 comments · Fixed by brave/brave-core#10415

Comments

@Madis0
Copy link

Madis0 commented Oct 4, 2021

Description

The OpenSearch toggle added in brave/brave-core#9602 and discussed in #867 is no longer there.

Steps to Reproduce

  1. Open Brave settings
  2. Scroll to search Engines
  3. Look for the OpenSearch toggle

Actual result:

There is a Web Discovery Project toggle instead.

Expected result:

Expected both, OpenSearch toggle and Web Discovery Project toggle

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.31.68 Chromium: 94.0.4606.61 (Official build) dev (64-bit)
Revision 418b78f5838ed0b1c69bb4e51ea0252171854915-refs/branch-heads/4606@{#1204}
OS Windows 10 Version 21H1 (Build 19043.1237)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Untested
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No

Miscellaneous Information:

It did exist on at least 1.30.69 beta/dev.

@rahulsnkr @bsclifton

@kjozwiak
Copy link
Member

Adding QA/Blocked as the above will require a 1.31.x RC which I'm hoping to kick off tonight 👍 We'll need 1.31.84 or higher.

@LaurenWags
Copy link
Member

Removing QA/Blocked since 1.31.84 is available - https://github.com/brave/brave-browser/releases/tag/v1.31.84

@stephendonner
Copy link

stephendonner commented Oct 13, 2021

Verified PASSED using

Brave 1.31.84 Chromium: 95.0.4638.40 (Official Build) (x86_64)
Revision e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS macOS Version 11.6 (Build 20G165)

Steps:

  1. new profile
  2. launched Brave
  3. opened brave://settings/search
  4. confirmed Index other search engines is present again beneath the Web Discovery Project preferences

Screen Shot 2021-10-13 at 8 57 23 AM


Verified PASSED using

Brave 1.31.84 Chromium: 95.0.4638.40 (Official Build) (64-bit)
Revision e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS Linux

Steps:

  1. new profile
  2. launched Brave
  3. opened brave://settings/search
  4. confirmed Index other search engines is present again beneath the Web Discovery Project preferences

Screen Shot 2021-10-13 at 12 31 53 PM


Verification passed on


Brave | 1.31.84 Chromium: 95.0.4638.40 (Official Build) (64-bit)
-- | --
Revision | e3e7c76ba0284b16087cf4cf3153abfaef6470c7-refs/branch-heads/4638@{#624}
OS | Windows 10 Version 21H1 (Build 19043.1266)

Steps:

  1. new profile
  2. launched Brave
  3. opened brave://settings/search
  4. confirmed Index other search engines is present again beneath the Web Discovery Project preferences

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment