Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 96.0.4664.27 to Chromium 96.0.4664.35. #19215

Closed
mkarolin opened this issue Nov 3, 2021 · 5 comments · Fixed by brave/brave-core#10861 or #19216
Closed

Upgrade from Chromium 96.0.4664.27 to Chromium 96.0.4664.35. #19215

mkarolin opened this issue Nov 3, 2021 · 5 comments · Fixed by brave/brave-core#10861 or #19216

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Nov 3, 2021

Minor Chromium bump.

https://chromium.googlesource.com/chromium/src/+log/96.0.4664.27..96.0.4664.35?pretty=fuller&n=10000

QA tests:

Check branding items
Check for version bump

Additional checks:

No specific code changes in Brave (only line number changes in patches).

@LaurenWags
Copy link
Member

@brave/legacy_qa when testing please ensure that all "Affected areas" from #18131 (comment) have been checked.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 10, 2021

Verification passed on


Brave | 1.32.97 Chromium: 96.0.4664.35 (Official Build) (64-bit)
-- | --
Revision | 8df3babf8da8faa8aacb78f4848ef66a93b4944b-refs/branch-heads/4664@{#680}
OS | Windows 10 Version 21H1 (Build 19043.1288)

Settings UI
Example Example
image image
Avatar button
Example Example
image image
brave://components - PKI Metadata
  • A new component PKI Metadata is added as part of CR96
  • All the components are up-to-date after the update

image

theme colors
  • Able to change the theme color for brave
  • Theme color takes effect after adding it to brave
Example Example
image image
Site info dialog on IPFS sites ![image](https://user-images.githubusercontent.com/38657976/141311288-b8e40b49-743d-4683-8450-37ed1538cb45.png)

@stephendonner
Copy link

stephendonner commented Nov 10, 2021

Verified PASSED using

Brave 1.32.97 Chromium: 96.0.4664.35 (Official Build) (x86_64)
Revision 8df3babf8da8faa8aacb78f4848ef66a93b4944b-refs/branch-heads/4664@{#680}
OS macOS Version 11.6.1 (Build 20G224)
1.31.91 1.32.97
Screen Shot 2021-11-10 at 2 20 27 PM Screen Shot 2021-11-10 at 2 17 47 PM
Settings UI
  • Confirmed Safety check moved from top-level menu to inside Privacy and security
  • Confirmed all other UI items remain present/same location
  • Confirmed Settings' categories are now single-pane, and cannot be scrolled into other areas
Safety check 1.31.91 Safety check 1.32.97
Screen Shot 2021-11-10 at 1 46 05 PM Screen Shot 2021-11-10 at 2 01 04 PM
Avatar button
1.31.91 1.32.97
Screen Shot 2021-11-10 at 2 11 43 PM Screen Shot 2021-11-10 at 2 02 16 PM
Profiles screen
1.31.91 1.32.97
Screen Shot 2021-11-10 at 2 30 52 PM Screen Shot 2021-11-10 at 2 33 14 PM
brave://components - PKI Metadata
  • Confirmed new component PKI Metadata is at version 75
  • Confirmed it's Up-to-date
  • Confirmed it's updated via our proxy
1.31.91 1.32.97
Not present Screen Shot 2021-11-10 at 1 37 37 PM
Theme colors
1.31.91 (light) 1.31.91 (dark) 1.32.97 (light) 1.32.97 (dark)
Screen Shot 2021-11-10 at 1 44 46 PM Screen Shot 2021-11-10 at 1 45 02 PM Screen Shot 2021-11-10 at 1 54 26 PM Screen Shot 2021-11-10 at 1 54 41 PM
Site info dialog on IPFS sites
1.31.91 1.32.97
Screen Shot 2021-11-10 at 1 46 36 PM Screen Shot 2021-11-10 at 1 53 57 PM

Verification passed on

Brave 1.32.99 Chromium: 96.0.4664.35 (Oficjalna wersja) (64-bitowa)
Revision 8df3babf8da8faa8aacb78f4848ef66a93b4944b-refs/branch-heads/4664@{#680}
OS Ubuntu 18.04 LTS

image

Settings UI
  • Confirmed Safety check moved from top-level menu to inside Privacy and security
  • Confirmed all other UI items remain present/same location
  • Confirmed Settings' categories are now single-pane, and cannot be scrolled into other areas

image

Avatar button

image

Profiles screen

image

brave://components - PKI Metadata

image

Theme colors

image
image

Site info dialog on IPFS sites

image

@stephendonner
Copy link

stephendonner commented Nov 11, 2021

Verified PASSED using Brave 1.32.99, Chromium 96.0.4664.35 on Google Pixel XL, running Android 9.

Screenshot_20211111-144721

Privacy settings * confirmed various privacy settings are default + work as expected

Screenshot_20211111-141435

Night mode * confirmed night mode works as expected
example example
Screenshot_20211111-141615 Screenshot_20211111-141630
Tabs overview UI * confirmed new tabs-overview UI works as expected for both regular and Private tabs
example example example example example
Screenshot_20211111-142827 Screenshot_20211111-143609 Screenshot_20211111-144304 Screenshot_20211111-144329 Screenshot_20211111-144337
Sync
  • confirmed no warning dialog on creating a new Sync chain
  • confirmed I can join a Sync chain (via code words + QR)
  • confirmed I can start a new Sync chain
  • confirmed both mobile and desktop clients can join my Sync chain
example example example
Screenshot_20211111-141751 Screenshot_20211111-141941 Screenshot_20211111-142149

Verification passed on Brave v1.32.99 on Samsung Galaxy Tab S5e (Android 10.0)

Screenshot_20211115-161055_Brave

Privacy settings * confirmed various privacy settings are default + work as expected
Night mode * confirmed night mode works as expected
Tabs overview UI * confirmed new tabs-overview UI works as expected for both regular and Private tabs
Sync
  • confirmed no warning dialog on creating a new Sync chain
  • confirmed I can join a Sync chain (via code words + QR)
  • confirmed I can start a new Sync chain
  • confirmed both mobile and desktop clients can join my Sync chain

@btlechowski btlechowski added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass - Android Tab QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 12, 2021
@kjozwiak
Copy link
Member

We'll be using #19387 as release-notes/include 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment