Upgrade from Chromium 96.0.4664.27 to Chromium 96.0.4664.35 #10861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
…anager Chromium change: chromium/chromium@d35392a [Start] Recreate CTA if homepage settings changes Start surface state. When homepage is enabled/disabled or chrome's homepage URI is changed, Start surface may be switched from enabled to disabled or vice verse. When the state is switched, it may require to create StartSurface and the toolbar. Recreate ChromeTabbedActivity to adopt the changes. Additionally, tab reparenting are handled here. Demo: https://drive.google.com/file/d/1bQccNFPcbeTsDADbYdat0Epwql9PpV1c/view?usp=sharing (cherry picked from commit d291ab2) Bug: 1258206
Fixes 20:02:09 In file included from ../../brave/browser/notifications/ads_notification_handler.cc:10: 20:02:09 In file included from ../../brave/browser/brave_ads/ads_service_factory.h:12: 20:02:09 ../../brave/components/brave_ads/browser/ads_service.h:17:10: fatal error: 'brave/vendor/bat-native-ads/include/bat/ads/public/interfaces/ads.mojom.h' file not found 20:02:09 #include "brave/vendor/bat-native-ads/include/bat/ads/public/interfaces/ads.mojom.h" 20:02:09 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 20:02:09 1 error generated.
bbondy
approved these changes
Nov 4, 2021
mkarolin
pushed a commit
that referenced
this pull request
Nov 4, 2021
Upgrade from Chromium 96.0.4664.27 to Chromium 96.0.4664.35
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#19215
Related PR: brave/brave-browser#19216
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: