Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sync] Devices reappear after removing from the sync chain #19561

Closed
AlexeyBarabash opened this issue Nov 18, 2021 · 8 comments · Fixed by brave/brave-core#11313
Closed

[Sync] Devices reappear after removing from the sync chain #19561

AlexeyBarabash opened this issue Nov 18, 2021 · 8 comments · Fixed by brave/brave-core#11313
Assignees
@AlexeyBarabash
Labels
feature/sync OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.34.x - Release

Comments

@AlexeyBarabash
Copy link
Contributor

Description

Issue reported by @iefremov

May be related to https://bugs.chromium.org/p/chromium/issues/detail?id=1225961

Basically I add a device to the existing chain, then remove and it reappears after a while - sometimes immediately, sometimes after 1-3 minutes.
Tried one more time: removed a phone from the chain on desktop browser. After ~10 minutes phone is not shown on the chain on desktop (which is good), but the browser on the phone itself is synced, shows the whole chain on the settings page.

Steps to Reproduce

  1. Create a sync chain between two desktop profiles
  2. From deviceA remove deviceB
  3. Wait ~3 minutes

Actual result:

  1. deviceB disappears from the devices list at deviceA, but then re-appears
  2. deviceB never goes into sync is turned off state

Expected result:

  1. deviceB disappears from the devices list at deviceA, and then doesn't re-appear
  2. deviceB goes into sync is turned off state

Reproduces how often:

Easily reproduced

Desktop Brave version:

Confirmed at

Brave 1.33.77 Chromium: 96.0.4664.35 (Official Build) unknown (64-bit)
Revision 8df3babf8da8faa8aacb78f4848ef66a93b4944b-refs/branch-heads/4664@{#680}

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @jsecretan , @darkdh
@AlexeyBarabash AlexeyBarabash added feature/sync OS/Android Fixes related to Android browser functionality OS/Desktop labels Nov 18, 2021
@jsecretan jsecretan added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 18, 2021
@AlexeyBarabash AlexeyBarabash self-assigned this Nov 26, 2021
@AlexeyBarabash AlexeyBarabash mentioned this issue Nov 29, 2021
Merged
24 tasks
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Nov 29, 2021
@AlexeyBarabash
Fix ability to delete other device from the sync chain
7864b7b 
fixes brave/brave-browser#19561

This commit reverts commit
https://chromium-review.googlesource.com/c/chromium/src/+/3001364
from the upstream because it breaks ability to delete other device from the sync chain
@AlexeyBarabash AlexeyBarabash added this to the 1.34.x - Beta milestone Nov 30, 2021
@LaurenWags
Copy link
Member

@brave/legacy_qa check leaving a sync chain with various devices/platforms

@stephendonner stephendonner mentioned this issue Dec 17, 2021
Closed
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 18, 2021
@stephendonner
Copy link

stephendonner commented Dec 21, 2021 •
edited
Loading

Verification PASSED using

Brave 1.34.70 Chromium: 97.0.4692.56 (Official Build) beta (64-bit)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS Windows 10 Version 20H2 (Build 19042.1415)

Windows --> iOS - PASSED

  1. new profile of 1.34.x on Windows 10
  2. launch Brave
  3. set up a Sync chain
  4. join Sync chain from iOS by scanning the QR code
  5. from desktop, click on the trashcan icon to remove the iOS device
  6. click OK when prompted to confirm
  7. wait 3 minutes
  8. look at the Sync screen on Windows
  9. look at the Sync screen on iOS
  10. Confirmed the Windows desktop remains
  11. Confirmed the iOS device is removed

Windows --> Android - PASSED

  1. new profile of 1.34.x on Windows 10
  2. launch Brave
  3. set up a Sync chain
  4. join Sync chain from Android by scanning the QR code
  5. from desktop, click on the trashcan icon to remove the Android device
  6. click OK when prompted to confirm
  7. wait 3 minutes
  8. look at the Sync screen on Windows
  9. look at the Sync screen on Android
  10. Confirmed the Windows 10 desktop remains
  11. Confirmed the Android device is removed

Windows --> Windows - PASSED

  1. fresh install Brave on Windows 10 & Windows 11
  2. from Windows 10, start a Sync chain
  3. copy the code words
  4. join the Sync chain on Windows 11 by pasting in the copied code words
  5. from Windows 10, click on the trashcan icon to remove the Windows 11 device
  6. look at the Sync screen on Windows 10
  7. look at the Sync screen on Windows 11

Confirmed the Windows 10 desktop remains
Confirmed the Windows 11 desktop is removed

iOS --> Windows - PASSED

  1. fresh install Brave for iOS1.34.x
  2. tap through onboarding
  3. tap on the 3-dots icon on the bottom right of the toolbar
  4. tap Settings
  5. tap Sync
  6. tap Start a new sync chain
  7. tap Add a computer
  8. copy the code words
  9. on Windows, launch Brave 1.34.x
  10. load brave://settings/braveSync
  11. click on Start using sync
  12. click I have a Sync Code
  13. paste the code words and click Confirm
  14. click OK
  15. tap on the Windows device on iOS
  16. tap Remove device
  17. tap Remove
  18. wait 3 minutes
  19. look at the Sync screen on iOS
  20. look at the Sync screen on Windows

Confirmed the iOS device remains
Confirmed the Windows desktop is removed

Android --> Windows - PASSED

  1. fresh install Brave for Android 1.34.x
  2. tap through onboarding
  3. tap on the 3-dots icon on the bottom right of the toolbar
  4. tap Settings
  5. tap Sync
  6. tap Start a new sync chain
  7. tap Add a computer
  8. copy the code words
  9. on macOS, launch Brave 1.34.x
  10. load brave://settings/braveSync
  11. click on Start using sync
  12. click I have a Sync Code
  13. paste the code words and click Confirm
  14. click OK
  15. click on the trashcan icon to remove Windows
  16. wait 3 minutes
  17. look at the Sync screen on Android
  18. look at the Sync screen on Windows

Confirmed the Android device remains
Confirmed the Windows desktop is removed

iOS --> Android - PASSED

  1. fresh install Brave for iOS 1.34.x
  2. tap through onboarding
  3. tap on the 3-dots icon on the bottom right of the toolbar
  4. tap Settings
  5. tap Sync
  6. tap Start a new sync chain
  7. tap Tablet or phone
  8. on Android, launch Brave 1.34.x
  9. load brave://settings/braveSync
  10. tap on Start using sync
  11. tap Scan or enter sync code
  12. scan the iOS QR code
  13. tap OK
  14. on iOS, tap on the Android device
  15. tap Remove device
  16. tap Remove
  17. wait 3 minutes
  18. look at the Sync screen on iOS
  19. look at the Sync screen on Android

Confirmed the iOS device remains
Confirmed the Android device is removed

Android --> iOS - PASSED

  1. fresh install Brave for Android 1.34.x
  2. tap through onboarding
  3. tap on the 3-dots icon on the bottom right of the toolbar
  4. tap Settings
  5. tap Sync
  6. tap Start a new sync chain
  7. tap Add a Mobile Device.
  8. on iOS, launch Brave 1.34.x
  9. tap on the 3-dots menu, Settings -> Sync
  10. tap I have a Sync Code
  11. scan the QR code on Android
  12. on Android, tap on the trashcan next to the iOS device
  13. tap OK when prompted to remove device
  14. wait 3 minutes
  15. look at the Sync screen on Android
  16. look at the Sync screen on iOS

Confirmed the Android device remains
Confirmed the iOS device is removed

Windows--> iOS and Android - PASSED

  1. new profile of 1.34.x on Windows 10
  2. launch Brave
  3. click on Start a new sync chain
  4. click on Phone/Tablet
  5. join Sync chain from iOS
  6. join Sync chain from Android
  7. from desktop, click on the trashcan icons to remove both iOS & Android devices
  8. click OK when prompted to confirm
  9. wait 3 minutes
  10. look at the Sync screen on Windows
  11. look at the Sync screen on iOS
  12. look at the Sync screen on Android

Confirmed the Windows desktop remains
Confirmed the iOS device is removed
Confirmed the Android device is removed

Windows --> macOS, iOS, and Android - PASSED

  1. new profile of 1.34.x on Windows 10
  2. launch Brave
  3. click on Start a new sync chain
  4. click on Phone/Tablet
  5. join Sync chain from iOS
  6. join Sync chain from Android
  7. join Sync chain from macOS
  8. from Windows, click on the trashcan icons to remove the macOS, iOS, & Android devices
  9. click OK when prompted to confirm
  10. wait 3 minutes
  11. look at the Sync screen on Windows
  12. look at the Sync screen on macOS
  13. look at the Sync screen on iOS
  14. look at the Sync screen on Android

Confirmed the Windows desktop remains
Confirmed the macOS desktop is removed
Confirmed the iOS device is removed
Confirmed the Android device is removed

@stephendonner
Copy link

Setting to QA/Blocked as we're unable to get iOS devices removed remotely, due to brave/brave-ios#4747. Will revisit the FAILED tests when the above is addressed, and unblocking us.

@stephendonner stephendonner added QA/Blocked and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 21, 2021
@Brandon-T Brandon-T mentioned this issue Dec 21, 2021
Closed
@stephendonner
Copy link

stephendonner commented Dec 22, 2021 •
edited
Loading

Setting to QA/Blocked as we're unable to get iOS devices removed remotely, due to brave/brave-ios#4747. Will revisit the FAILED tests when the above is addressed, and unblocking us.

The above issue is itself now blocked by a crasher (which has a fix we'll get tomorrow): brave/brave-ios#4764.

@stephendonner
Copy link

stephendonner commented Dec 22, 2021 •
edited
Loading

Verified PASSED using Brave 1.34.70, Chromium 97.0.4692.56 on a Google Pixel XL (arm64) running Android 9.0

See verification notes from #19561 (comment) for:

  • Windows ==> Android
  • Android ==> Windows
  • iOS ==> Android
  • Windows ==> iOS and Android
  • Windows ==> macOS, iOS, and Android

@stephendonner
Copy link

stephendonner commented Dec 23, 2021 •
edited
Loading

Verification PASSED using

Brave 1.34.70 Chromium: 97.0.4692.56 (Official Build) beta (x86_64)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS macOS Version 11.6.1 (Build 20G224)

and the same version for Android; iOS is 1.34 (21.12.21.19)

macOS --> iOS - PASSED
  1. new profile of 1.34.x on macOS
  2. launch Brave
  3. set up a Sync chain
  4. join Sync chain from iOS by scanning the QR code
  5. from desktop, click on the trashcan icon to remove the iOS device
  6. click OK when prompted to confirm
  7. wait 3 minutes
  8. look at the Sync screen on macOS
  9. look at the Sync screen on iOS

Confirmed the macOS desktop remains
Confirmed the iOS device is removed

Example Example Example Example
Screen Shot 2021-12-22 at 9 37 27 PM Image from iOS Screen Shot 2021-12-22 at 9 37 42 PM Image from iOS (1)
macOS --> Android - PASSED
  1. new profile of 1.34.x on macOS
  2. launch Brave
  3. set up a Sync chain
  4. join Sync chain from Android by scanning the QR code
  5. from desktop, click on the trashcan icon to remove the Android device
  6. click OK when prompted to confirm
  7. wait 3 minutes
  8. look at the Sync screen on macOS
  9. look at the Sync screen on Android

Confirmed the macOS desktop remains
Confirmed the Android device is removed

Example Example Example Example
Screen Shot 2021-12-22 at 9 47 05 PM Screenshot_20211222-214709 Screen Shot 2021-12-22 at 9 47 15 PM Screenshot_20211222-214739
macOS (x86) --> macOS (arm64) - PASSED
  1. fresh install Brave on macOS (x86) & macOS (arm64)
  2. from macOS (x86), start a Sync chain
  3. copy the code words
  4. join the Sync chain on macOS (arm64) by pasting in the copied code words
  5. from macOS (x86), click on the trashcan icon to remove the macOS (arm64) device
  6. look at the Sync screen on macOS (x86)
  7. look at the Sync screen on macOS (arm64)

Confirmed the macOS (x86) desktop remains
Confirmed the macOS (arm64) desktop is removed

Example Example Example Example
Screen Shot 2021-12-22 at 10 57 44 PM Screen Shot 2021-12-22 at 10 57 44 PM Screen Shot 2021-12-22 at 10 57 54 PM Screen Shot 2021-12-22 at 10 58 30 PM
iOS --> macOS - PASSED
  1. fresh install Brave for iOS 1.34.x
  2. tap through onboarding
  3. tap on the 3-dots icon on the bottom right of the toolbar
  4. tap Settings
  5. tap Sync
  6. tap Start a new sync chain
  7. tap Add a computer
  8. copy the code words
  9. on macOS, launch Brave 1.34.x
  10. load brave://settings/braveSync
  11. click on Start using sync
  12. click I have a Sync Code
  13. paste the code words and click Confirm
  14. click OK
  15. tap on the macOS device on iOS
  16. tap Remove device
  17. tap Remove
  18. wait 3 minutes
  19. look at the Sync screen on iOS
  20. look at the Sync screen on macOS

Confirmed the iOS device remains
Confirmed the macOS desktop is removed

Example Example Example Example
Image from iOS (4) Screen Shot 2021-12-22 at 9 59 22 PM Image from iOS (5) Screen Shot 2021-12-22 at 9 59 52 PM
Android --> macOS - PASSED
  1. fresh install Brave for Android 1.34.x
  2. tap through onboarding
  3. tap on the 3-dots icon on the bottom right of the toolbar
  4. tap Settings
  5. tap Sync
  6. tap Start a new sync chain
  7. tap Add a computer
  8. copy the code words
  9. on macOS, launch Brave 1.34.x
  10. load brave://settings/braveSync
  11. click on Start using sync
  12. click I have a Sync Code
  13. paste the code words and click Confirm
  14. click OK
  15. click on the trashcan icon to remove macOS
  16. wait 3 minutes
  17. look at the Sync screen on Android
  18. look at the Sync screen on macOS

Confirmed the Android device remains
Confirmed the macOS desktop is removed

Example Example Example Example
Screen Shot 2021-12-22 at 9 53 04 PM Image from iOS Screen Shot 2021-12-22 at 9 53 13 PM Image from iOS (3)
macOS--> iOS and Android - PASSED
  1. new profile of 1.34.x on macOS
  2. launch Brave
  3. click on Start a new Sync chain
  4. click on Phone/Tablet
  5. join Sync chain from iOS
  6. join Sync chain from Android
  7. from macOS, click on the trashcan icons to remove both iOS & Android devices
  8. click OK when prompted to confirm
  9. wait 3 minutes
  10. look at the Sync screen on macOS
  11. look at the Sync screen on iOS
  12. look at the Sync screen on Android

Confirmed the macOS desktop remains
Confirmed the iOS device is removed
Confirmed the Android device is removed

Example Example Example Example Example Example
Screen Shot 2021-12-22 at 10 11 21 PM Image from iOS (6) Screenshot_20211222-221126 Screen Shot 2021-12-22 at 10 12 02 PM Image from iOS (7) Screenshot_20211222-221220
macOS --> Windows, iOS, and Android - PASSED
  1. new profile of 1.34.x on Windows
  2. launch Brave
  3. click on Start a new sync chain
  4. click on Phone/Tablet
  5. join Sync chain from iOS
  6. join Sync chain from Android
  7. join Sync chain from Windows
  8. from macOS, click on the trashcan icons to remove the macOS, iOS, & Android devices
  9. click OK when prompted to confirm
  10. wait 3 minutes
  11. look at the Sync screen on macOS
  12. look at the Sync screen on Windows
  13. look at the Sync screen on iOS
  14. look at the Sync screen on Android

Confirmed the macOS desktop remains
Confirmed the Windows desktop is removed
Confirmed the iOS device is removed
Confirmed the Android device is removed

Example Example Example Example
Screen Shot 2021-12-22 at 10 21 55 PM all-four-clients Image from iOS Screenshot_20211222-222144
Example Example Example Example
Screen Shot 2021-12-22 at 10 23 17 PM all-clients-gone Image from iOS Screenshot_20211222-222217

@stephendonner
Copy link

stephendonner commented Dec 23, 2021 •
edited
Loading

I botched a simple copy and paste operation, and overwrote (and then made another silly mistake and deleted the wrong edit on the comment) my Windows-verification notes. I'll rebuild them (without screenshots), but leave the label standing, as I've done the work).

#19561 (comment)

@btlechowski
Copy link

btlechowski commented Dec 24, 2021 •
edited
Loading

Verification passed on

Brave 1.34.71 Chromium: 97.0.4692.56 (Official Build) beta (64-bit)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS Ubuntu 18.04 LTS

and the same version for Android; iOS is 1.34 (21.12.21.19)

Linux --> iOS - PASSED
  1. new profile of 1.34.x on Linux
  2. launch Brave
  3. set up a Sync chain
  4. join Sync chain from iOS by scanning the QR code
  5. from desktop, click on the trashcan icon to remove the iOS device
  6. click OK when prompted to confirm
  7. wait 3 minutes
  8. look at the Sync screen on Linux
  9. look at the Sync screen on iOS

Confirmed the Linux desktop remains
Confirmed the iOS device is removed

image image IMG_0079
Linux --> Android - PASSED
  1. new profile of 1.34.x on Linux
  2. launch Brave
  3. set up a Sync chain
  4. join Sync chain from Android by scanning the QR code
  5. from desktop, click on the trashcan icon to remove the Android device
  6. click OK when prompted to confirm
  7. wait 3 minutes
  8. look at the Sync screen on Linux
  9. look at the Sync screen on Android

Confirmed the Linux desktop remains
Confirmed the Android device is removed

image image Screenshot_20211224-220617_Brave - Beta
iOS --> Linux - PASSED
  1. fresh install Brave for iOS 1.34.x
  2. tap through onboarding
  3. tap on the 3-dots icon on the bottom right of the toolbar
  4. tap Settings
  5. tap Sync
  6. tap Start a new sync chain
  7. tap Add a computer
  8. copy the code words
  9. on Linux, launch Brave 1.34.x
  10. load brave://settings/braveSync
  11. click on Start using sync
  12. click I have a Sync Code
  13. paste the code words and click Confirm
  14. click OK
  15. tap on the Linux device on iOS
  16. tap Remove device
  17. tap Remove
  18. wait 3 minutes
  19. look at the Sync screen on iOS
  20. look at the Sync screen on Linux

Confirmed the iOS device remains
Confirmed the Linux desktop is removed

image image IMG_0080
Android --> Linux - PASSED
  1. fresh install Brave for Android 1.34.x
  2. tap through onboarding
  3. tap on the 3-dots icon on the bottom right of the toolbar
  4. tap Settings
  5. tap Sync
  6. tap Start a new sync chain
  7. tap Add a computer
  8. copy the code words
  9. on Linux, launch Brave 1.34.x
  10. load brave://settings/braveSync
  11. click on Start using sync
  12. click I have a Sync Code
  13. paste the code words and click Confirm
  14. click OK
  15. click on the trashcan icon to remove Linux
  16. wait 3 minutes
  17. look at the Sync screen on Android
  18. look at the Sync screen on Linux

Confirmed the Android device remains
Confirmed the Linux desktop is removed

image image Screenshot_20211224-220811_Brave - Beta
Linux --> Windows, iOS, and Android - PASSED
  1. new profile of 1.34.x on Windows
  2. launch Brave
  3. click on Start a new sync chain
  4. click on Phone/Tablet
  5. join Sync chain from iOS
  6. join Sync chain from Android
  7. join Sync chain from Windows
  8. from Linux, click on the trashcan icons to remove the Windows, iOS, & Android devices
  9. click OK when prompted to confirm
  10. wait 3 minutes
  11. look at the Sync screen on Linux
  12. look at the Sync screen on Windows
  13. look at the Sync screen on iOS
  14. look at the Sync screen on Android

Confirmed the Linux desktop remains
Confirmed the Windows desktop is removed
Confirmed the iOS device is removed
Confirmed the Android device is removed

image image Screenshot_20211224-223158_Brave - Beta IMG_0081
image image Screenshot_20211224-223455_Brave - Beta IMG_0082

Verification passed on Brave v1.34.73 on Samsung Galaxy Tab S5e (Android 10.0)

Linux --> Android Tab - PASSED
  1. new profile of 1.34.x on Linux
  2. launch Brave
  3. set up a Sync chain
  4. join Sync chain from Android by scanning the QR code
  5. from desktop, click on the trashcan icon to remove the Android device
  6. click OK when prompted to confirm
  7. wait 3 minutes
  8. look at the Sync screen on Linux
  9. look at the Sync screen on Android

Confirmed the Linux desktop remains
Confirmed the Android device is removed

image image Screenshot_20211225-014403_Brave - Beta Screenshot_20211225-014525_Brave - Beta
Android Tab --> Linux - PASSED
  1. fresh install Brave for Android 1.34.x
  2. tap through onboarding
  3. tap on the 3-dots icon on the bottom right of the toolbar
  4. tap Settings
  5. tap Sync
  6. tap Start a new sync chain
  7. tap Add a computer
  8. copy the code words
  9. on Linux, launch Brave 1.34.x
  10. load brave://settings/braveSync
  11. click on Start using sync
  12. click I have a Sync Code
  13. paste the code words and click Confirm
  14. click OK
  15. click on the trashcan icon to remove Linux
  16. wait 3 minutes
  17. look at the Sync screen on Android
  18. look at the Sync screen on Linux

Confirmed the Android device remains
Confirmed the Linux desktop is removed

Screenshot_20211225-014832_Brave - Beta|Screenshot_20211225-014916_Brave - Beta|
image|image
--|--|--|--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
feature/sync OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.34.x - Release
Development

Successfully merging a pull request may close this issue.

Fix ability to delete other device from the sync chain brave/brave-core
5 participants
@jsecretan @stephendonner @AlexeyBarabash @LaurenWags @btlechowski