Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll (swipe?) position in viewport not retained between tab switches #20580

Closed
stephendonner opened this issue Jan 20, 2022 · 4 comments · Fixed by brave/brave-core#12908
Closed
Assignees
Labels
bug feature/brave-news formerly brave-today OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Device-Types QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@stephendonner
Copy link

Description

Scroll (swipe?) position in viewport not retained between tab switches

Steps to reproduce

  1. install 1.36.47, Chromium 97.0.4692.71
  2. launch Brave
  3. tap through onboarding
  4. restart Brave (to pick up Griffin seed changes)
  5. open a new-tab page
  6. tap to Show Brave News
  7. swipe up until your article is near the top Brave News dynamic toolbar pane
  8. tap on the tabs-overview button on the bottom Brave toolbar (in-between the 🔍 and the 3-dots menu item)
  9. now tab back on your Brave News article

Actual vs. Expected

actual expected
Screenshot_20220119-175209 Screenshot_20220119-175217

Issue reproduces how often

100%

Device details

  • Install type (ARM, x86): arm64
  • Device type (Phone, Tablet, Phablet): Google Pixel XL phone
  • Android version: 9.0

Brave version

1.36.47, Chromium 97.0.4692.71

cc @alexsafe @petemill @mattmcalister @srirambv

@stephendonner stephendonner added bug QA/Yes QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality feature/brave-news formerly brave-today labels Jan 20, 2022
@srirambv
Copy link
Contributor

Still an issue. Easier steps to repro

  1. Enable News and opt-in
  2. Open a new tab and reload the page
  3. Automatically jumps to the middle of the feed. Doesn't stay on top with widgets in view
News.Feed.Jump.mp4

@kjozwiak
Copy link
Member

Above requires 1.38.98 or higher for 1.38.x verification.

@kjozwiak
Copy link
Member

Created a follow up via #22356 to improve Android keeping the correct position with the Brave News feed when switching tabs.

@Uni-verse
Copy link
Contributor

Uni-verse commented Apr 20, 2022

Verification completed using 1.38.103, Chromium 100.0.4896.127

Devices:
Samsung Galaxy S21 running Android 12
Samsung Galaxy Tab S7 running Android 12

As mentioned in #22356 (comment) there are mainly two cases observed where the position is not retained and will need improvements. In the case of scrolling through articles in feed, when using the tab tray and returning to the same tab, the position is shifted down slightly. Second case is where the first card is at the top of the screen just below the news setting bar, using the tab tray and return to this tab will change the position of the view to the top of NTP. This behavior is the same on Android Tablets.

Behavior on 1.38.x for Test Case #1 Position of card in feed

Original position After using tab overview
Screen Shot 2022-04-20 at 1 43 50 PM Screen Shot 2022-04-20 at 1 44 06 PM

Test Case #2 - First Card (1.38)

Original position After using tab overview
Screen Shot 2022-04-20 at 1 44 36 PM Screen Shot 2022-04-20 at 1 44 58 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/brave-news formerly brave-today OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Device-Types QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants