Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Brave news - ui fixes #12925

Merged
merged 46 commits into from
Apr 16, 2022
Merged

[Android] Brave news - ui fixes #12925

merged 46 commits into from
Apr 16, 2022

Conversation

alexsafe
Copy link
Contributor

@alexsafe alexsafe commented Apr 6, 2022 •
edited by kjozwiak
Loading

Uplift of #12908
Fixes brave/brave-browser#21868
Fixes brave/brave-browser#20580
Fixes brave/brave-browser#21873

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@alexsafe alexsafe added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Apr 6, 2022
@alexsafe alexsafe added this to the 1.38.x - Beta milestone Apr 6, 2022
@alexsafe alexsafe requested a review from a team April 6, 2022 21:41
brave-browser-releases and others added 13 commits April 7, 2022 04:01
@brave-browser-releases
1.38.83
ea25ef7
@brave-browser-releases
Uplift of #12852 (squashed) to beta
2505d64
@brave-browser-releases
Uplift of #12817 (squashed) to beta
027a1d1
@brave-browser-releases
1.38.84
0afc21f
@kjozwiak
Merge pull request #12850 from brave/pr12832_sszaloki-21209-http-400-…
68dc27e 
…region-not-supported_1.38.x

Implement unsupported regions in Rewards linking flow. (uplift to 1.38.x)
@kjozwiak
Merge pull request #12921 from brave/pr12920_android_send_to_device_c…
eed5011 
…rash_1.38.x

[Android] Fixed crash on sending tabs to another device (uplift to 1.38.x)
@tapanmodh
Android Brave News Scroll On Keyboard Close Fix
8e0addb
@kjozwiak
Merge pull request #12912 from brave/pr12904_ksmith-rewards-page-stat…
a34b924 
…e_1.38.x

Fix rewards page local storage loader (uplift to 1.38.x)
@brave-browser-releases
Uplift of #12917 (squashed) to beta
91401ea
@brave-browser-releases
Uplift of #12940 (squashed) to beta
4b1e224
@kjozwiak
Merge pull request #12943 from brave/pr12940_ios-url-pattern-wrapper_…
f2e182f 
…1.38.x

[iOS] Add Obj-C wrapper for URLPattern (uplift to 1.38.x)
@kjozwiak
Merge pull request #12894 from brave/shields-ui-fixes-1.38.x
7ce47f3 
Shields UI fixes (uplift to 1.38x)
@kjozwiak
Merge pull request #12938 from brave/pr12917_force-hide-regional-cosm…
620424a 
…etic-filters_1.38.x

Force hide cosmetic filters from regional lists in Standard Shields mode (uplift to 1.38.x)
brave-browser-releases and others added 16 commits April 10, 2022 07:21
@brave-browser-releases
Uplift of #12946 (squashed) to beta
8d6790b
@brave-browser-releases
1.38.88
7bcb524
@brave-browser-releases
Uplift of #12962 (squashed) to beta
bf69315
@kjozwiak
Merge pull request #12963 from brave/pr12962_update-wdp-to-fix-moment…
d9c3929 
…_1.38.x

Bump web-discovery-project to fix moment.js vulnerability (uplift to 1.38.x)
@brave-browser-releases
Uplift of #12882 (squashed) to beta
b6446da
@mkarolin
Merge pull request #12957 from brave/maxk-1.37.x-l10n
d213099 
Pulled l10n for 1.37.x release (Chromium 100). Part II.
@brave-browser-releases
1.38.89
62d2af2
@kjozwiak
Merge pull request #12918 from brave/android_enable_tab_groups_option…
4fb2bf8 
…_1.38.x

Android enable tab groups option (uplift to 1.38.x)
@kjozwiak
Merge pull request #12967 from brave/pr12882_fix-tab-mouseover-for-ch…
496769b 
…rome-sites_1.38.x

Fix tab mouseover for webpages that start with chrome (uplift to 1.38.x)
@brave-browser-releases
1.38.90
47ba766
@kjozwiak
Merge pull request #12960 from brave/pr12946_tab_text_color_windows_1…
59fef5d 
….38.x

Fixed inactive tab color is unreadable with accent color (uplift to 1.38.x)
@kjozwiak
Merge pull request #12969 from brave/maxk-1.37.x-l10n-II-1.38.x
030e06f 
Pulled l10n for 1.37.x release (Chromium 100). Part II. (uplift to 1.38.x)
@kjozwiak
Merge pull request #12814 from brave/pr12790_fix/21941_1.38.x
6c1dfe3 
Pass chain ID parameter in JsonRpcService GetERC721OwnerOf (uplift to 1.38.x)
@brave-browser-releases
1.38.91
d52965f
@alexsafe
[Android] Brave news - ui fixes
beebbd3
@alexsafe
Merge branch 'pr12908_bravenews-ui-fixes_1.38.x' of github.com:brave/…
027fbf1 
…brave-core into pr12908_bravenews-ui-fixes_1.38.x
@alexsafe alexsafe requested review from a team and samartnik as code owners April 12, 2022 14:47
@alexsafe alexsafe requested review from emerick and zenparsing and removed request for a team April 12, 2022 14:47
kjozwiak
kjozwiak approved these changes Apr 16, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.38.x approved 👍 QA has verified the PR on Nightly as per #12908 (comment).

@kjozwiak kjozwiak merged commit f422ef0 into 1.38.x Apr 16, 2022
@kjozwiak kjozwiak deleted the pr12908_bravenews-ui-fixes_1.38.x branch April 16, 2022 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@samartnik samartnik Awaiting requested review from samartnik samartnik is a code owner

@emerick emerick Awaiting requested review from emerick emerick is a code owner automatically assigned from brave/rewards-client

@zenparsing zenparsing Awaiting requested review from zenparsing zenparsing is a code owner automatically assigned from brave/rewards-client

Assignees

@alexsafe alexsafe

@brave-builds brave-builds

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.38.x - Release
Development

Successfully merging this pull request may close these issues.
8 participants
@alexsafe @kjozwiak @brave-builds @brave-browser-releases @nullhook @samartnik @tapanmodh @mkarolin