Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset wallet doesn't remove the Dapp connections #20966

Closed
srirambv opened this issue Feb 8, 2022 · 5 comments · Fixed by brave/brave-core#20840
Closed

Reset wallet doesn't remove the Dapp connections #20966

srirambv opened this issue Feb 8, 2022 · 5 comments · Fixed by brave/brave-core#20840
Assignees
Labels
bug feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 8, 2022

Description

Reset wallet doesn't remove the Dapp connections

Steps to Reproduce

  1. Create a wallet
  2. Link to wallet with multiple Dapps
  3. Reset wallet
  4. Go to brave://settings/content/ethereum, none of the Dapp connections are removed

Actual result:

Reset wallet doesn't remove the Dapp connections

Expected result:

Not sure may be reset since we reset everything else?

Reproduces how often:

Easy

Brave version (brave://version info)

All

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @bbondy @jamesmudgett @Douglashdaniel

@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 25, 2022
@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Backlog in Web3 Mar 18, 2022
@HEagle18
Copy link

HEagle18 commented Feb 2, 2023

Still an issue. Just tested on 1.48.

@Douglashdaniel
Copy link

cc: @darkdh @yrliou

@darkdh
Copy link
Member

darkdh commented Feb 2, 2023

We should also clear the content settings for wallet (Ethereum + Solana) when reset, otherwise when the user creates new wallet that has different addresses, those permissions are unusable.

@yrliou yrliou self-assigned this Feb 2, 2023
@yrliou
Copy link
Member

yrliou commented Feb 2, 2023

^ exactly, just assigned myself to this, will take care of this when I'm available.

@srirambv
Copy link
Contributor Author

srirambv commented Dec 7, 2023

Verification passed on

Brave 1.62.99 Chromium: 120.0.6099.62 (Official Build) beta (64-bit)
Revision 0f3e892de210168e788b3418961f94c4d0c5942a
OS Windows 11 Version 22H2 (Build 22621.2792)
  • Verified steps from issue description and brave/brave-core#20840
  • Verified resetting wallet also removes the saved Dapp connection info for both Ethereum and Solana accounts
20966.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants