Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Reset for wallet into BraveWalletService #20346

Closed
bbondy opened this issue Jan 5, 2022 · 2 comments · Fixed by brave/brave-core#11754
Closed

Move Reset for wallet into BraveWalletService #20346

bbondy opened this issue Jan 5, 2022 · 2 comments · Fixed by brave/brave-core#11754
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@bbondy
Copy link
Member

bbondy commented Jan 5, 2022

Currently the ResetWallet function is not usable from iOS.
This changes it so you only need to call reset on BraveWalletService.
It also fixes a bug with reloading a tab when not needed for restoring a wallet seed phrase.

QA test:

  • Test that resetting the wallet reloads the wallet tab that is already open (if you have one open)
  • Test that restoring seed phrase does not reload the active tab
  • Test that adding a custom chain and switching to it, then resetting the wallet resets things back to normal
@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop labels Jan 5, 2022
@bbondy bbondy self-assigned this Jan 5, 2022
@bbondy bbondy added priority/P3 The next thing for us to work on. It'll ride the trains. feature/web3/wallet Integrating Ethereum+ wallet support labels Jan 5, 2022
@bbondy bbondy added this to the 1.36.x - Nightly milestone Jan 6, 2022
@bbondy bbondy added the OS/iOS Fixes related to iOS browser functionality label Feb 7, 2022
@srirambv
Copy link
Contributor

srirambv commented Feb 8, 2022

Verification passed on Oppo Reno 5 with Android 11 running 1.36.85 x64 Beta build

  • Verified steps from issue description
  • Verified reset wallet closes the wallet window and goes back to tabs view when reset from within the wallet
  • Verified reset wallet from settings closes the settings page and goes back to tabs view
  • Verified custom networks are reset
  • Verified added custom tokens are reset

Verification passed on Samsung Tab A with Android 10 running 1.36.85 x64 Beta build

  • Verified steps from issue description
  • Verified reset wallet closes the wallet window and goes back to tabs view when reset from within the wallet
  • Verified reset wallet from settings closes the settings page and goes back to tabs view
  • Verified custom networks are reset
  • Verified added custom tokens are reset

@srirambv
Copy link
Contributor

srirambv commented Feb 8, 2022

Verification passed on

Brave 1.36.86 Chromium: 98.0.4758.87 (Official Build) beta (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS Linux
  • Verified test plan from issue description
  • Verified reset wallet reloads the existing wallet page
  • Verified reset removes all custom tokens added
  • Verified reset removes all custom networks that are added
  • Verified auto-lock is also reset when wallet is reset but takes page reload to reflect changes
  • Verified default base currency is reset when wallet is reset but takes page reload to reflect changes
  • Encountered #20966

Verification passed on

Brave 1.36.86 Chromium: 98.0.4758.87 (Official Build) beta (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS Windows 11 Version Dev (Build 22543.1000)
  • Verified test plan from issue description
  • Verified reset wallet reloads the existing wallet page
  • Verified reset removes all custom tokens added
  • Verified reset removes all custom networks that are added
  • Verified auto-lock is also reset when wallet is reset but takes page reload to reflect changes
  • Verified default base currency is reset when wallet is reset but takes page reload to reflect changes
  • Encountered #20966

Verification passed on

Brave 1.36.86 Chromium: 98.0.4758.87 (Official Build) beta (arm64)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS macOS Version 12.1 (Build 21C52)
  • Verified test plan from issue description
  • Verified reset wallet reloads the existing wallet page
  • Verified reset removes all custom tokens added
  • Verified reset removes all custom networks that are added
  • Verified auto-lock is also reset when wallet is reset but takes page reload to reflect changes
  • Verified default base currency is reset when wallet is reset but takes page reload to reflect changes
  • Encountered #20966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants