Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "region not supported" error modal during Rewards linking flow #21209

Closed
Miyayes opened this issue Feb 20, 2022 · 2 comments · Fixed by brave/brave-core#12832
Closed

Add "region not supported" error modal during Rewards linking flow #21209

Miyayes opened this issue Feb 20, 2022 · 2 comments · Fixed by brave/brave-core#12832
Assignees
@husobee @szilardszaloki
Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.38.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Feb 20, 2022 •
edited
Loading

Description

Add error modal during linking flow that lets the user know when verifying Rewards is not available for their region with the custodial service they've selected:

Solution

Text:

Error: Region not supported

Unfortunately, your Brave Rewards cannot be verified because your region is not supported for Brave Rewards verification at this time.

Related

See related: https://github.com/brave-intl/internal/issues/312
@Miyayes Miyayes added feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop labels Feb 20, 2022
@Miyayes Miyayes added the priority/P4 Planned work. We expect to get to it "soon". label Feb 22, 2022
@Miyayes Miyayes added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Mar 22, 2022
@szilardszaloki szilardszaloki mentioned this issue Mar 30, 2022
Merged
25 tasks
@szilardszaloki szilardszaloki added this to the 1.39.x - Nightly milestone Mar 31, 2022
@brave-builds brave-builds mentioned this issue Mar 31, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Apr 7, 2022

Above requires 1.38.85 or newer for 1.38.x verification.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 13, 2022 •
edited by LaurenWags
Loading

Verification PASSED on


Brave | 1.38.90 Chromium: 100.0.4896.79 (Official Build) beta (64-bit)
-- | --
Revision | 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS | Windows 10 Version 21H2 (Build 19044.1586)

Verified the unsupported region linkage error message for the wallet provider Gemini for the locale PH
image

Verified on Google Pixel 3 XL with Android 12 running 1.38.104

Screenshot_20220421-132412

@LaurenWags LaurenWags added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@husobee husobee

@szilardszaloki szilardszaloki

Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.38.x - Release
Development

Successfully merging a pull request may close this issue.

Implement unsupported regions in Rewards linking flow. brave/brave-core
6 participants
@kjozwiak @husobee @szilardszaloki @Miyayes @LaurenWags @GeetaSarvadnya