Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement unsupported regions in Rewards linking flow. #12832

Merged
merged 2 commits into from
Mar 31, 2022

Conversation

szilardszaloki
Copy link
Collaborator

Resolves brave/brave-browser#21209, resolves https://github.com/brave-intl/internal/issues/312.

region_not_supported

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

In https://github.com/brave-intl/internal/issues/312.

@szilardszaloki szilardszaloki requested a review from a team as a code owner March 30, 2022 12:35
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Mar 30, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@szilardszaloki
Copy link
Collaborator Author

SonarCloud is reporting duplicated lines due to how we currently structure code in rewards_reducer.ts and wallet_reducer.ts (both on desktop and Android).

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emerick
Copy link
Contributor

emerick commented Mar 31, 2022

Confirmed that the modal displays on Android as expected
Screenshot_20220331-093723
.

@szilardszaloki szilardszaloki added this to the 1.39.x - Nightly milestone Mar 31, 2022
@szilardszaloki szilardszaloki merged commit 90fe91a into master Mar 31, 2022
@szilardszaloki szilardszaloki deleted the sszaloki-21209-http-400-region-not-supported branch March 31, 2022 13:48
brave-builds pushed a commit that referenced this pull request Mar 31, 2022
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 6, 2022

@szilardszaloki @emerick Can any one of you link the test plan here, please? also could you also mention the list of countries which doesn't support external wallet linkage (e.g Uphold/Gemini/Bitflyer). I have tried testing the PR in the latest nightly build 1.39.35 I am not getting the unsupported region message when I link Gemini/Uphold KYC'd accounts. Verified the PH and VN locales. Not sure what I am missing

cc: @LaurenWags @kjozwiak @Miyayes

@szilardszaloki
Copy link
Collaborator Author

Hey @GeetaSarvadnya!
I added the test plan to https://github.com/brave-intl/internal/issues/312, but just checked and it seems it got removed.
Reaching out via Slack!

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.39.35 Chromium: 100.0.4896.79 (Official Build) nightly (64-bit)
-- | --
Revision | 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS | Windows 10 Version 21H2 (Build 19044.1586)

  • Verified the unsupported region linkage error message for the wallet provider Gemini for the locale PH (Note: I had a discussion with @szilardszaloki, as per the discussion we have an account set up only for PH locale for Gemini provider, hence verified the PR only for Gemini wallet provider and PH locale)
    image

@GeetaSarvadnya
Copy link

Verification PASSED on Samsung Galaxy Tab A7 version 11 running Bravemonoarmx64.apk_1.39.35

Verified the unsupported region linkage error message for the wallet provider Gemini for the locale PH
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "region not supported" error modal during Rewards linking flow
5 participants