-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for VPN on Beta #21598
Labels
Milestone
Comments
This was referenced Mar 12, 2022
petemill
pushed a commit
to brave/brave-core
that referenced
this issue
Mar 16, 2022
Made skus sdk enabled by default and vpn feature available on beta. Fixes brave/brave-browser#21598
bsclifton
pushed a commit
to brave/brave-core
that referenced
this issue
Mar 23, 2022
Made skus sdk enabled by default and vpn feature available on beta. Fixes brave/brave-browser#21598
simonhong
added a commit
to brave/brave-core
that referenced
this issue
Mar 28, 2022
Made skus sdk enabled by default and vpn feature available on beta. Fixes brave/brave-browser#21598
bsclifton
pushed a commit
to brave/brave-core
that referenced
this issue
Apr 1, 2022
Made skus sdk enabled by default and vpn feature available on beta. Fixes brave/brave-browser#21598
bsclifton
pushed a commit
to brave/brave-core
that referenced
this issue
Apr 4, 2022
Made skus sdk enabled by default and vpn feature available on beta. Fixes brave/brave-browser#21598
bsclifton
pushed a commit
to brave/brave-core
that referenced
this issue
Apr 6, 2022
Made skus sdk enabled by default and vpn feature available on beta. Fixes brave/brave-browser#21598
bsclifton
pushed a commit
to brave/brave-core
that referenced
this issue
Apr 9, 2022
Made skus sdk enabled by default and vpn feature available on beta. Fixes brave/brave-browser#21598
simonhong
added a commit
to brave/brave-core
that referenced
this issue
Apr 11, 2022
Made skus sdk enabled by default and vpn feature available on beta. Fixes brave/brave-browser#21598
Verified
|
Brave | 1.39.84 Chromium: 101.0.4951.41 (Official Build) beta (x86_64) |
---|---|
Revision | 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904} |
OS | macOS Version 11.6.5 (Build 20G527) |
Followed the testplan at #21598 (comment).
Confirmed, from the testplan:
- VPN functionality is tied to the Nightly channel at the moment (via build flag). We should expose this feature on brave://flags/#brave-vpn for Beta also.
All three flags are available:
brave://flags/#brave-vpn
brave://flags/#skus-environment
brave://flags/#skus-sdk
SKUs |
VPN |
---|---|
![]() |
![]() |
- VPN for Desktop is also requiring that SKU SDK (brave://flags/#skus-sdk) is enabled. We should enable the SKU SDK feature by default
Confirmed via entering window.chrome.brave
into the Developer Tools
Console
yielded window.chrome.braveSkus
, without enabling brave://flags/#skus-sdk
(left as Default
as seen in screenshot).
Steps:
- install
1.39.84
- launch Brave using
--vmodule="*/skus/*"=1 --enable-logging=stderr
- set
Enable Experimental Brave VPN
toEnabled
- set
Experimental SKU Environment
toDevelopment
- click
Relaunch
- load
account.brave.software
- enter basic auth creds for site
- enter an email address and click
Get login link
- check your email inbox
- click
Log in to Brave
or the link in the email - click on
Browse plans
- scroll down and click on
Buy now
forBrave VPN Subscription
- enter payment details on
https://checkout.stripe.com/pay/cs_test…
- click
Subscribe
- you should get a
Complete your purchase...
screen - click on
Complete payment
Confirmed I could successfully (and automatically) connect to VPN via the icon and its toggle, in the URL bar.
example | example | example | example | example |
---|---|---|---|---|
![]() |
![]() |
![]() |
. | ![]() |
Verification PASSED on
Followed the testplan at #21598 (comment). Steps:
Confirmed I could successfully (and automatically) connect to VPN via the icon and its toggle, in the URL bar.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Test plan
Description
Changes needed so that VPN can move from Nightly to Beta with 1.39 😄
VPN functionality is tied to the Nightly channel at the moment (via build flag). We should expose this feature on brave://flags/#brave-vpn for Beta also.
VPN for Desktop is also requiring that SKU SDK (brave://flags/#skus-sdk) is enabled. We should enable the SKU SDK feature by default
The text was updated successfully, but these errors were encountered: