Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave News settings bar slightly cut off at the top when scrolling news feed [Android Tablet] #21737

Closed
Uni-verse opened this issue Mar 17, 2022 · 3 comments · Fixed by brave/brave-core#13951

Comments

@Uni-verse
Copy link
Contributor

Uni-verse commented Mar 17, 2022

Test plan

See brave/brave-core#13951

Description

Brave News settings bar slightly cut off at the top end

Steps to reproduce

  1. Clean Install
  2. Enable Brave News, enable show brave news
  3. Relaunch browser (because of Brave news settings bar missing when scrolling news after enabling Brave News #21725)
  4. May have to opt-in again on the homepage after relaunch (issue will be logged)
  5. Scroll News feed
  6. Observe news settings bar

Actual result

It looks like 'Brave News' and the Settings Icon/Legend are not vertically aligned within the bar, but i believe the settings bar is slight cut off.

Not Observed on Android mobile

Actual Result Expected
Screen Shot 2022-03-17 at 1 15 13 PM Screen Shot 2022-03-17 at 1 24 49 PM

Expected result

Settings bar not cut off, equal amount of padding between top and bottom of the elements

Issue reproduces how often

Easily

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung Galaxy Tab S7
  • Android version: 11

Brave version

1.36.112, Chromium 99.0.4844.51 (GPS Release)
Beta 1.37.x
Nightly 1.38.x

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

Not observed on Samsung mobile devices on any channel

@Uni-verse Uni-verse added bug QA/Yes OS/Android Fixes related to Android browser functionality android-tablet-specific feature/brave-news formerly brave-today labels Mar 17, 2022
@deeppandya deeppandya self-assigned this Mar 28, 2022
@deeppandya
Copy link
Contributor

This issue should be resolved with NTP refactoring. @tapanmodh would you please verify ?

@tapanmodh
Copy link

Yes, this issue will be resolved with NTP refactoring.

@Uni-verse
Copy link
Contributor Author

Verified on Samsung Galaxy Tab S7 using

Brave	1.43.74 Chromium: 104.0.5112.102 (Official Build) beta (64-bit) 
Revision	8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS	Android 12; Build/SP1A.210812.016
  • Confirmed the news settings icon is vertically aligned inside the toolbar
  • Confirmed user is able to open the settings via the news setting toolbar
Pre 1.43 1.43 1.43 (Landscape)
Screen Shot 2022-03-17 at 1 15 13 PM screenshot-1660857625016 screenshot-1660857643824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants