Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave news settings bar missing when scrolling news after enabling Brave News #21725

Closed
Uni-verse opened this issue Mar 17, 2022 · 4 comments · Fixed by brave/brave-core#12817

Comments

@Uni-verse
Copy link
Contributor

Description

After enabling Brave News in the settings menu, the brave news menu bar is missing when scrolling through news.

Note: Relaunching Brave app will restore the Brave news settings bar

Steps to reproduce

  1. Clean install
  2. Navigate to menu > Brave News > Enable Brave News
  3. Enable Show Brave News
  4. Go back to homepage
  5. Scroll through Brave News

Actual result

Missing news settings bar

brave_news01.mp4

Expected result

Show news settings bar

Issue reproduces how often

Easily, 100% repro rate

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung Galaxy S21
  • Android version: Android 12

Brave version

Nightly 1.38.49, Chromium 99.04844.74

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@Uni-verse Uni-verse added bug QA/Yes OS/Android Fixes related to Android browser functionality feature/brave-news formerly brave-today labels Mar 17, 2022
@Uni-verse Uni-verse changed the title Brave news settings bar missing after enabling Brave News Brave news settings bar missing when scrolling news after enabling Brave News Mar 17, 2022
@timchilds
Copy link

@Uni-verse I cannot reproduce this issue on my device (Samsung Galaxy A51 / Android 11).

cc @anthonypkeane @bsclifton

@kjozwiak
Copy link
Member

kjozwiak commented Apr 8, 2022

@tapanmodh technically this should still be in the 1.39.x milestone as the original PR landed in 1.39.x and this wasn't uplifted yet. Once brave/brave-core#12931 is merged into 1.38.x, the release team will move the issue into the correct milestone, in this case, 1.38.x. You can view/read the process via https://github.com/brave/brave-browser/wiki/Triage-Guidelines#uplifting.

@kjozwiak
Copy link
Member

kjozwiak commented Apr 8, 2022

brave/brave-core#12817 was verified on Nightly as per brave/brave-core#12817 (comment) and uplifted via brave/brave-core#12931.

Above requires 1.38.86 or higher for 1.38.x verification.

@Uni-verse
Copy link
Contributor Author

Uni-verse commented Apr 19, 2022

Verified using 1.38.99, Chromium 100.0.4896.127

Devices:
Samsung Galaxy S21 | Android 12
Samsung Galaxy Tab S7 | Android 12

  • Verified brave news settings bar is present when scrolling news after enabling Brave News from settings
  • Verified brave setting bar is functional
21725_2.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants