Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedreader inconsistancies #22106

Closed
MadhaviSeelam opened this issue Apr 5, 2022 · 2 comments
Closed

Speedreader inconsistancies #22106

MadhaviSeelam opened this issue Apr 5, 2022 · 2 comments

Comments

@MadhaviSeelam
Copy link

Description

Scenario 1: If the Speedreader was toggled off in the reader mode icon, Speedreader was not disabled in the global settings

Steps to Reproduce

  1. Install 1.38.80
  2. Launch Brave
  3. Disabled Speedreader in brave://settings/Appearance
  4. Visit https://brave.com/blog
  5. Reader-mode icon is visible
  6. Clicked to Turn on Speedreader
  7. Verified Speedreader is enabled in the brave://settings/Appearance
  8. Toggle Speedreader off in reader-mode icon

Actual result:

Speedreader in brave://settings/Appearance is still enabled

scenario.1.mp4

Expected result:

Speedreaderin brave://settings/Appearance should be disabled

Scenario 2: When clicked on Reader-mode icon, window doesn't display after it was dismissed couple of times without `Turning on Speedreader`
  1. Install 1.38.80
  2. Launch Brave
  3. Disabled Speedreader in brave://settings/Appearance
  4. Visit https://brave.com/blog
  5. Reader-mode icon is visible
  6. Click on the Reader-mode icon but do not Turn on Speedreader
  7. Click away to close the Reader-mode window
  8. Click reader-mode icon two more times.
  9. After third time, reader-mode window is not displayed
  10. Visit Washingtonpost.com and open an article in another tab
  11. Click the reader-mode icon.
  12. It appears the page is on Speedreader mode without the visible Speedreader icon

Actual result:

Reader-mode window is not available to Turn on Speedreader.

Scenario.2.mp4

Expected result:

Reader mode window should be available to Turn on Speedreader.

Reproduces how often: Easy

Brave version (brave://version info)

Brave 1.38.80 Chromium: 100.0.4896.79 (Official Build) beta (64-bit)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS Windows 11 Version 21H2 (Build 22000.593)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@iefremov
Copy link
Contributor

Should be fixed with brave/brave-core#12678
@MadhaviSeelam can you please check?

@MadhaviSeelam
Copy link
Author

Closing this issue as it's working as expected. Verified in 1.39.111 & 1.40.83 Beta
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants