Speedreader #12678
Merged
Speedreader #12678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supermassive
approved these changes
Mar 22, 2022
37 tasks
iefremov
reviewed
Mar 22, 2022
| @@ -51,6 +51,7 @@ class DeAmpURLLoader : public body_sniffer::BodySnifferURLLoader { | |||
| void ForwardBodyToClient(); | |||
|
|
|||
| base::WeakPtr<DeAmpThrottle> de_amp_throttle_; | |||
| base::WeakPtrFactory<DeAmpURLLoader> weak_factory_{this}; | |||
iefremov
reviewed
Mar 22, 2022
| // Page can't be distilled. | ||
| bool PageDoesntSupportDistillation(DistillState state); | ||
|
|
||
| // Page can be destilled. |
iefremov
reviewed
Mar 22, 2022
| @@ -58,6 +58,12 @@ enum class DistillState { | |||
| // Page is in reader mode or speedreader mode. | |||
| bool PageStateIsDistilled(DistillState state); | |||
|
|
|||
| // Page can't be distilled. | |||
| bool PageDoesntSupportDistillation(DistillState state); | |||
There was a problem hiding this comment.
it's not really clear what method of these two to use and when. It sounds like ! PageSupportsDistillation() is the same as PageDoesn'tSupportDistillation() but from the code this is not true. Can we switch to a single method or pick better names?
iefremov
reviewed
Mar 22, 2022
| // content::WebContentsObserver | ||
| void ClearCache(); | ||
| void ReloadContents(); | ||
| void ProcessNavigation(content::NavigationHandle* navigation_handle); |
iefremov
reviewed
Mar 22, 2022
|
|
||
| // SpeedreaderResultDelegate: | ||
| void OnDistillComplete() override; | ||
|
|
||
| std::unique_ptr<PrefChangeRegistrar> pref_change_registrar_; | ||
|
|
||
| bool is_active_ = false; |
iefremov
reviewed
Mar 22, 2022
| void SpeedreaderTabHelper::HideBubble() { | ||
| if (speedreader_bubble_) { | ||
| speedreader_bubble_->Hide(); | ||
| speedreader_bubble_ = nullptr; | ||
| } | ||
| } | ||
|
|
||
| void SpeedreaderTabHelper::ClearCache() { |
iefremov
reviewed
Mar 22, 2022
| Profile::FromBrowserContext(web_contents()->GetBrowserContext()); | ||
| auto* content_rules = HostContentSettingsMapFactory::GetForProfile(profile); | ||
| return speedreader::IsEnabledForSite(content_rules, url); | ||
| void SpeedreaderTabHelper::Distill() { |
There was a problem hiding this comment.
this is not Distill, rather UpdateDistillationState()?
iefremov
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#18242,
Resolves brave/brave-browser#18234,
Resolves brave/brave-browser#18243
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: