Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement error modal if user does not have receives OR sends capabilities on Uphold #22508

Closed
Miyayes opened this issue Apr 22, 2022 · 4 comments · Fixed by brave/brave-core#13474
Closed

Implement error modal if user does not have receives OR sends capabilities on Uphold #22508

Miyayes opened this issue Apr 22, 2022 · 4 comments · Fixed by brave/brave-core#13474
Assignees
@szilardszaloki
Labels
feature/rewards/Uphold feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Milestone
1.40.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Apr 22, 2022 •
edited by szilardszaloki
Loading

Description

If Uphold capabilities shows that user does not have receives || sends capabilities on Uphold, then

  1. Make sure user does not enter verified Rewards wallet state in the browser
  2. Insert check in part of flow that will preclude linking on backend
  3. State migration or continual checks for existing Uphold-verified users that calls explicit disconnect
@Miyayes Miyayes added feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. OS/Android Fixes related to Android browser functionality OS/Desktop feature/rewards/Uphold labels Apr 22, 2022
@szilardszaloki szilardszaloki changed the title Implement error modal if user does not have receive OR send capabilities on Uphold Implement error modal if user does not have receives OR sends capabilities on Uphold May 23, 2022
@szilardszaloki szilardszaloki mentioned this issue May 25, 2022
Merged
25 tasks
@szilardszaloki szilardszaloki added this to the 1.41.x - Nightly milestone May 26, 2022
This was referenced May 27, 2022
Merged
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Jun 2, 2022

The above will require 1.40.85 or higher for 1.40.x verification 👍

@LaurenWags
Copy link
Member

LaurenWags commented Jun 6, 2022 •
edited by btlechowski
Loading

Verified with

Brave | 1.40.86 Chromium: 102.0.5005.78 (Official Build) beta (x86_64)
-- | --
Revision | df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS | macOS Version 12.4 (Build 21F79)

Encountered #23257 while testing.

Verified test plan from brave/brave-core#13474 (comment) for the following:

Case 1: Clean profile, "sends" capability is false - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "sends" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "sends",
	"name": "Sends",
	"requirements": [],
	"restrictions": []
  1. Using clean profile, launch 1.40.x w/ staging env and Charles running w/ the rewrite rule in place.
  2. Enable Rewards
  3. Login using Uphold account
  4. Confirm rewrite rule is used using Charles
  5. Confirm you see the below in your logs
[36948:259:0606/081154.132466:INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!
  1. Confirm the expected modal shows on the brave://rewards page
1
Case 2: Upgrade profile, "sends" capability is false, brave://rewards page is open and active after upgrade - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "sends" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "sends",
	"name": "Sends",
	"requirements": [],
	"restrictions": []
  1. Using clean profile, launch 1.39.x w/ staging env and Charles running w/ the rewrite rule in place.
  2. Enable Rewards
  3. Login using Uphold account, confirm account is linked as expected (you see balance, etc) - note, this is expected as 1.39.x does not use the "capabilities" endpoint
  4. Keep brave://rewards page as the open/active tab. Close 1.39.x
  5. Rename profile to "Brave-Browser-Beta"
  6. Launch 1.40.x w/ staging
  7. Confirm rewrite rule is used using Charles
  8. Confirm you see the below in your logs
[37522:259:0606/084213.774499:INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!
  1. Confirm the expected modal shows on the brave://rewards page
  2. Confirm after you close the modal you are logged out of Uphold in UI and your balance is not displayed.
1.39.x 1.40.x 1.40.x
A B C
  1. Confirm the "Logged out" notification is displayed on the BAT logo:
D
Case 3: Upgrade profile, "sends" capability is false, brave://rewards page is not open after upgrade - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "sends" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "sends",
	"name": "Sends",
	"requirements": [],
	"restrictions": []
  1. Using clean profile, launch 1.39.x w/ staging env and Charles running w/ the rewrite rule in place.
  2. Enable Rewards
  3. Login using Uphold account, confirm account is linked as expected (you see balance, etc) - note, this is expected as 1.39.x does not use the "capabilities" endpoint
  4. Close any brave://rewards page and have some other tab as the open/active tab. Close 1.39.x.
  5. Rename profile to "Brave-Browser-Beta"
  6. Launch 1.40.x w/ staging
  7. Open panel
  8. Confirm rewrite rule is used using Charles
  9. Confirm you see the below in your logs
[37701:259:0606/084638.701245:INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!
  1. Confirm the panel shows you are logged out of Uphold notification in UI and your balance is not displayed.
1.39.x 1.40.x 1.40.x
A B C
Case 4: Clean profile, "receives" capability is false - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "receives" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "receives",
	"name": "Receives",
	"requirements": [],
	"restrictions": []
  1. Using clean profile, launch 1.40.x w/ staging env and Charles running w/ the rewrite rule in place.
  2. Enable Rewards
  3. Login using Uphold account
  4. Confirm rewrite rule is used using Charles
  5. Confirm you see the below in your logs
[39513:259:0606/105100.997494:INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!
  1. Confirm the expected modal shows on the brave://rewards page
Screen Shot 2022-06-06 at 10 51 32 AM
Case 5: Upgrade profile, "receives" capability is false, brave://rewards page is open and active after upgrade - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "receives" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "receives",
	"name": "Receives",
	"requirements": [],
	"restrictions": []
  1. Using clean profile, launch 1.39.x w/ staging env and Charles running w/ the rewrite rule in place.
  2. Enable Rewards
  3. Login using Uphold account, confirm account is linked as expected (you see balance, etc) - note, this is expected as 1.39.x does not use the "capabilities" endpoint
  4. Keep brave://rewards page as the open/active tab. Close 1.39.x
  5. Rename profile to "Brave-Browser-Beta"
  6. Launch 1.40.x w/ staging
  7. Confirm rewrite rule is used using Charles
  8. Confirm you see the below in your logs
[40276:259:0606/113339.133544:INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!
  1. Confirm the expected modal shows on the brave://rewards page
  2. Confirm after you close the modal you are logged out of Uphold in UI and your balance is not displayed.
1.39.x 1.40.x 1.40.x
1 2 3
  1. Confirm the "Logged out" notification is displayed on the BAT logo:
4
Case 6: Upgrade profile, "receives" capability is false, brave://rewards page is not open after upgrade - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "receives " part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "receives",
	"name": "Receives",
	"requirements": [],
	"restrictions": []
  1. Using clean profile, launch 1.39.x w/ staging env and Charles running w/ the rewrite rule in place.
  2. Enable Rewards
  3. Login using Uphold account, confirm account is linked as expected (you see balance, etc) - note, this is expected as 1.39.x does not use the "capabilities" endpoint
  4. Close any brave://rewards page and have some other tab as the open/active tab. Close 1.39.x.
  5. Rename profile to "Brave-Browser-Beta"
  6. Launch 1.40.x w/ staging
  7. Open panel
  8. Confirm rewrite rule is used using Charles
  9. Confirm you see the below in your logs
[40427:259:0606/113647.472016:INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!
  1. Confirm the panel shows you are logged out of Uphold notification in UI and your balance is not displayed.
1.39.x 1.40.x 1.40.x
1 2 3

Also verified the following cases for an account in good standing/full capabilities:

Case 7: Clean profile, both "sends" and "receives" are true - PASSED
  1. Confirm you've disabled all rewrite rules or have stopped running Charles
  2. Using clean profile, launch 1.40.x w/ staging env
  3. Enable Rewards
  4. Login using Uphold account in good standing
  5. Confirm able to link uphold account to Brave Rewards without any errors
  6. Confirm "sends" and "receives" both have enabled = true
{"category":"permissions","enabled":true,"key":"receives","name":"Receives","requirements":[],"restrictions":[]},
{"category":"permissions","enabled":true,"key":"sends","name":"Sends","requirements":[],"restrictions":[]},
  1. Confirm balance displays in rewards as you would expect
Example Example
Screen Shot 2022-06-06 at 2 58 18 PM Screen Shot 2022-06-06 at 2 58 26 PM
Case 8: Upgrade profile, "sends" and "receives" are true, brave://rewards page is open and active after upgrade - PASSED
  1. Confirm you've disabled all rewrite rules or have stopped running Charles
  2. Using clean profile, launch 1.39.x w/ staging env
  3. Enable Rewards
  4. Login using Uphold account, confirm account is linked as expected (you see balance, etc)
  5. Keep brave://rewards page as the open/active tab. Close 1.39.x
  6. Rename profile to "Brave-Browser-Beta"
  7. Launch 1.40.x w/ staging
  8. Confirm "sends" and "receives" both have enabled = true
{"category":"permissions","enabled":true,"key":"receives","name":"Receives","requirements":[],"restrictions":[]},
{"category":"permissions","enabled":true,"key":"sends","name":"Sends","requirements":[],"restrictions":[]},
  1. Confirm you are still logged in to Uphold with Brave Rewards
  2. Confirm balance displays in rewards as you would expect
1.39.x 1.40.x
Screen Shot 2022-06-06 at 3 08 04 PM Screen Shot 2022-06-06 at 3 08 41 PM
Case 9: Upgrade profile, "sends" and "receives" are true, brave://rewards page is not open after upgrade - PASSED
  1. Confirm you've disabled all rewrite rules or have stopped running Charles
  2. Using clean profile, launch 1.39.x w/ staging env
  3. Enable Rewards
  4. Login using Uphold account, confirm account is linked as expected (you see balance, etc)
  5. Close any brave://rewards pages and have another tab as the open/active tab. Close 1.39.x
  6. Rename profile to "Brave-Browser-Beta"
  7. Launch 1.40.x w/ staging
  8. Confirm "sends" and "receives" both have enabled = true
{"category":"permissions","enabled":true,"key":"receives","name":"Receives","requirements":[],"restrictions":[]},
{"category":"permissions","enabled":true,"key":"sends","name":"Sends","requirements":[],"restrictions":[]},
  1. Confirm you are still logged in to Uphold with Brave Rewards
  2. Confirm balance displays in rewards as you would expect
1.39.x 1.40.x
Screen Shot 2022-06-06 at 3 10 34 PM Screen Shot 2022-06-06 at 3 11 03 PM

Verification PASSED on

Brave | 1.40.86 Chromium: 102.0.5005.78 (Official Build) beta (64-bit)
-- | --
Revision | df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS | Windows 10 Version 21H2 (Build 19044.1706)
Case 1: Clean profile, "sends" capability is false - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "sends" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "sends",
	"name": "Sends",
	"requirements": [],
	"restrictions": []
  1. Using clean profile, launch 1.40.x w/ staging env and Charles running w/ the rewrite rule in place.
  2. Enable Rewards
  3. Login using Uphold account
  4. Confirm rewrite rule is used using Charles
  5. Confirm you see the below in your logs
[7412:2164:0607/130957.817:INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!
  1. Confirm the expected modal shows on the brave://rewards page

image

Case 2: Upgrade profile, "sends" capability is false, brave://rewards page is open and active after upgrade - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "sends" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "sends",
	"name": "Sends",
	"requirements": [],
	"restrictions": []
  1. Using clean profile, launch 1.39.x w/ staging env and Charles running w/ the rewrite rule in place.
  2. Enable Rewards
  3. Login using Uphold account, confirm account is linked as expected (you see balance, etc) - note, this is expected as 1.39.x does not use the "capabilities" endpoint
  4. Keep brave://rewards page as the open/active tab. Close 1.39.x
  5. Rename profile to "Brave-Browser-Beta"
  6. Launch 1.40.x w/ staging
  7. Confirm rewrite rule is used using Charles
  8. Confirm you see the below in your logs
[14404:2948:0607/132511.490:INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!
  1. Confirm the expected modal shows on the brave://rewards page
  2. Confirm after you close the modal you are logged out of Uphold in UI and your balance is not displayed.
1.39.x 1.40.x 1.40.x
image image image
  1. Confirm the "Logged out" notification is displayed on the BAT logo:
    image
Case 3: Upgrade profile, "sends" capability is false, brave://rewards page is not open after upgrade - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "sends" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "sends",
	"name": "Sends",
	"requirements": [],
	"restrictions": []
  1. Using clean profile, launch 1.39.x w/ staging env and Charles running w/ the rewrite rule in place.
  2. Enable Rewards
  3. Login using Uphold account, confirm account is linked as expected (you see balance, etc) - note, this is expected as 1.39.x does not use the "capabilities" endpoint
  4. Close any brave://rewards page and have some other tab as the open/active tab. Close 1.39.x.
  5. Rename profile to "Brave-Browser-Beta"
  6. Launch 1.40.x w/ staging
  7. Open panel
  8. Confirm rewrite rule is used using Charles
  9. Confirm you see the below in your logs
[3544:1004:0607/133623.753:INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!
  1. Confirm the panel shows you are logged out of Uphold notification in UI and your balance is not displayed.
1.39.x 1.40.x 1.40.x
image image image
Case 4: Clean profile, "receives" capability is false - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "receives" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "receives",
	"name": "Receives",
	"requirements": [],
	"restrictions": []
  1. Using clean profile, launch 1.40.x w/ staging env and Charles running w/ the rewrite rule in place.
  2. Enable Rewards
  3. Login using Uphold account
  4. Confirm rewrite rule is used using Charles
  5. Confirm you see the below in your logs
[22520:14528:0607/151428.884:INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!
  1. Confirm the expected modal shows on the brave://rewards page
    image
Case 5: Upgrade profile, "receives" capability is false, brave://rewards page is open and active after upgrade - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "receives" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "receives",
	"name": "Receives",
	"requirements": [],
	"restrictions": []
  1. Using clean profile, launch 1.39.x w/ staging env and Charles running w/ the rewrite rule in place.
  2. Enable Rewards
  3. Login using Uphold account, confirm account is linked as expected (you see balance, etc) - note, this is expected as 1.39.x does not use the "capabilities" endpoint
  4. Keep brave://rewards page as the open/active tab. Close 1.39.x
  5. Rename profile to "Brave-Browser-Beta"
  6. Launch 1.40.x w/ staging
  7. Confirm rewrite rule is used using Charles
  8. Confirm you see the below in your logs
[13584:9352:0607/152543.978:INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!
  1. Confirm the expected modal shows on the brave://rewards page
  2. Confirm after you close the modal you are logged out of Uphold in UI and your balance is not displayed.
1.39.x 1.40.x 1.40.x
image image image
  1. Confirm the "Logged out" notification is displayed on the BAT logo:
    image
Case 6: Upgrade profile, "receives" capability is false, brave://rewards page is not open after upgrade - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "receives " part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "receives",
	"name": "Receives",
	"requirements": [],
	"restrictions": []
  1. Using clean profile, launch 1.39.x w/ staging env and Charles running w/ the rewrite rule in place.
  2. Enable Rewards
  3. Login using Uphold account, confirm account is linked as expected (you see balance, etc) - note, this is expected as 1.39.x does not use the "capabilities" endpoint
  4. Close any brave://rewards page and have some other tab as the open/active tab. Close 1.39.x.
  5. Rename profile to "Brave-Browser-Beta"
  6. Launch 1.40.x w/ staging
  7. Open panel
  8. Confirm rewrite rule is used using Charles
  9. Confirm you see the below in your logs
[14712:22268:0607/153423.994:INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!
  1. Confirm the panel shows you are logged out of Uphold notification in UI and your balance is not displayed.
1.39.x 1.40.x 1.40.x
image image image
Case 7: Clean profile, both "sends" and "receives" are true - PASSED
  1. Confirm you've disabled all rewrite rules or have stopped running Charles
  2. Using clean profile, launch 1.40.x w/ staging env
  3. Enable Rewards
  4. Login using Uphold account in good standing
  5. Confirm able to link uphold account to Brave Rewards without any errors
  6. Confirm "sends" and "receives" both have enabled = true
{"category":"permissions","enabled":true,"key":"receives","name":"Receives","requirements":[],"restrictions":[]},
{"category":"permissions","enabled":true,"key":"sends","name":"Sends","requirements":[],"restrictions":[]},
  1. Confirm balance displays in rewards as you would expect
Example Example
image image
Case 8: Upgrade profile, "sends" and "receives" are true, brave://rewards page is open and active after upgrade - PASSED
  1. Confirm you've disabled all rewrite rules or have stopped running Charles
  2. Using clean profile, launch 1.39.x w/ staging env
  3. Enable Rewards
  4. Login using Uphold account, confirm account is linked as expected (you see balance, etc)
  5. Keep brave://rewards page as the open/active tab. Close 1.39.x
  6. Rename profile to "Brave-Browser-Beta"
  7. Launch 1.40.x w/ staging
  8. Confirm "sends" and "receives" both have enabled = true
{"category":"permissions","enabled":true,"key":"receives","name":"Receives","requirements":[],"restrictions":[]},{"category":"permissions","enabled":true,"key":"sends","name":"Sends","requirements":[],"restrictions":[]},
  1. Confirm you are still logged in to Uphold with Brave Rewards
  2. Confirm balance displays in rewards as you would expect
1.39.x 1.40.x
image image
Case 9: Upgrade profile, "sends" and "receives" are true, brave://rewards page is not open after upgrade - PASSED
  1. Confirm you've disabled all rewrite rules or have stopped running Charles
  2. Using clean profile, launch 1.39.x w/ staging env
  3. Enable Rewards
  4. Login using Uphold account, confirm account is linked as expected (you see balance, etc)
  5. Close any brave://rewards pages and have another tab as the open/active tab. Close 1.39.x
  6. Rename profile to "Brave-Browser-Beta"
  7. Launch 1.40.x w/ staging
  8. Confirm "sends" and "receives" both have enabled = true
{"category":"permissions","enabled":true,"key":"receives","name":"Receives","requirements":[],"restrictions":[]},{"category":"permissions","enabled":true,"key":"sends","name":"Sends","requirements":[],"restrictions":[]},
  1. Confirm you are still logged in to Uphold with Brave Rewards
  2. Confirm balance displays in rewards as you would expect
1.39.x 1.40.x
image image

Verification passed on

Brave 1.40.94 Chromium: 102.0.5005.115 (Official Build) beta (64-bit
Revision 174dbe6e33bc81994fceb71d751be201d0b4803d-refs/branch-heads/5005_109@{#3}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#13474 (comment) for the following:

Case 1: Clean profile, "sends" capability is false - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "sends" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "sends",
	"name": "Sends",
	"requirements": [],
	"restrictions": []
  1. Using clean profile, launch 1.40.x w/ staging env and Charles running w/ the rewrite rule in place.
  2. Enable Rewards
  3. Login using Uphold account
  4. Confirm rewrite rule is used using Charles
  5. Confirm you see the below in your logs
[36948:259:0606/081154.132466:INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!
  1. Confirm the expected modal shows on the brave://rewards page

image

Case 2: Upgrade profile, "sends" capability is false, brave://rewards page is open and active after upgrade - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "sends" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "sends",
	"name": "Sends",
	"requirements": [],
	"restrictions": []
  1. Using clean profile, launch 1.39.x w/ staging env and Charles running w/ the rewrite rule in place.
  2. Enable Rewards
  3. Login using Uphold account, confirm account is linked as expected (you see balance, etc) - note, this is expected as 1.39.x does not use the "capabilities" endpoint

image

  1. Keep brave://rewards page as the open/active tab. Close 1.39.x
  2. Rename profile to "Brave-Browser-Beta"
  3. Launch 1.40.x w/ staging
  4. Confirm rewrite rule is used using Charles
  5. Confirm you see the below in your logs
[37522:259:0606/084213.774499:INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!
  1. Confirm the expected modal shows on the brave://rewards page
  2. Confirm after you close the modal you are logged out of Uphold in UI and your balance is not displayed.

image

  1. Confirm the "Logged out" notification is displayed on the BAT logo:

image

Case 3: Upgrade profile, "sends" capability is false, brave://rewards page is not open after upgrade - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "sends" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "sends",
	"name": "Sends",
	"requirements": [],
	"restrictions": []

  1. Using clean profile, launch 1.39.x w/ staging env and Charles running w/ the rewrite rule in place.

  2. Enable Rewards

  3. Login using Uphold account, confirm account is linked as expected (you see balance, etc) - note, this is expected as 1.39.x does not use the "capabilities" endpoint

  4. Close any brave://rewards page and have some other tab as the open/active tab. Close 1.39.x.
    image

  5. Rename profile to "Brave-Browser-Beta"

  6. Launch 1.40.x w/ staging

  7. Open panel

  8. Confirm rewrite rule is used using Charles

  9. Confirm you see the below in your logs

[37701:259:0606/084638.701245:INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!
  1. Confirm the panel shows you are logged out of Uphold notification in UI and your balance is not displayed.

image

Case 7: Clean profile, both "sends" and "receives" are true - PASSED
  1. Confirm you've disabled all rewrite rules or have stopped running Charles
  2. Using clean profile, launch 1.40.x w/ staging env
  3. Enable Rewards
  4. Login using Uphold account in good standing
  5. Confirm able to link uphold account to Brave Rewards without any errors
  6. Confirm "sends" and "receives" both have enabled = true
{"category":"permissions","enabled":true,"key":"receives","name":"Receives","requirements":[],"restrictions":[]},
{"category":"permissions","enabled":true,"key":"sends","name":"Sends","requirements":[],"restrictions":[]},
  1. Confirm balance displays in rewards as you would expect

image

Case 9: Upgrade profile, "sends" and "receives" are true, brave://rewards page is not open after upgrade - PASSED
  1. Confirm you've disabled all rewrite rules or have stopped running Charles
  2. Using clean profile, launch 1.39.x w/ staging env
  3. Enable Rewards
  4. Login using Uphold account, confirm account is linked as expected (you see balance, etc)
  5. Close any brave://rewards pages and have another tab as the open/active tab. Close 1.39.x

image

  1. Rename profile to "Brave-Browser-Beta"
  2. Launch 1.40.x w/ staging
  3. Confirm "sends" and "receives" both have enabled = true
{"category":"permissions","enabled":true,"key":"receives","name":"Receives","requirements":[],"restrictions":[]},
{"category":"permissions","enabled":true,"key":"sends","name":"Sends","requirements":[],"restrictions":[]},
  1. Confirm you are still logged in to Uphold with Brave Rewards
  2. Confirm balance displays in rewards as you would expect

image

@LaurenWags LaurenWags mentioned this issue Jun 6, 2022
Closed
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 15, 2022 •
edited
Loading

Verification PASSED on Samsung Galaxy Tab A7 version 11 running Bravemonoarmx64.apk_1.40.99

Case 1: Clean profile, "sends" capability is false - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "sends" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "sends",
	"name": "Sends",
	"requirements": [],
	"restrictions": []
  1. Using clean profile, launch 1.40.x w/ staging env and Charles running w/ the rewrite rule in place.
  2. Enable Rewards
  3. Login using Uphold account
  4. Confirm rewrite rule is used using Charles
  5. Confirm you see the below in your logs
2022-06-16 20:15:59.489 19757-19757/? I/chromium: [INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!
2022-06-16 20:15:59.492 19757-19757/? V/chromium: [VERBOSE1:uphold.cc(186)] Disconnecting wallet
  1. Confirm the expected modal shows on the brave://rewards page
    image
Case 2: Upgrade profile, "sends" capability is false, brave://rewards page is open and active after upgrade - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "sends" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "sends",
	"name": "Sends",
	"requirements": [],
	"restrictions": []
  1. Using clean profile, launch 1.39.x w/ staging env and Charles running w/ the rewrite rule in place.
  2. Enable Rewards
  3. Login using Uphold account, confirm account is linked as expected (you see balance, etc) - note, this is expected as 1.39.x does not use the "capabilities" endpoint
  4. Keep brave://rewards page as the open/active tab. Close 1.39.x
  5. Rename profile to "Brave-Browser-Beta"
  6. Launch 1.40.x w/ staging
  7. Confirm rewrite rule is used using Charles
  8. Confirm you see the below in your logs
2022-06-16 20:46:07.748 31521-31521/? I/chromium: [INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!
  1. Confirm the expected modal shows on the brave://rewards page
  2. Confirm after you close the modal you are logged out of Uphold in UI and your balance is not displayed.
1.39.x 1.40.x 1.40.x
Screenshot_20220616-204455_Brave Screenshot_20220616-204616_Brave Screenshot_20220616-204640_Brave
  1. Confirm the "Logged out" notification is displayed on the BAT logo:
Case 3: Upgrade profile, "sends" capability is false, brave://rewards page is not open after upgrade - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "sends" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "sends",
	"name": "Sends",
	"requirements": [],
	"restrictions": []
  1. Using clean profile, launch 1.39.x w/ staging env and Charles running w/ the rewrite rule in place.
  2. Enable Rewards
  3. Login using Uphold account, confirm account is linked as expected (you see balance, etc) - note, this is expected as 1.39.x does not use the "capabilities" endpoint
  4. Close any brave://rewards page and have some other tab as the open/active tab. Close 1.39.x.
  5. Rename profile to "Brave-Browser-Beta"
  6. Launch 1.40.x w/ staging
  7. Open panel
  8. Confirm rewrite rule is used using Charles
  9. Confirm you see the below in your logs
2022-06-16 21:45:17.446 11170-11170/? I/chromium: [INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!
  1. Confirm the panel shows you are logged out of Uphold notification in UI and your balance is not displayed.
1.39.x 1.40.x 1.40.x
Screenshot_20220616-214304_Brave Screenshot_20220616-214532_Brave Screenshot_20220616-214554_Brave
Case 4: Clean profile, "receives" capability is false - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "receives" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "receives",
	"name": "Receives",
	"requirements": [],
	"restrictions": []
  1. Using clean profile, launch 1.40.x w/ staging env and Charles running w/ the rewrite rule in place.
  2. Enable Rewards
  3. Login using Uphold account
  4. Confirm rewrite rule is used using Charles
  5. Confirm you see the below in your logs
2022-06-16 22:00:23.370 15155-15155/? I/chromium: [INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!
  1. Confirm the expected modal shows on the brave://rewards page
    Screenshot_20220616-220028_Brave
Case 5: Upgrade profile, "receives" capability is false, brave://rewards page is open and active after upgrade - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "receives" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "receives",
	"name": "Receives",
	"requirements": [],
	"restrictions": []
  1. Using clean profile, launch 1.39.x w/ staging env and Charles running w/ the rewrite rule in place.
  2. Enable Rewards
  3. Login using Uphold account, confirm account is linked as expected (you see balance, etc) - note, this is expected as 1.39.x does not use the "capabilities" endpoint
  4. Keep brave://rewards page as the open/active tab. Close 1.39.x
  5. Rename profile to "Brave-Browser-Beta"
  6. Launch 1.40.x w/ staging
  7. Confirm rewrite rule is used using Charles
  8. Confirm you see the below in your logs
2022-06-16 22:12:02.062 23112-23112/? I/chromium: [INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!
  1. Confirm the expected modal shows on the brave://rewards page
  2. Confirm after you close the modal you are logged out of Uphold in UI and your balance is not displayed. Encountered [Android] Rewards panel should say Logged out  #23480
1.39.x 1.40.x 1.40.x
Screenshot_20220616-221055_Brave Screenshot_20220616-221208_Brave Screenshot_20220616-221304_Brave
  1. Confirm the "Logged out" notification is displayed on the BAT logo, logged and encountered [Android] logged-out notification is not shown on the BR panel #23517
    Screenshot_20220616-221341_Brave
Case 6: Upgrade profile, "receives" capability is false, brave://rewards page is not open after upgrade - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "receives " part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "receives",
	"name": "Receives",
	"requirements": [],
	"restrictions": []
  1. Using clean profile, launch 1.39.x w/ staging env and Charles running w/ the rewrite rule in place.
  2. Enable Rewards
  3. Login using Uphold account, confirm account is linked as expected (you see balance, etc) - note, this is expected as 1.39.x does not use the "capabilities" endpoint
  4. Close any brave://rewards page and have some other tab as the open/active tab. Close 1.39.x.
  5. Rename profile to "Brave-Browser-Beta"
  6. Launch 1.40.x w/ staging
  7. Open panel
  8. Confirm rewrite rule is used using Charles
  9. Confirm you see the below in your logs
2022-06-16 22:27:47.073 29508-29508/? I/chromium: [INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!
  1. Confirm the panel shows you are logged out of Uphold notification in UI and your balance is not displayed.
1.39.x 1.40.x 1.40.x
Screenshot_20220616-222625_Brave Screenshot_20220616-222755_Brave Screenshot_20220616-222812_Brave
Case 7: Clean profile, both "sends" and "receives" are true - PASSED
  1. Confirm you've disabled all rewrite rules or have stopped running Charles
  2. Using clean profile, launch 1.40.x w/ staging env
  3. Enable Rewards
  4. Login using Uphold account in good standing
  5. Confirm able to link uphold account to Brave Rewards without any errors
  6. Confirm "sends" and "receives" both have enabled = true
{"category":"permissions","enabled":true,"key":"receives","name":"Receives","requirements":[],"restrictions":[]},{"category":"permissions","enabled":true,"key":"sends","name":"Sends","requirements":[],"restrictions":[]},
  1. Confirm balance displays in rewards as you would expect, logged and encountered [Android] Your Brave Rewards is verified toast notification is not shown on the BR panel #23519
Example Example
Screenshot_20220616-224244_Brave Screenshot_20220616-224258_Brave
Case 8: Upgrade profile, "sends" and "receives" are true, brave://rewards page is open and active after upgrade - PASSED
  1. Confirm you've disabled all rewrite rules or have stopped running Charles
  2. Using clean profile, launch 1.39.x w/ staging env
  3. Enable Rewards
  4. Login using Uphold account, confirm account is linked as expected (you see balance, etc)
  5. Keep brave://rewards page as the open/active tab. Close 1.39.x
  6. Rename profile to "Brave-Browser-Beta"
  7. Launch 1.40.x w/ staging
  8. Confirm "sends" and "receives" both have enabled = true
{"category":"permissions","enabled":true,"key":"receives","name":"Receives","requirements":[],"restrictions":[]},{"category":"permissions","enabled":true,"key":"sends","name":"Sends","requirements":[],"restrictions":[]}
  1. Confirm you are still logged in to Uphold with Brave Rewards
  2. Confirm balance displays in rewards as you would expect
1.39.x 1.40.x
Screenshot_20220616-225454_Brave Screenshot_20220616-225622_Brave
Case 9: Upgrade profile, "sends" and "receives" are true, brave://rewards page is not open after upgrade - PASSED
  1. Confirm you've disabled all rewrite rules or have stopped running Charles
  2. Using clean profile, launch 1.39.x w/ staging env
  3. Enable Rewards
  4. Login using Uphold account, confirm account is linked as expected (you see balance, etc)
  5. Close any brave://rewards pages and have another tab as the open/active tab. Close 1.39.x
  6. Rename profile to "Brave-Browser-Beta"
  7. Launch 1.40.x w/ staging
  8. Confirm "sends" and "receives" both have enabled = true
{"category":"permissions","enabled":true,"key":"receives","name":"Receives","requirements":[],"restrictions":[]},{"category":"permissions","enabled":true,"key":"sends","name":"Sends","requirements":[],"restrictions":[]}
  1. Confirm you are still logged in to Uphold with Brave Rewards
  2. Confirm balance displays in rewards as you would expect
1.39.x 1.40.x
Screenshot_20220616-230403_Brave (1) Screenshot_20220616-230540_Brave (1)

This was referenced Jun 16, 2022
Closed
Closed
@Uni-verse
Copy link
Contributor

Uni-verse commented Jun 16, 2022 •
edited
Loading

Verification completed on Samsung Galaxy S21 using

Brave	1.40.100 Chromium: 102.0.5005.125 (Official Build) beta (64-bit) 
Revision	07573b09e385116e620ed12d5ef2402c4bfa929f-refs/branch-heads/5005@{#1159}
OS	Android 12; Build/SP1A.210812.016
Case 1: Clean profile, "sends" capability is false - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "sends" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "sends",
	"name": "Sends",
	"requirements": [],
	"restrictions": []

  1. Using clean profile, launch 1.40.x w/ staging env and Charles running w/ the rewrite rule in place.

  2. Enable Rewards

  3. Login using Uphold account

  4. Confirm rewrite rule is used using Charles

  5. Confirm you see the below in your logs

  6. Confirm the expected modal shows on the brave://rewards page

0
Case 2: Upgrade profile, "sends" capability is false, brave://rewards page is open and active after upgrade - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "sends" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "sends",
	"name": "Sends",
	"requirements": [],
	"restrictions": []
  1. Using clean profile, launch 1.39.x w/ staging env and Charles running w/ the rewrite rule in place.
  2. Enable Rewards
  3. Login using Uphold account, confirm account is linked as expected (you see balance, etc) - note, this is expected as 1.39.x does not use the "capabilities" endpoint
  4. Keep brave://rewards page as the open/active tab. Close 1.39.x
  5. Rename profile to "Brave-Browser-Beta"
  6. Launch 1.40.x w/ staging
  7. Confirm rewrite rule is used using Charles
  8. Confirm you see the below in your logs
06-16 14:04:41.474 23927 23927 I chromium: [INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!
  1. Confirm the expected modal shows on the brave://rewards page
  2. Confirm after you close the modal you are logged out of Uphold in UI and your balance is not displayed.
Example Example
screenshot-1655412702821 screenshot-1655413518725
  1. Confirm the "Logged out" notification is displayed on the BAT logo:
Case 3: Upgrade profile, "sends" capability is false, brave://rewards page is not open after upgrade - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "sends" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "sends",
	"name": "Sends",
	"requirements": [],
	"restrictions": []
  1. Using clean profile, launch 1.39.x w/ staging env and Charles running w/ the rewrite rule in place.
  2. Enable Rewards
  3. Login using Uphold account, confirm account is linked as expected (you see balance, etc) - note, this is expected as 1.39.x does not use the "capabilities" endpoint
  4. Close any brave://rewards page and have some other tab as the open/active tab. Close 1.39.x.
  5. Rename profile to "Brave-Browser-Beta"
  6. Launch 1.40.x w/ staging
  7. Open panel
  8. Confirm rewrite rule is used using Charles
  9. Confirm you see the below in your logs
06-16 14:48:58.833 12354 12354 I chromium: [INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!
  1. Confirm the panel shows you are logged out of Uphold notification in UI and your balance is not displayed.
1.39.x 1.40.x 1.40.x
screenshot-1655415184634 screenshot-1655416205221 screenshot-1655416219659
Case 4: Clean profile, "receives" capability is false - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "receives" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "receives",
	"name": "Receives",
	"requirements": [],
	"restrictions": []
  1. Using clean profile, launch 1.40.x w/ staging env and Charles running w/ the rewrite rule in place.
  2. Enable Rewards
  3. Login using Uphold account
  4. Confirm rewrite rule is used using Charles
  5. Confirm you see the below in your logs
06-16 14:14:07.412 27453 27453 I chromium: [INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!
  1. Confirm the expected modal shows on the brave://rewards page
1
Case 5: Upgrade profile, "receives" capability is false, brave://rewards page is open and active after upgrade - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "receives" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "receives",
	"name": "Receives",
	"requirements": [],
	"restrictions": []
  1. Using clean profile, launch 1.39.x w/ staging env and Charles running w/ the rewrite rule in place.
  2. Enable Rewards
  3. Login using Uphold account, confirm account is linked as expected (you see balance, etc) - note, this is expected as 1.39.x does not use the "capabilities" endpoint
  4. Keep brave://rewards page as the open/active tab. Close 1.39.x
  5. Rename profile to "Brave-Browser-Beta"
  6. Launch 1.40.x w/ staging
  7. Confirm rewrite rule is used using Charles
  8. Confirm you see the below in your logs
06-16 15:05:05.966 19500 19500 I chromium: [INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!
  1. Confirm the expected modal shows on the brave://rewards page
  2. Confirm after you close the modal you are logged out of Uphold in UI and your balance is not displayed. Encountered [Android] Rewards panel should say Logged out  #23480
1.39.x 1.40.x 1.40.x
screenshot-1655415072101 screenshot-1655412702821 screenshot-1655416205221
  1. Confirm the "Logged out" notification is displayed on the BAT logo, logged and encountered [Android] logged-out notification is not shown on the BR panel #23517
Case 6: Upgrade profile, "receives" capability is false, brave://rewards page is not open after upgrade - PASSED
  1. Set up rewrite rule in Charles Proxy so that the "receives " part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)
	"category": "permissions",
	"enabled": false,
	"key": "receives",
	"name": "Receives",
	"requirements": [],
	"restrictions": []
  1. Using clean profile, launch 1.39.x w/ staging env and Charles running w/ the rewrite rule in place.
  2. Enable Rewards
  3. Login using Uphold account, confirm account is linked as expected (you see balance, etc) - note, this is expected as 1.39.x does not use the "capabilities" endpoint
  4. Close any brave://rewards page and have some other tab as the open/active tab. Close 1.39.x.
  5. Rename profile to "Brave-Browser-Beta"
  6. Launch 1.40.x w/ staging
  7. Open panel
  8. Confirm rewrite rule is used using Charles
  9. Confirm you see the below in your logs
06-16 15:17:51.739 25137 25137 I chromium: [INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!
  1. Confirm the panel shows you are logged out of Uphold notification in UI and your balance is not displayed.
1.39.x 1.40.x
screenshot-1655415072101 screenshot-1655417882238
Case 7: Clean profile, both "sends" and "receives" are true - PASSED
  1. Confirm you've disabled all rewrite rules or have stopped running Charles
  2. Using clean profile, launch 1.40.x w/ staging env
  3. Enable Rewards
  4. Login using Uphold account in good standing
  5. Confirm able to link uphold account to Brave Rewards without any errors
  6. Confirm "sends" and "receives" both have enabled = true
{"category":"permissions","enabled":true,"key":"receives","name":"Receives","requirements":[],"restrictions":[]},{"category":"permissions","enabled":true,"key":"sends","name":"Sends","requirements":[],"restrictions":[]},
  1. Confirm balance displays in rewards as you would expect
Example Example
screenshot-1655415072101 screenshot-1655415184634
Case 8: Upgrade profile, "sends" and "receives" are true, brave://rewards page is open and active after upgrade - PASSED
  1. Confirm you've disabled all rewrite rules or have stopped running Charles
  2. Using clean profile, launch 1.39.x w/ staging env
  3. Enable Rewards
  4. Login using Uphold account, confirm account is linked as expected (you see balance, etc)
  5. Keep brave://rewards page as the open/active tab. Close 1.39.x
  6. Rename profile to "Brave-Browser-Beta"
  7. Launch 1.40.x w/ staging
  8. Confirm "sends" and "receives" both have enabled = true
{"category":"permissions","enabled":true,"key":"receives","name":"Receives","requirements":[],"restrictions":[]},{"category":"permissions","enabled":true,"key":"sends","name":"Sends","requirements":[],"restrictions":[]}
  1. Confirm you are still logged in to Uphold with Brave Rewards
  2. Confirm balance displays in rewards as you would expect
Example Example
screenshot-1655418290069 screenshot-1655418282481
Case 9: Upgrade profile, "sends" and "receives" are true, brave://rewards page is not open after upgrade - PASSED
  1. Confirm you've disabled all rewrite rules or have stopped running Charles
  2. Using clean profile, launch 1.39.x w/ staging env
  3. Enable Rewards
  4. Login using Uphold account, confirm account is linked as expected (you see balance, etc)
  5. Close any brave://rewards pages and have another tab as the open/active tab. Close 1.39.x
  6. Rename profile to "Brave-Browser-Beta"
  7. Launch 1.40.x w/ staging
  8. Confirm "sends" and "receives" both have enabled = true
{"category":"permissions","enabled":true,"key":"receives","name":"Receives","requirements":[],"restrictions":[]},{"category":"permissions","enabled":true,"key":"sends","name":"Sends","requirements":[],"restrictions":[]}
  1. Confirm you are still logged in to Uphold with Brave Rewards
  2. Confirm balance displays in rewards as you would expect
Example Example
screenshot-1655418282481 screenshot-1655418290069

@LaurenWags LaurenWags mentioned this issue Jul 14, 2022
Merged
25 tasks
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jul 18, 2022
Closed
@LaurenWags LaurenWags mentioned this issue Dec 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szilardszaloki szilardszaloki

Labels
feature/rewards/Uphold feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.40.x - Release
Development

Successfully merging a pull request may close this issue.

Implements /v0/me/capabilities, upholdInsufficientCapabilitiesModal. brave/brave-core
7 participants
@kjozwiak @szilardszaloki @Miyayes @Uni-verse @LaurenWags @btlechowski @GeetaSarvadnya