Implements `/v0/me/capabilities`, `upholdInsufficientCapabilitiesModal`. #13474

szilardszaloki · 2022-05-25T21:35:42Z

Resolves brave/brave-browser#22508.

Implements /v0/me/capabilities and upholdInsufficientCapabilitiesModal:

Removes:

Uphold user status inspection
explicit CDD check
upholdBlockedUserModal, upholdPendingUserModal, upholdRestrictedUserModal, upholdCustomerDueDiligenceRequiredModal

Submitter Checklist:

I confirm that no security/privacy review is needed, or that I have requested one
There is a ticket for my issue
Used Github auto-closing keywords in the PR description above
Wrote a good PR/commit description
Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
Ran git rebase master (if needed)

Reviewer Checklist:

A security review is not needed, or a link to one is included in the PR description
New files have MPL-2.0 license header
Adequate test coverage exists to prevent regressions
Major classes, functions and non-trivial code blocks are well-commented
Changes in component dependencies are properly reflected in gn
Code follows the style guide
Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

The Test Plan of #11857 can be applied here. Make sure to edit the response of /v0/me/capabilities with Charles Proxy so that either receives or sends is set to false.

brave-builds · 2022-05-25T22:26:21Z

A Storybook has been deployed to preview UI for the latest push

vendor/bat-native-ledger/src/bat/ledger/internal/uphold/uphold_wallet.cc

brave-builds · 2022-05-26T00:41:10Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2022-05-26T04:05:41Z

A Storybook has been deployed to preview UI for the latest push

Removes: - Uphold user status inspection - explicit CDD check - `upholdBlockedUserModal`, `upholdPendingUserModal`, `upholdRestrictedUserModal`, `upholdCustomerDueDiligenceRequiredModal`

emerick

LGTM

brave-builds · 2022-05-26T13:19:48Z

A Storybook has been deployed to preview UI for the latest push

…oint Implements `/v0/me/capabilities`, `upholdInsufficientCapabilitiesModal`.

LaurenWags · 2022-06-01T18:38:02Z

Verified with

Brave | 1.41.30 Chromium: 102.0.5005.78 (Official Build) nightly (x86_64)
-- | --
Revision | df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS | macOS Version 12.4 (Build 21F79)

Verified test plan from #13474 (comment) for the following:

Case 1: Clean profile, "sends" capability is false - PASSED

Set up rewrite rule in Charles Proxy so that the "sends" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)

	"category": "permissions",
	"enabled": false,
	"key": "sends",
	"name": "Sends",
	"requirements": [],
	"restrictions": []

Using clean profile, launch 1.41.x w/ staging env and Charles running w/ the rewrite rule in place.
Enable Rewards
Login using Uphold account
Confirm rewrite rule is used using Charles
Confirm you see the below in your logs

[11842:259:0601/144220.033667:INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!

Confirm the expected modal shows on the brave://rewards page

Case 2: Upgrade profile, "sends" capability is false, brave://rewards page is open and active after upgrade - PASSED

Set up rewrite rule in Charles Proxy so that the "sends" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)

	"category": "permissions",
	"enabled": false,
	"key": "sends",
	"name": "Sends",
	"requirements": [],
	"restrictions": []

Using clean profile, launch 1.39.x w/ staging env and Charles running w/ the rewrite rule in place.
Enable Rewards
Login using Uphold account, confirm account is linked as expected (you see balance, etc) - note, this is expected as 1.39.x does not use the "capabilities" endpoint
Keep brave://rewards page as the open/active tab. Close 1.39.x
Rename profile to "Brave-Browser-Nightly"
Launch 1.41.x w/ staging
Confirm rewrite rule is used using Charles
Confirm you see the below in your logs

[12496:259:0601/145424.637891:INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!

Confirm the expected modal shows on the brave://rewards page
Confirm after you close the modal you are logged out of Uphold in UI and your balance is not displayed.

1.39.x	1.41.x	1.41.x

Confirm the "Logged out" notification is displayed on the BAT logo:

Case 3: Upgrade profile, "sends" capability is false, brave://rewards page is not open after upgrade - PASSED

Set up rewrite rule in Charles Proxy so that the "sends" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)

	"category": "permissions",
	"enabled": false,
	"key": "sends",
	"name": "Sends",
	"requirements": [],
	"restrictions": []

Using clean profile, launch 1.39.x w/ staging env and Charles running w/ the rewrite rule in place.
Enable Rewards
Login using Uphold account, confirm account is linked as expected (you see balance, etc) - note, this is expected as 1.39.x does not use the "capabilities" endpoint
Close any brave://rewards page and have some other tab as the open/active tab. Close 1.39.x.
Rename profile to "Brave-Browser-Nightly"
Launch 1.41.x w/ staging
Open panel
Confirm rewrite rule is used using Charles
Confirm you see the below in your logs

[12775:259:0601/151459.952294:INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!

Confirm the panel shows you are logged out of Uphold notification in UI and your balance is not displayed.

1.39.x	1.41.x	1.41.x

Case 4: Clean profile, "receives" capability is false - PASSED

Set up rewrite rule in Charles Proxy so that the "receives" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)

	"category": "permissions",
	"enabled": false,
	"key": "receives",
	"name": "Receives",
	"requirements": [],
	"restrictions": []

Using clean profile, launch 1.41.x w/ staging env and Charles running w/ the rewrite rule in place.
Enable Rewards
Login using Uphold account
Confirm rewrite rule is used using Charles
Confirm you see the below in your logs

[12897:259:0601/152151.537735:INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!

Confirm the expected modal shows on the brave://rewards page

Case 5: Upgrade profile, "receives" capability is false, brave://rewards page is open and active after upgrade - PASSED

Set up rewrite rule in Charles Proxy so that the "receives" part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)

	"category": "permissions",
	"enabled": false,
	"key": "receives",
	"name": "Receives",
	"requirements": [],
	"restrictions": []

Using clean profile, launch 1.39.x w/ staging env and Charles running w/ the rewrite rule in place.
Enable Rewards
Login using Uphold account, confirm account is linked as expected (you see balance, etc) - note, this is expected as 1.39.x does not use the "capabilities" endpoint
Keep brave://rewards page as the open/active tab. Close 1.39.x
Rename profile to "Brave-Browser-Nightly"
Launch 1.41.x w/ staging
Confirm rewrite rule is used using Charles
Confirm you see the below in your logs

[13276:259:0601/153020.922087:INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!

Confirm the expected modal shows on the brave://rewards page
Confirm after you close the modal you are logged out of Uphold in UI and your balance is not displayed.

1.39.x	1.41.x	1.41.x

Confirm the "Logged out" notification is displayed on the BAT logo:

Case 6: Upgrade profile, "receives" capability is false, brave://rewards page is not open after upgrade - PASSED

Set up rewrite rule in Charles Proxy so that the "receives " part of the response to https://api-sandbox.uphold.com/v0/me/capabilities has enabled = false like below (note, this is not the entire response, just the snippet we need to modify, your rewrite rule needs the entire response)

	"category": "permissions",
	"enabled": false,
	"key": "receives",
	"name": "Receives",
	"requirements": [],
	"restrictions": []

Using clean profile, launch 1.39.x w/ staging env and Charles running w/ the rewrite rule in place.
Enable Rewards
Login using Uphold account, confirm account is linked as expected (you see balance, etc) - note, this is expected as 1.39.x does not use the "capabilities" endpoint
Close any brave://rewards page and have some other tab as the open/active tab. Close 1.39.x.
Rename profile to "Brave-Browser-Nightly"
Launch 1.41.x w/ staging
Open panel
Confirm rewrite rule is used using Charles
Confirm you see the below in your logs

[13424:259:0601/153315.992860:INFO:uphold_wallet.cc(153)] User doesn't have the required Uphold capabilities!

Confirm the panel shows you are logged out of Uphold notification in UI and your balance is not displayed.

1.39.x	1.41.x	1.41.x

Also verified the following cases for an account in good standing/full capabilities:

Case 7: Clean profile, both "sends" and "receives" are true - PASSED

Confirm you've disabled all rewrite rules or have stopped running Charles
Using clean profile, launch 1.41.x w/ staging env
Enable Rewards
Login using Uphold account in good standing
Confirm able to link uphold account to Brave Rewards without any errors
Confirm "sends" and "receives" both have enabled = true

{"category":"permissions","enabled":true,"key":"receives","name":"Receives","requirements":[],"restrictions":[]},
{"category":"permissions","enabled":true,"key":"sends","name":"Sends","requirements":[],"restrictions":[]},

Confirm balance displays in rewards as you would expect

Example	Example

Case 8: Upgrade profile, "sends" and "receives" are true, brave://rewards page is open and active after upgrade - PASSED

Confirm you've disabled all rewrite rules or have stopped running Charles
Using clean profile, launch 1.39.x w/ staging env
Enable Rewards
Login using Uphold account, confirm account is linked as expected (you see balance, etc)
Keep brave://rewards page as the open/active tab. Close 1.39.x
Rename profile to "Brave-Browser-Nightly"
Launch 1.41.x w/ staging
Confirm "sends" and "receives" both have enabled = true

{"category":"permissions","enabled":true,"key":"receives","name":"Receives","requirements":[],"restrictions":[]},
{"category":"permissions","enabled":true,"key":"sends","name":"Sends","requirements":[],"restrictions":[]},

Confirm you are still logged in to Uphold with Brave Rewards
Confirm balance displays in rewards as you would expect

1.39.x	1.41.x

Case 9: Upgrade profile, "sends" and "receives" are true, brave://rewards page is not open after upgrade - PASSED

Confirm you've disabled all rewrite rules or have stopped running Charles
Using clean profile, launch 1.39.x w/ staging env
Enable Rewards
Login using Uphold account, confirm account is linked as expected (you see balance, etc)
Close any brave://rewards pages and have another tab as the open/active tab. Close 1.39.x
Rename profile to "Brave-Browser-Nightly"
Launch 1.41.x w/ staging
Confirm "sends" and "receives" both have enabled = true

{"category":"permissions","enabled":true,"key":"receives","name":"Receives","requirements":[],"restrictions":[]},
{"category":"permissions","enabled":true,"key":"sends","name":"Sends","requirements":[],"restrictions":[]},

Confirm you are still logged in to Uphold with Brave Rewards
Confirm balance displays in rewards as you would expect

1.39.x	1.41.x

szilardszaloki requested review from bsclifton, emerick and zenparsing May 25, 2022 21:35

szilardszaloki requested a review from a team as a code owner May 25, 2022 21:35

szilardszaloki self-assigned this May 25, 2022

github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label May 25, 2022

zenparsing reviewed May 25, 2022

View reviewed changes

vendor/bat-native-ledger/src/bat/ledger/internal/uphold/uphold_wallet.cc Outdated Show resolved Hide resolved

zenparsing approved these changes May 26, 2022

View reviewed changes

szilardszaloki force-pushed the sszaloki-22508-capabilities-endpoint branch from 4eba72e to a90d22f Compare May 26, 2022 03:37

Implements /v0/me/capabilities, upholdInsufficientCapabilitiesModal.

c58bd92

Removes: - Uphold user status inspection - explicit CDD check - `upholdBlockedUserModal`, `upholdPendingUserModal`, `upholdRestrictedUserModal`, `upholdCustomerDueDiligenceRequiredModal`

szilardszaloki force-pushed the sszaloki-22508-capabilities-endpoint branch from a90d22f to c58bd92 Compare May 26, 2022 12:53

emerick approved these changes May 26, 2022

View reviewed changes

szilardszaloki added this to the 1.41.x - Nightly milestone May 26, 2022

szilardszaloki merged commit 7687ffe into master May 26, 2022

szilardszaloki deleted the sszaloki-22508-capabilities-endpoint branch May 26, 2022 16:21

bsclifton pushed a commit that referenced this pull request May 27, 2022

Merge pull request #13474 from brave/sszaloki-22508-capabilities-endp…

14ac6bb

…oint Implements `/v0/me/capabilities`, `upholdInsufficientCapabilitiesModal`.

bsclifton pushed a commit that referenced this pull request May 27, 2022

Merge pull request #13474 from brave/sszaloki-22508-capabilities-endp…

3707840

…oint Implements `/v0/me/capabilities`, `upholdInsufficientCapabilitiesModal`.

This was referenced May 27, 2022

Implements /v0/me/capabilities, upholdInsufficientCapabilitiesModal. (Uplift to 1.40.x) #13516

Merged

Implements /v0/me/capabilities, upholdInsufficientCapabilitiesModal. (Uplift to 1.39.x) #13517

Closed

LaurenWags mentioned this pull request Jun 6, 2022

Implement error modal if user does not have receives OR sends capabilities on Uphold brave/brave-browser#22508

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implements `/v0/me/capabilities`, `upholdInsufficientCapabilitiesModal`. #13474

Implements `/v0/me/capabilities`, `upholdInsufficientCapabilitiesModal`. #13474

szilardszaloki commented May 25, 2022 •

edited

Loading

brave-builds commented May 25, 2022

brave-builds commented May 26, 2022

brave-builds commented May 26, 2022

emerick left a comment

brave-builds commented May 26, 2022

LaurenWags commented Jun 1, 2022 •

edited

Loading

Implements /v0/me/capabilities, upholdInsufficientCapabilitiesModal. #13474

Implements /v0/me/capabilities, upholdInsufficientCapabilitiesModal. #13474

Conversation

szilardszaloki commented May 25, 2022 • edited Loading

Submitter Checklist:

Reviewer Checklist:

After-merge Checklist:

Test Plan:

brave-builds commented May 25, 2022

brave-builds commented May 26, 2022

brave-builds commented May 26, 2022

emerick left a comment

Choose a reason for hiding this comment

brave-builds commented May 26, 2022

LaurenWags commented Jun 1, 2022 • edited Loading

Implements `/v0/me/capabilities`, `upholdInsufficientCapabilitiesModal`. #13474

Implements `/v0/me/capabilities`, `upholdInsufficientCapabilitiesModal`. #13474

szilardszaloki commented May 25, 2022 •

edited

Loading

LaurenWags commented Jun 1, 2022 •

edited

Loading