-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Omaha (Brave's auto-updater on Windows) to 1.3.36.131 #23047
Comments
Verification
Windows 11 x64Pre-requisite steps(Please note these steps are described in the "Cleaning up after a test" in https://github.com/brave/brave-core/pull/11096 with additional details)
![]() Test Case 1. Verify installers and auto-updater work on a clean profile Case 1: Verify Omaha updater version when 1.41.x is installed with standalone installer with admin privileges_PASSED
Steps:
Case 2: Download and install stub installer binary 1.41.x with admin privileges_PASSED
Case 3: Download and install standalone silent installer binary 1.41.x_PASSED
Test Case 2. Verify installers and auto-updater works on an upgrade profile Case 1:Verify the Omaha updater version in an upgraded profile (Install 1.39.96 ->upgrade to 1.41.x)This testcase verifies update from current updater (1.3.361.113) to latest version (1.3.361.133)Steps:
Updater Validation
Steps
Case 2:Verify the Omaha updater version in an upgraded profile (Install 1.39.96 ->upgrade to 1.41.x)This test case has been verified after staging has been reverted from 1.3.361.133 to 1.3.361.131
Case 3:Verify the Omaha updater version in an upgraded profile (Install 1.39.96 ->upgrade to 1.41.x)for `standalone silent installer`Have tested with
Case 4: Install standalone installer 1.40.x and upgrade the profile to 1.41.x_PASSED
Case 5: Install standalone installer 1.40.x and upgrade the profile to 1.41.x test channel_PASSED
Case 6: Verify the Omaha updater version in an upgraded profile (Install 1.39.96 ->upgrade to 1.41.x)
Test Case 3. Verify installers and auto-updater work when the user declines the admin privileges in UAC Case 1: Verify standalone installer can be installed without admin privileges and updater works_PASSED
Case 2: Verify stub installer can be installed without admin privileges_PASSED
Test Case 4: Verify Install and re-install with old and new binaries Case 1: Verify standalone installer can be installed and re-installed with the same version_PASSED* `StandaloneBetaSetup.exe`
Case 2: Verify stub installer can be installed and re-installed with newer and older versions_PASSED`SetupBeta.exe`
Case 3: Verify standalone silent installer can be installed and reinstalled with older and newer versions_PASSED
Test Case 5. Install quite older installers and check update works correctly Case 1: Install 1.37.x and ensure upgrade works_PASSED
Case 2: Install 1.34.x and ensure upgrade works_PASSED
Case 3: Install 1.30.x and ensure upgrade works_PASSED
Case 4: Install 1.22.x and ensure upgrade works_PASSED
Test Case 6. Verify that install brave works when the Internet is disconnected Case 1: Verify standalone installer can be installed when the network is disconnected_PASSED
![]() Case 2: Verify standalone silent installer can be installed when the network is disconnected_PASSED
![]() Case 3: Verify stub installer can't be installed when the network is disconnected_PASSED
![]() Test Case 7. Verify install and re-install different installers (e.g one is standalone and the other is stub/silent) Case 1: Install standalone installer 1.40.x and upgrade it by 1.41.x stub installer_PASSED
Case 2: Install standalone silent installer 1.40.x and upgrade it by 1.41.x stub installer without admin privileges_PASSED
Case 3: Install standalone silent installer 1.40.x and then auto upgrade_PASSED
|
@mherrmann Seeing couple of Issue 1: Updater is not updating to correct version (
NOTE: Issue 2: Update notifications
cc: @brave/qa-team |
Issue 1: Where did you see that error? I do see in the screenshot Ex1 that you have two copies of the updater installed: A copy just for your current Windows user and a copy for the entire machine. Which Issue 2: The latest Brave version on the staging server is 1.36.39. Once you've received the latest updater from the staging server, you could delete |
@mherrmann Issue 2: Thanks for the suggestion. Deleting Steps:
|
@mherrmann Here are more detailed steps for
Actual Results: When I try to run the scheduler, nothin happens and eventually I see this error
|
@MadhaviSeelam Issue 2: I think the Issue 1: Omaha can be installed just for the current user, or for the entire machine. If it's installed for the current user only, then you get The steps you posted mention I believe I would try to remove both the per-user and the per-machine install of Omaha from your system, then repeat any steps with either a machine- or user install. To make sure that all copies of Omaha were successfully uninstalled, you can check that there are no Thanks for all your help @mherrmann. Issue 1: I am still not getting correct updater version Issue 2: I have waited for few minutes for @mherrmann - I looked at your notes again and I missed this part |
Verification PASSED on
Windows 10 x641. Verify installers and auto-updater work on a clean profile Case 1: Verify the Omaha updater version when 1.41.x is installed_PASSEDPre-requisites:
Steps:
Case 2: Download and install stub installer binary 1.41.x with Admin rights_PASSED
Case 3: Download and install standalone silent installer binary 1.41.x_PASSED
2. Verify installers and auto-updater works on upgrade profile Case 1:Verify the Omaha updater version in an upgraded profile (Install 1.40.86 ->upgrade to 1.41.x)_PASSEDSteps :
Followed the steps from "Background updates" in brave/brave-core#11096 - to verify the Omaha updates silently in the background and confirmed that updater got updated to latest version Case 2: Install standalone installer 1.40.x and upgrade the profile to 1.41.x_PASSED
Case 3: Install standalone installer 1.40.x and upgrade the profile to 1.41.x test channel_PASSED
Case 4: Install standalone silent installer 1.40.x and upgrade the profile to 1.41.x_PASSED
3. Verify installers and auto-updater work when the user declines the Admin rights in UAC [Note : when brave is installed for the current user (without admin rights) the Case 1: Verify standalone installer can be installed without admin rights and updater works_PASSED
Case 2: Verify stub installer can be installed without admin rights_PASSED
4. Verify re-install same installer version works Case 1: Verify standalone installer can be installed twice and update works_PASSED
Case 2: Verify stub installer can be installed twice_PASSED
Case 3: Verify standalone silent installer can be installed twice and update works_PASSED
5. Install quite older installers and check update works correctly Case 1: Install 1.34.x and ensure upgrade works_PASSED
Case 2: Install 1.30.x and ensure upgrade works_PASSED
Case 3: Install 1.29.x and ensure upgrade works_PASSED
Case 4: Install 1.22.x and ensure upgrade works_PASSED
Case 5: Install 1.18.x and ensure upgrade works_PASSED
6. Verify that install brave works when the Internet is disconnected Case 1: Verify standalone installer can be installed when the network is disconnected_PASSED
Case 2: Verify standalone silent installer can be installed when the network is disconnected_PASSED
Case 3: Verify stub installer can't be installed when the network is disconnected_PASSED
7. Verify installing a new binary by older binary from different installers (e.g one is standalone and the other is stub/silent) Case 1: Install standalone installer 1.40.x and upgrade it by 1.41.x stub installer_PASSED
Case 2: Install standalone silent installer 1.40.x and upgrade it by 1.41.x stub installer(decline Admin rights)_PASSED
Case 3: Install standalone silent installer 1.40.x and then autoupgrade_PASSED
Case 4: Install standalone installer 1.40.x and then autoupgrade_PASSED
|
Verified on Windows 10 x86 with various 1.41.x versions, primarily the most recent one:
Pre-requisite steps (largely not used below as I use a fresh VM instead of cleaning up)Pre-requisites:
Windows 10 x861. Verify installers and auto-updater work on a clean profile Case 1: Verify the Omaha updater version when 1.41.x is installed - PASSEDSteps:
2. Verify installers and auto-updater works on upgrade profile Case 1:Verify the Omaha updater version in an upgraded profile (Install 1.37.77 ->upgrade to 1.41.x) - PASSEDSteps :
Worked with Geeta to understand and follow the steps from 1.) #22060 (comment) and then 2.) "Background updates" in brave/brave-core#11096 - to verify the Omaha updates silently in the background and confirmed that updater got updated to latest version Confirmed Omaha updater version updated from
Case 2: Download and install stub installer binary 1.41.x with Admin rights - PASSED
Case 3: Download and install standalone silent installer binary 1.41.x - PASSED
3. Verify installers and auto-updater work when the user declines the Admin rights in UAC Case 1: Verify standalone installer can be installed without admin rights and updater works - PASSED
Installed 1.41.86 --> Updated to 1.41.91
4. Verify re-install same installer version works Case 1: Verify standalone installer can be installed twice and update works - PASSED
5. Install quite older installers and check update works correctly Case 1: Install 1.30.x and ensure upgrade works - PASSED
6. Verify that install brave works when the Internet is disconnected Case 1: Verify standalone installer can be installed when the network is disconnected - PASSED
7. Verify installing a new binary by older binary from different installers (e.g one is standalone and the other is stub/silent) Case 1: Install standalone installer 1.40.x and upgrade it by 1.41.x stub installer - PASSED
|
Verification PASSED on
Pre-requisite steps (largely not used below as I use a fresh VM instead of cleaning up)Pre-requisites:
Windows 8.1 x641. Verify installers and auto-updater work on a clean profile Case 1: Verify the Omaha updater version when 1.41.x is installed - PASSEDSteps:
2. Verify installers and auto-updater works on upgrade profile Case 1:Verify the Omaha updater version in an upgraded profile (Install 1.37.77 ->upgrade to 1.41.x) - PASSEDSteps :
Used the STR/Cases outlined via 1.) #22060 (comment) and then 2.) "Background updates" in brave/brave-core#11096 - to verify the Omaha updates silently in the background and confirmed that updater got updated to latest version Confirmed Omaha updater version updated from
Case 2: Download and install stub installer binary 1.41.x with Admin rights - PASSED
Case 3: Download and install standalone silent installer binary 1.41.x - PASSED
3. Verify installers and auto-updater work when the user declines the Admin rights in UAC Case 1: Verify standalone installer can be installed without admin rights and updater works - PASSED
Installed
4. Verify re-install same installer version works Case 1: Verify standalone installer can be installed twice and update works - PASSED
5. Install quite older installers and check update works correctly Case 1: Install 1.30.x and ensure upgrade works - PASSED
6. Verify that install brave works when the Internet is disconnected Case 1: Verify standalone installer can be installed when the network is disconnected - PASSED
7. Verify installing a new binary by older binary from different installers (e.g one is standalone and the other is stub/silent) Case 1: Install standalone installer 1.40.x and upgrade it by 1.41.x stub installer - PASSED
|
Description
Google released a new upstream version of this technology. We should update Brave to it as well to get the latest fixes.
Test plan
This change has the potential to break Brave's installers and entire update fleet on Windows. It is therefore very important to re-test these features once this issue is resolved. Please see brave/brave-core#11096 for a test plan.
Roll-out strategy
Please see brave/brave-core#11096
The text was updated successfully, but these errors were encountered: