Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Wallet new user P3A metric #23463

Closed
DJAndries opened this issue Jun 14, 2022 · 4 comments · Fixed by brave/brave-core#13787
Closed

Add Wallet new user P3A metric #23463

DJAndries opened this issue Jun 14, 2022 · 4 comments · Fixed by brave/brave-core#13787
Assignees
@DJAndries
Labels
feature/web3/wallet Integrating Ethereum+ wallet support features/P3A OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.42.x - Release

Comments

@DJAndries
Copy link
Collaborator

DJAndries commented Jun 14, 2022 •
edited
Loading

Add one new P3A question for wallet:

"As a first time user of Brave Wallet this week, did I return again to use it during the first 7 day period?"
Brave.Wallet.NewUserReturning

  1. I have never used Brave Wallet
  2. I have used Brave Wallet, but I'm not a first time Brave Wallet user this week
  3. I'm a first time Brave Wallet user this week but, no, I did not return the rest of the week
  4. I'm a first time Brave Wallet user this week and, yes, I returned and used it again the following day
  5. I'm a first time Brave Wallet user this week and, yes, I returned and used it again this week but not the following day

Will raise PR soon.
@DJAndries DJAndries added OS/Android Fixes related to Android browser functionality OS/Desktop labels Jun 14, 2022
@DJAndries DJAndries self-assigned this Jun 14, 2022
@DJAndries DJAndries mentioned this issue Jun 14, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.42.x - Nightly milestone Jun 29, 2022
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 13, 2022 •
edited
Loading

Verification PASSED on

Brave | 1.42.64 Chromium: 103.0.5060.114 (Official Build) beta (64-bit)
-- | --
Revision | a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS | Windows 10 Version 21H2 (Build 19044.1806)
Case 1: I have never used Brave Wallet = 0_PASSED
  • Confirmed that Brave.Wallet.NewUserReturning metrics response value is 0 when brave wallet is not used
    image
Case 2: I have used Brave Wallet, but I'm not a first-time Brave Wallet user this week = 1_PASSED

Case 1:

  1. Set the system date to 11th July (starting day of the week)
  2. Clean profile 1.42.x
  3. Create a wallet
  4. Open the brave://local-state file and ensured that the metrics Brave.Wallet.NewUserReturning response value is 2
  5. Close the browser and set the system clock ahead by one week (18th July)
  6. Relaunch the browser
  7. Unlock the wallet
  8. Reload the brave://local-state file
  9. The metrics response value is 1 as expected
    image (3)

Case 2:

  1. Set the system date to 11th July (starting day of the week)
  2. Clean profile 1.42.x
  3. Create a wallet today
  4. Open the brave://local-state file and ensured that the metrics Brave.Wallet.NewUserReturning response value is 2
  5. Close the browser and set the system clock ahead by one week (18th July)
  6. Relaunch the browser
  7. Unlock the wallet
  8. Reload the brave://local-state file
  9. The metrics Brave.Wallet.NewUserReturning response value is 1 as expected
  10. Close the browser and set the system clock ahead by one week (19th July/22 July/ 23 July/ 24 July / 26 July)
  11. Relaunch the browser
  12. Unlock the wallet
  13. Reload the brave://local-state file
  14. The metrics Brave.Wallet.NewUserReturning response value is 1 as expected
    image (3)
Case 3: I'm a first-time Brave Wallet user this week but, no, I did not return the rest of the week = 2_PASSED

Case 1:

  1. Clean profile 1.42.x
  2. Open the brave://local-state file and ensured that the metrics Brave.Wallet.NewUserReturning response value is 0
  3. Create a wallet and reload the brave://local-state file and ensured that the metrics Brave.Wallet.NewUserReturning response value is 2 as expected
    image
Case 4: I'm a first-time Brave Wallet user this week and, yes, I returned and used it again the following day = 3_PASSED

Case 1:

  1. Clean profile 1.42.x
  2. Create a wallet today (14th July)
  3. Open the brave://local-state file and ensured that the metrics Brave.Wallet.NewUserReturning response value is 2
  4. Close the browser and set the system clock ahead by one day (15th July)
  5. Relaunch the browser
  6. Unlock the wallet
  7. Reload the brave://local-state file
  8. The metrics response value is 3 as expected
    image (4)

Case 2:

  1. Clean profile 1.42.x
  2. Create a wallet today (11th July)
  3. Open the brave://local-state file and ensured that the metrics Brave.Wallet.NewUserReturning response value is 2
  4. Close the browser and set the system clock ahead by one day (12th July)
  5. Relaunch the browser
  6. Unlock the wallet
  7. Reload the brave://local-state file
  8. The metrics response value is 3 as expected
    image (4)
Case 5: I'm a first time Brave Wallet user this week and, yes, I returned and used it again this week but not the following day = 4_PASSED
  1. Clean profile 1.42.x
  2. Create a wallet today (14th July)
  3. Open the brave://local-state file and ensured that the metrics Brave.Wallet.NewUserReturning response value is 2
  4. Close the browser and set the system clock ahead by one day (16th July)
  5. Relaunch the browser
  6. Unlock the wallet
  7. Reload the brave://local-state file
  8. The metrics response value is 4 as expected
    image

@GeetaSarvadnya GeetaSarvadnya mentioned this issue Jul 14, 2022
Closed
@GeetaSarvadnya
Copy link

@DJAndries I assume a week is considered from the day when wallet is created. Is my understanding correct?

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 28, 2022 •
edited
Loading

Verification PASSED on Samsung Galaxy Tab A7 version 11 running Bravemonoarm.apk_1.42.80

Case 1: I have never used Brave Wallet = 0_PASSED
  • Confirmed that Brave.Wallet.NewUserReturning metrics response value is 0 when brave wallet is not used
    Screenshot_20220728-154500_Brave
Case 2: I have used Brave Wallet, but I'm not a first-time Brave Wallet user this week = 1_PASSED

Case 1:

  1. Set the system date to 11th July (starting day of the week)
  2. Clean profile 1.42.x
  3. Create a wallet
  4. Open the brave://local-state file and ensured that the metrics Brave.Wallet.NewUserReturning response value is 2
  5. Close the browser and set the system clock ahead by one week (18th July)
  6. Relaunch the browser
  7. Unlock the wallet
  8. Reload the brave://local-state file
  9. The metrics response value is 1 as expected
    Screenshot_20220718-155832_Brave

Case 2:

  1. Set the system date to 11th July (starting day of the week)
  2. Clean profile 1.42.x
  3. Create a wallet today
  4. Open the brave://local-state file and ensured that the metrics Brave.Wallet.NewUserReturning response value is 2
  5. Close the browser and set the system clock ahead by one week (18th July)
  6. Relaunch the browser
  7. Unlock the wallet
  8. Reload the brave://local-state file
  9. The metrics Brave.Wallet.NewUserReturning response value is 1 as expected
  10. Close the browser and set the system clock ahead by one week (19th July/22 July/ 23 July/ 24 July / 26 July)
  11. Relaunch the browser
  12. Unlock the wallet
  13. Reload the brave://local-state file
  14. The metrics Brave.Wallet.NewUserReturning response value is 1 as expected
    Screenshot_20220718-155832_Brave
Case 3: I'm a first-time Brave Wallet user this week but, no, I did not return the rest of the week = 2_PASSED

Case 1:

  1. Clean profile 1.42.x
  2. Open the brave://local-state file and ensured that the metrics Brave.Wallet.NewUserReturning response value is 0
  3. Create a wallet and reload the brave://local-state file and ensured that the metrics Brave.Wallet.NewUserReturning response value is 2 as expected
    Screenshot_20220711-155411_Brave
Case 4: I'm a first-time Brave Wallet user this week and, yes, I returned and used it again the following day = 3_PASSED

Case 1:

  1. Clean profile 1.42.x
  2. Create a wallet today (14th July)
  3. Open the brave://local-state file and ensured that the metrics Brave.Wallet.NewUserReturning response value is 2
  4. Close the browser and set the system clock ahead by one day (15th July)
  5. Relaunch the browser
  6. Unlock the wallet
  7. Reload the brave://local-state file
  8. The metrics response value is 3 as expected

Screenshot_20220715-160837_Brave

Case 2:

  1. Clean profile 1.42.x
  2. Create a wallet today (11th July)
  3. Open the brave://local-state file and ensured that the metrics Brave.Wallet.NewUserReturning response value is 2
  4. Close the browser and set the system clock ahead by one day (12th July)
  5. Relaunch the browser
  6. Unlock the wallet
  7. Reload the brave://local-state file
  8. The metrics response value is 3 as expected
    Screenshot_20220718-155832_Brave
Case 5: I'm a first time Brave Wallet user this week and, yes, I returned and used it again this week but not the following day = 4_PASSED
  1. Clean profile 1.42.x
  2. Create a wallet today (14th July)
  3. Open the brave://local-state file and ensured that the metrics Brave.Wallet.NewUserReturning response value is 2
  4. Close the browser and set the system clock ahead by one day (16th July)
  5. Relaunch the browser
  6. Unlock the wallet
  7. Reload the brave://local-state file
  8. The metrics response value is 4 as expected

Screenshot_20220716-161311_Brave

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 28, 2022 •
edited
Loading

Verification PASSED on Samsung Galaxy version 11 running Bravemonoarm.apk_1.42.80

Case 1: I have never used Brave Wallet = 0_PASSED
  • Confirmed that Brave.Wallet.NewUserReturning metrics response value is 0 when brave wallet is not used

Screenshot_20220728-171426_Brave

Case 2: I have used Brave Wallet, but I'm not a first-time Brave Wallet user this week = 1_PASSED

Case 1:

  1. Set the system date to 11th July (starting day of the week)
  2. Clean profile 1.42.x
  3. Create a wallet
  4. Open the brave://local-state file and ensured that the metrics Brave.Wallet.NewUserReturning response value is 2
  5. Close the browser and set the system clock ahead by one week (18th July)
  6. Relaunch the browser
  7. Unlock the wallet
  8. Reload the brave://local-state file
  9. The metrics response value is 1 as expected

Screenshot_20220718-173317_Brave

Case 2:

  1. Set the system date to 11th July (starting day of the week)
  2. Clean profile 1.42.x
  3. Create a wallet today
  4. Open the brave://local-state file and ensured that the metrics Brave.Wallet.NewUserReturning response value is 2
  5. Close the browser and set the system clock ahead by one week (18th July)
  6. Relaunch the browser
  7. Unlock the wallet
  8. Reload the brave://local-state file
  9. The metrics Brave.Wallet.NewUserReturning response value is 1 as expected
  10. Close the browser and set the system clock ahead by one week (19th July/22 July/ 23 July/ 24 July / 26 July)
  11. Relaunch the browser
  12. Unlock the wallet
  13. Reload the brave://local-state file
  14. The metrics Brave.Wallet.NewUserReturning response value is 1 as expected
    Screenshot_20220718-173317_Brave
Case 3: I'm a first-time Brave Wallet user this week but, no, I did not return the rest of the week = 2_PASSED

Case 1:

  1. Clean profile 1.42.x
  2. Open the brave://local-state file and ensured that the metrics Brave.Wallet.NewUserReturning response value is 0
  3. Create a wallet and reload the brave://local-state file and ensured that the metrics Brave.Wallet.NewUserReturning response value is 2 as expected

Screenshot_20220728-171643_Brave

Case 4: I'm a first-time Brave Wallet user this week and, yes, I returned and used it again the following day = 3_PASSED

Case 1:

  1. Clean profile 1.42.x
  2. Create a wallet today (14th July)
  3. Open the brave://local-state file and ensured that the metrics Brave.Wallet.NewUserReturning response value is 2
  4. Close the browser and set the system clock ahead by one day (15th July)
  5. Relaunch the browser
  6. Unlock the wallet
  7. Reload the brave://local-state file
  8. The metrics response value is 3 as expected

Screenshot_20220715-172436_Brave

Case 2:

  1. Clean profile 1.42.x
  2. Create a wallet today (11th July)
  3. Open the brave://local-state file and ensured that the metrics Brave.Wallet.NewUserReturning response value is 2
  4. Close the browser and set the system clock ahead by one day (12th July)
  5. Relaunch the browser
  6. Unlock the wallet
  7. Reload the brave://local-state file
  8. The metrics response value is 3 as expected
    Screenshot_20220715-172436_Brave
Case 5: I'm a first time Brave Wallet user this week and, yes, I returned and used it again this week but not the following day = 4_PASSED
  1. Clean profile 1.42.x
  2. Create a wallet today (14th July)
  3. Open the brave://local-state file and ensured that the metrics Brave.Wallet.NewUserReturning response value is 2
  4. Close the browser and set the system clock ahead by one day (16th July)
  5. Relaunch the browser
  6. Unlock the wallet
  7. Reload the brave://local-state file
  8. The metrics response value is 4 as expected

Screenshot_20220716-172829_Brave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DJAndries DJAndries

Labels
feature/web3/wallet Integrating Ethereum+ wallet support features/P3A OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.42.x - Release
Development

Successfully merging a pull request may close this issue.

Create P3A utils + add Wallet new user p3a metric brave/brave-core
3 participants
@DJAndries @GeetaSarvadnya @brave-builds