Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect response value for new user returning wallet usage pings #24058

Closed
GeetaSarvadnya opened this issue Jul 14, 2022 · 3 comments
Closed

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 14, 2022

Description

Found while testing #23463
Incorrect response value for new user returning wallet usage pings

"As a first time user of Brave Wallet this week, did I return again to use it during the week?"
Brave.Wallet.NewUserReturning

  1. I have never used Brave Wallet
  2. I have used Brave Wallet, but I'm not a first time Brave Wallet user this week
  3. I'm a first time Brave Wallet user this week but, no, I did not return the rest of the week
  4. I'm a first time Brave Wallet user this week and, yes, I returned and used it again the following day
  5. I'm a first time Brave Wallet user this week and, yes, I returned and used it again this week but not the following day

Steps to Reproduce

  1. Clean profile 1.42.x
  2. Create a wallet today (14th July)
  3. Open the brave://local-state file and ensured that the metrics Brave.Wallet.NewUserReturning response value is 2
  4. Close the browser and set the system clock ahead by one day (15th July)
  5. Relaunch the browser
  6. Unlock the wallet
  7. Reload the brave://local-state file
  8. The metrics response value is 3 as expected
  9. Close the browser and set the system clock to 18th July (the first day of the next week)
  10. Repeat steps 5 and 6
  11. Reload the brave://local-state file
  12. if a week is from the day wallet is created then it's 4 if a week is from Monday to Sunday then it should be 1 but the response is 3

Actual result:

Incorrect response value for new user returning wallet usage pings

Expected result:

if a week is from the day wallet is created then it's 4 if a week is from Monday to Sunday then it should be 1

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.42.65 Chromium: 103.0.5060.114 (Official Build) beta (64-bit)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS Windows 10 Version 21H2 (Build 19044.1826)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @DJAndries @mattmcalister

@GeetaSarvadnya
Copy link
Author

The issue is reproducible on Samsung Galaxy Tab A7 version 11 running Bravemonoarm.apk_1.42.80

@DJAndries
Copy link
Collaborator

Renamed the question to "As a first time user of Brave Wallet this week, did I return again to use it during the first 7 day period?". Should work as expected with this definition.

@GeetaSarvadnya
Copy link
Author

Verified the STR again and ensured that the reposnse value is 1 ( I have used Brave Wallet, but I'm not a first time Brave Wallet user this week) in step 12 as expected. Thanks @DJAndries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants