Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on Filter lists opens up the filter page in a new tab even though the filter page already opened in another tab #24120

Open
GeetaSarvadnya opened this issue Jul 19, 2022 · 3 comments · May be fixed by brave/brave-core#26682

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 19, 2022

Description

Found while testing #23285
Clicking on Filter lists opens up the filter page in a new tab even though the filter page already opened in another tab

Steps to Reproduce

  1. Clean profile 1.41.x or 1.42.x
  2. Open any site
  3. Click on shield and expand the advanced view and click on Filter lists multiple times
  4. Clicking on Filter lists opens up the filter page in a new tab even though the filter page already opened in another tab

Actual result:

Clicking on Filter lists opens up the filter page in a new tab even though the filter page already opened in another tab

Expected result:

Clicking on Filter lists should redirect to the existing filter page if it's already opened in another tab

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.42.68 Chromium: 103.0.5060.114 (Official Build) beta (64-bit)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS Windows 10 Version 21H2 (Build 19044.1826)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @petemill @nullhook @rebron @brave/legacy_qa

@mayankpmahajan
Copy link

@rebron Can i be assigned this?

@SuvineetSingh
Copy link

Hi everyone, is this issue still open for work? I would like to try it.

@bregwin
Copy link

bregwin commented Nov 21, 2024

Hi! I thought of working on this, I think I fixed the issue. Right now I am trying to build the project and see if it worked properly, but it is taking a long time to compile. Will make a pull request when I manage to run it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Untriaged backlog
Development

Successfully merging a pull request may close this issue.

5 participants