Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tab focus or creation condition for filter lists and shields #26682

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bregwin
Copy link

@bregwin bregwin commented Nov 21, 2024

Resolves #24120

This PR changes how the filter lists and shields is navigated to with browser tabs:

Previous Behavior

  • Clicking on filter lists or shields always opened a new tab, leading to multiple redundant tabs.

New Behavior

  • The system now checks for an existing tab with the target URL first.
  • If found, it focuses on that tab; if not, it opens a new one.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

I did this initially at a different branch, but then copied the changes over to a new branch.

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

@bregwin
Copy link
Author

bregwin commented Nov 26, 2024

@kdenhartog Could you take a look at this pull request, I initially tried to work on #41428, but it was too large for me, so I worked on this instead.

@kdenhartog
Copy link
Member

cc @petemill who would be the best person to take a look at this change? I see it's UI focused, so thought you might have a good idea if this fits within what we want done here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants