Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support editing network details for Solana and Filecoin #24569

Closed
yrliou opened this issue Aug 10, 2022 · 1 comment · Fixed by brave/brave-core#14879
Closed

Support editing network details for Solana and Filecoin #24569

yrliou opened this issue Aug 10, 2022 · 1 comment · Fixed by brave/brave-core#14879
Assignees
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@yrliou
Copy link
Member

yrliou commented Aug 10, 2022

Mainly for users to be able to customize their block explorer url, and probably JSON RPC URL too. cc @jamesmudgett
We should probably consider have separate sections for EVM, Solana, Filecoin networks in the settings UI with section titles, and only allow user to edit a subset of network fields (such as block_explorer_url, JSON RPC URL) only, things like changing chain_id doesn't make sense in Solana and Filecoin.

@yrliou yrliou added feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Aug 10, 2022
@yrliou yrliou added this to Web3 Aug 10, 2022
@yrliou yrliou added priority/P3 The next thing for us to work on. It'll ride the trains. feature/web3/wallet/core labels Aug 11, 2022
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Aug 19, 2022
Repository owner moved this from Backlog to Done in Web3 Sep 2, 2022
@brave-builds brave-builds added this to the 1.45.x - Nightly milestone Sep 2, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.45.95 Chromium: 106.0.5249.103 (Official Build) beta (64-bit)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS Linux
  • Verified steps from brave/brave-core#14879
  • Verified Filecoin and Solana networks are listed in their own section
  • Verified able to edit existing default networks
  • Verified able to reset edit to defaults
  • Verified Ethereum defaults works as expected
  • Verified Chain ID field is ready only so can't be edited
24569.mp4

Verification passed on

Brave 1.45.95 Chromium: 106.0.5249.103 (Official Build) beta (64-bit)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS Windows 11 Version 21H2 (Build 22000.978)
  • Verified steps from brave/brave-core#14879
  • Verified Filecoin and Solana networks are listed in their own section
  • Verified able to edit existing default networks
  • Verified able to reset edit to defaults
  • Verified Ethereum defaults works as expected
  • Verified Chain ID field is ready only so can't be edited
24569.mp4

Verification passed on

Brave 1.45.95 Chromium: 106.0.5249.103 (Official Build) beta (arm64)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS macOS Version 12.6 (Build 21G115)
  • Verified steps from brave/brave-core#14879
  • Verified Filecoin and Solana networks are listed in their own section
  • Verified able to edit existing default networks
  • Verified able to reset edit to defaults
  • Verified Ethereum defaults works as expected
  • Verified Chain ID field is ready only so can't be edited
24569.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants