Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fil and Sol custom networks #14879

Merged
merged 3 commits into from
Sep 2, 2022
Merged

Fil and Sol custom networks #14879

merged 3 commits into from
Sep 2, 2022

Conversation

supermassive
Copy link
Collaborator

@supermassive supermassive commented Aug 30, 2022 •
edited
Loading

Resolves brave/brave-browser#24569

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Added Filecoin and Solana sections to brave://settings/wallet/networks
  • Adding new networks or changing chain id is disallowed in these sections.
  • Android does not get these, but custom eth networks still should work as before.

chrome___settings_wallet_networks (2)

@supermassive supermassive requested a review from a team as a code owner August 30, 2022 04:58
@supermassive supermassive force-pushed the fil_sol_custom_networks branch 4 times, most recently from 65ad7e8 to 62e4285 Compare August 31, 2022 04:26
supermassive
supermassive commented Aug 31, 2022
View reviewed changes
components/brave_wallet/browser/brave_wallet_utils.cc
auto result = network->Clone();
if (result->rpc_endpoints.empty()) {
result->active_rpc_endpoint_index = 0;
result->rpc_endpoints = {GURL(GetInfuraURLForKnownChainId(chain_id))};
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be refactored so it is hardcoded into known network info

@supermassive supermassive force-pushed the fil_sol_custom_networks branch from 62e4285 to 732407a Compare August 31, 2022 11:10
@supermassive supermassive force-pushed the fil_sol_custom_networks branch from 732407a to 38b5bb1 Compare September 1, 2022 01:35
yrliou
yrliou approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but please fill out the test plan for QA verification, thanks.

@supermassive supermassive merged commit 34bc88d into master Sep 2, 2022
@supermassive supermassive deleted the fil_sol_custom_networks branch September 2, 2022 05:49
@github-actions github-actions bot added this to the 1.45.x - Nightly milestone Sep 2, 2022
@supermassive supermassive mentioned this pull request Sep 5, 2022
Closed
@srirambv srirambv mentioned this pull request Oct 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrliou yrliou yrliou approved these changes

Assignees

@supermassive supermassive

Labels
None yet
Projects
None yet
Milestone
1.45.x - Release
Development

Successfully merging this pull request may close these issues.

Support editing network details for Solana and Filecoin
2 participants
@supermassive @yrliou