-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Unify responsive Rewards settings page with Android #24570
Comments
@srirambv @Uni-verse please be sure to see the test plan in brave/brave-core#14604 (comment) and ensure the brave://rewards page is tested thoroughly on Android devices (ARM and Tablet). As for desktop testing, a single platform is sufficient to do the testing of desktop specific areas listed in brave/brave-core#14604 (comment) cc @GeetaSarvadnya I'd also suggest doing checks in both portrait and landscape views, particularly for tablet where this will likely cause the display to change. |
Verification PASSED on
Case 1: Drop-down UI controls (updated to use HTML select elements)
|
brave://rewards |
brave://rewards AC settings |
brave://settings/rewards |
AC table | Monthly payment distributed |
---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
- Open brave://settings/rewards page and select
Monthly auto-contribution limit
Up to 7.000BAT
- Open brave://rewards and ensured that the updated monthly payment is reflected in the dropdown
Select `Minimum page time before logging a visit` _PASSED
- Enable rewards via NTP, claim UGP grants
- Open brave://rewards and confirm
Minimum page time before logging a visit
drop-down items are listed as expected - Open brave://rewards and confirm drop-down items in the
Minimum page time before logging a visit
are matching with advanced settings on the brave://settings/rewards page - Change the default value and select
5 seconds
in brave://rewards - Open brave://settings/rewards and ensure
5 seconds
is retained in AC settings - Open brave://rewards in a new tab and ensure
5 seconds
is retained in AC settings - Open a new window and ensure
5 seconds
is retained in AC settings - Restart the browser and ensure the selected value
5 seconds
is retained across all the brave://rewards and brave://settings/rewards tabs opened in 1st and 2nd window - Ensured that the sites got added to AC table with min page time of
5 seconds
- Open brave://settings/rewards and change the
Minimum page time before logging a visit
to8 seconds
, opened brave://rewards and ensured updated value is reflected brave://rewards AC settings page
brave://rewards |
brave://settings/rewards |
---|---|
![]() |
![]() |
Select `Minimum visits for publisher relevancy`_PASSED
- Enable rewards via NTP, claim UGP grants
- Open brave://rewards and confirm
Minimum visits for publisher relevancy
drop-down items are listed as expected - Open brave://rewards and confirm drop-down items in the
Minimum visits for publisher relevancy
are matching with rewards settings on the brave://settings/rewards - Change the default value and select
10 visits
in brave://rewards - Open brave://rewards and ensure
10 visits
is retained in AC settings - Open brave://rewards in a new tab and ensure
10 visits
is retained in AC settings - Open a new window and ensure
10 visits
is retained in AC settings - Restart the browser and ensure the selected value
10 visits
is retained across all the brave://rewards and brave://settings/rewards tabs opened in 1st and 2nd window - Ensured that the sites got added to AC table with min visits of
10 visits
- Open brave://settings/rewards and change the
Minimum page time before logging a visit
to5 visits
, opened brave://rewards and ensured updated value is reflected brave://rewards AC settings page
brave://rewards |
brave://settings/rewards |
---|---|
![]() |
![]() |
Upgrade profile
Select `Monthly auto-contribution limit`_PASSED
- Clean profile 1.44.x
- Enable rewards via NTP, claim UGP grants
- Open brave://rewards page and change the default value for
Monthky Payment
and selectUp to 7.000BAT
in AC settings page - Open brave://rewards and ensure
Up to 7.000BAT
is retained in AC settings - Upgrade the profile to 1.45.x (renamed the profile to brave beta)
- Ensured that the selected value
Up to 7.000BAT
is retained in brave://rewards page - Ensured that the selected value
Up to 7.000BAT
is retained in brave://settings/rewards page
1.44.x |
1.44.x |
1.45.x |
1.45.x |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
- Open brave://settings/rewards page and select
Monthly auto-contribution limit
Up to 5.000BAT
- Open brave://rewards and ensured that the updated monthly payment is reflected in the dropdown
Select `Minimum page time before logging a visit` _PASSED
- Clean profile 1.44.x
- Enable rewards via NTP, claim UGP grants
- Open brave://rewards page and change the default value for
Minimum page time before logging a visit
and select5 seconds
in AC settings page - Open brave://settings/rewards and ensure
5 seconds
is retained in AC settings - Upgrade the profile to 1.45.x (renamed the profile to brave beta)
- Ensured that the selected value for
Minimum page time before logging a visit
5 seconds
is retained in brave://rewards page - Ensured that the selected value for
Minimum page time before logging a visit
5 seconds
is retained in brave://settings/rewards page
1.44.x |
1.44.x |
1.45.x |
1.45.x |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
- Open brave://settings/rewards page and select
Minimum page time before logging a visit
8 seconds
- Open brave://rewards and ensured that the updated monthly payment is reflected in the dropdown
Select `Minimum visits for publisher relevancy`_PASSED
- Clean profile 1.44.x
- Enable rewards via NTP, claim UGP grants
- Open brave://rewards and change the default value for
Minimum visits for publisher relevancy
and select10 visits
in AC settings page - Open brave://settings/rewards and ensure
10 visits
is retained in AC settings - Upgrade the profile to 1.45.x (renamed the profile to brave beta)
- Ensured that the selected value for
Minimum visits for publisher relevancy
10 visits
is retained in brave://rewards page - Ensured that the selected value for
Minimum visits for publisher relevancy
10 visits` is retained in brave://settings/rewards page
1.44.x |
1.44.x |
1.45.x |
1.45.x |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
- Open brave://settings/rewards page and select
Minimum visits for publisher relevancy
5 visits
- Open brave://rewards and ensured that the updated monthly payment is reflected in the dropdown
Case 2: Sidebar promotions (updated to display in narrow mode)
brave rewads promotions in narrow mode_PASSED
Confirmed promo cards are displayed in the narrow view as expected (mentioned in the test plan)
Confirmed "Manage Brave Rewards" button is not displayed in the narrow view
Confirmed "30-day Ads History" link is not displayed in the narrow view
In narrow view, there is no "View Statement" button (on wallet panel), this matches Android experience and is expected
In narrow view, the nav bar at the top of the brave://rewards page is gone, this also matches the Android experience
Example | Example | Example | Example | Example | Example |
---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Case 3: Brave settings toolbar (component ordering was slightly adjusted)
Verification PASSED on
|
Verification PASSED on
In a clean profile, when we tap on
|
Description
Use unified responsive Rewards settings page on Android.
Related to #16619.
cc: @deeppandya
The text was updated successfully, but these errors were encountered: