Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

India retention - update onboarding (follow up to #24111) #24677

Closed
kjozwiak opened this issue Aug 15, 2022 · 2 comments · Fixed by brave/brave-core#14635
Closed

India retention - update onboarding (follow up to #24111) #24677

kjozwiak opened this issue Aug 15, 2022 · 2 comments · Fixed by brave/brave-core#14635
Assignees
Labels
onboarding Front-end related to helping a new user learn about features within the browser. OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/exclude retention

Comments

@kjozwiak
Copy link
Member

Description

Looks like the body text within the default browser screen of onboarding was never updated to #24111 (comment). Looks like it's still using the older text/strings that we've been using.

One way to tell is that the body is translated and all the new strings that we've added into 1.44.x still haven't been translated. So that's a good indicator that it was never changed.

Steps to reproduce

  1. install a Nightly version of Brave that includes India retention fix for brave-browser/issues/24111 brave-core#14327
  2. you'll notice that the text within the body of the default browser page doesn't match [Android] India retention - update onboarding copy #24111 (comment)

Actual result

Example Example
Screenshot_20220815-145144 Screenshot_20220815-145631

Expected result

image

Issue reproduces how often

100% reproducible using the STR/Cases outlined above.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? N/A
  • Can you reproduce this issue with the current Play Store Beta version? N/A (changes haven't been uplifted into 1.43.x yet)
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Pixel 6
  • Android version: Android 13

Brave version

Brave | 1.44.43 Chromium: 104.0.5112.81 (Official Build) canary (32-bit)
--- | ---
Revision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS | Android 13; Build/TPB4.220624.008

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

@kjozwiak
Copy link
Member Author

The above will require 1.43.72 or higher for 1.43.x verification. We'll also need to check if these new strings were translated once we get translations merged into 1.43.x.. Believe we should be ordering the new translations sometime early next week.

@stephendonner
Copy link

Verified PASSED using

Brave 1.43.74, Chromium 104.0.5112.102 on a Google Pixel XL running Android 9.0.

NOTE: copy will be verified over in #24111, once we get translated strings, as @kjozwiak mentions above.

Set my system language in Android to Hindi:

1.43.74 Hindi
Screenshot_20220818-133425 Screenshot_20220818-134147

Hindi

Confirmed new India-onboarding-specific strings were used (not all translated; will be verified over in #24111

onboarding 1 onboarding 2 onboarding 3
Screenshot_20220818-132924 Screenshot_20220818-132931 Screenshot_20220818-133214

English (United States)

Confirmed existing strings were used/retained

onboarding 1 onboarding 2 onboarding 3
Screenshot_20220818-133911 Screenshot_20220818-133921 Screenshot_20220818-133931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onboarding Front-end related to helping a new user learn about features within the browser. OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/exclude retention
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants