Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

India retention fix for brave-browser/issues/24111 (uplift to 1.43.x) #14591

Merged
merged 2 commits into from
Aug 16, 2022
Merged

India retention fix for brave-browser/issues/24111 (uplift to 1.43.x) #14591

merged 2 commits into from
Aug 16, 2022

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Aug 11, 2022 •
edited by kjozwiak
Loading

Uplift of #14327 & #14635
Resolves brave/brave-browser#24111
Resolves brave/brave-browser#24677

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner August 11, 2022 14:13
@brave-builds brave-builds self-assigned this Aug 11, 2022
@brave-builds brave-builds added this to the 1.43.x - Beta milestone Aug 11, 2022
@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Aug 11, 2022
@kjozwiak
Copy link
Member

Waiting till brave/brave-browser#24677 is addressed. @deeppandya will cherry-pick the new strings into this uplift and once fixed, we'll get it merged. Some more context via #14327 (comment).

@deeppandya deeppandya force-pushed the pr14327_fix_24111_india_retention_1.43.x branch from bd6b9f8 to 59f30ff Compare August 15, 2022 20:38
kjozwiak
kjozwiak approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.43.x approved 👍 QA has verified the PR on Nightly as per #14327 (comment) & #14635 (comment).

@kjozwiak kjozwiak merged commit 55e33d0 into 1.43.x Aug 16, 2022
@kjozwiak kjozwiak deleted the pr14327_fix_24111_india_retention_1.43.x branch August 16, 2022 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.43.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @deeppandya @brave-browser-releases