Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an NFT doesn't show it in the portfolio until refresh #25578

Closed
srirambv opened this issue Sep 23, 2022 · 2 comments · Fixed by brave/brave-core#15241
Closed

Adding an NFT doesn't show it in the portfolio until refresh #25578

srirambv opened this issue Sep 23, 2022 · 2 comments · Fixed by brave/brave-core#15241
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

srirambv commented Sep 23, 2022

Description

Adding an NFT doesn't show it in the portfolio until refresh

Steps to Reproduce

  1. Add an NFT via Add custom asset under Visible assets
  2. Doesn't list the NFT under portfolio
  3. Reload the page, NFT gets listed

Actual result:

Add.NFT.to.collection.mp4

Expected result:

Should get listed automatically without having to refresh the portfolio page

Reproduces how often:

Easy

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Not checked
  • Can you reproduce this issue with the nightly channel? No

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @muliswilliam @nvonpentz

@srirambv srirambv added this to Web3 Sep 23, 2022
@Douglashdaniel Douglashdaniel self-assigned this Sep 23, 2022
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Sep 23, 2022
@Douglashdaniel Douglashdaniel added the front-end-change This task is a front end task and doesn't need any C++ changes label Sep 27, 2022
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Sep 27, 2022
Repository owner moved this from In Review to Done in Web3 Sep 27, 2022
@Douglashdaniel Douglashdaniel added this to the 1.46.x - Nightly milestone Oct 17, 2022
@kjozwiak
Copy link
Member

The above requires 1.45.105 or higher for 1.45.x verification 👍

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.45.106 Chromium: 107.0.5304.36 (Official Build) (64-bit)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS Linux
  • Verified steps from issue description and brave/brave-core#15241
  • Verified added NFT is shown automatically under portfolio without having to refresh the portfolio page
  • Verified adding NFT successfully closes the add token details form
25578.mp4

Verification passed on

Brave 1.45.106 Chromium: 107.0.5304.36 (Official Build) (64-bit)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS Windows 11 Version 22H2 (Build 22621.674)
  • Verified steps from issue description and brave/brave-core#15241
  • Verified added NFT is shown automatically under portfolio without having to refresh the portfolio page
  • Verified adding NFT successfully closes the add token details form
25578.mp4

Verification passed on

Brave 1.45.106 Chromium: 107.0.5304.36 (Official Build) (arm64)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from issue description and brave/brave-core#15241
  • Verified added NFT is shown automatically under portfolio without having to refresh the portfolio page
  • Verified adding NFT successfully closes the add token details form
25578.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants