Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): ERC721 Refresh after Success Response #15241

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

Douglashdaniel
Copy link
Contributor

Description

Refreshes your Portfolio balances upon a Success response for adding an ERC721 token.

Resolves brave/brave-browser#25578

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Add a Custom NFT and click Add and Done
  2. You NFT should eventually show up in your Portfolio

Before:

Screen.Recording.2022-09-27.at.11.58.58.AM.mov

After:

Screen.Recording.2022-09-27.at.11.49.40.AM.mov

@Douglashdaniel Douglashdaniel self-assigned this Sep 27, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Sep 27, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@Douglashdaniel Douglashdaniel merged commit 92ba1f7 into master Sep 27, 2022
@Douglashdaniel Douglashdaniel deleted the erc721-refresh-after-success branch September 27, 2022 19:08
@github-actions github-actions bot added this to the 1.46.x - Nightly milestone Sep 27, 2022
brave-builds pushed a commit that referenced this pull request Oct 17, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.46.66 Chromium: 107.0.5304.36 (Official Build) nightly (64-bit)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS Windows 11 Version 22H2 (Build 22623.746)
  • Verified steps from PR and issue description
  • Verified added NFT is shown automatically under portfolio without having to refresh the portfolio page
15241.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding an NFT doesn't show it in the portfolio until refresh
4 participants