Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text for Help make Brave better screen #27339

Closed
3 tasks done
rebron opened this issue Dec 13, 2022 · 4 comments · Fixed by brave/brave-core#16363
Closed
3 tasks done

Update text for Help make Brave better screen #27339

rebron opened this issue Dec 13, 2022 · 4 comments · Fixed by brave/brave-core#16363
Assignees
Labels
l10n onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release/blocking release-notes/exclude

Comments

@rebron
Copy link
Collaborator

rebron commented Dec 13, 2022

Description

Update finalized strings for new onboarding Help make Brave better screen.

Actual result:

205358475-5a778930-d505-47c9-8950-d52073a20f19

Expected result:

Screenshot 2022-12-13 at 8 59 56 AM

Reproduces how often:

Easily

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Follow-up from: #27126
Security review: https://github.com/brave/security/issues/1132
Related Android issue: #23989

@rebron rebron added OS/Desktop release/blocking priority/P2 A bad problem. We might uplift this to the next planned release. onboarding Front-end related to helping a new user learn about features within the browser. QA/Yes release-notes/exclude labels Dec 13, 2022
@PrivacyMatters
Copy link

Thx @rebron Could we also remove the word anonymous from the diagnostics unless @fmarier and @ShivanKaul believe the measures we have in place to strip personal data from reports, does result in them being anonymous.

@rebron
Copy link
Collaborator Author

rebron commented Dec 13, 2022

@PrivacyMatters I updated the screen and removed anonymous from the first checkbox.

@kjozwiak
Copy link
Member

The above requires 1.47.131 or higher for 1.47.x verification 👍

@stephendonner
Copy link

Verified PASSED using

Brave 1.47.132 Chromium: 108.0.5359.128 (Official Build) beta (x86_64)
Revision 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS macOS Version 11.7.2 (Build 20G1020)
brave://welcome crash reporting link p3a link
Screen Shot 2022-12-17 at 2 27 45 AM Screen Shot 2022-12-17 at 2 28 01 AM Screen Shot 2022-12-17 at 2 28 14 AM

Confirmed:

  • text/copy changes as implemented match the Expected Result, above
  • Learn more. link for first check box/crash reports goes to: https://support.brave.com/hc/en-us/articles/360017905872-How-do-I-enable-or-disable-automatic-crash-reporting
  • Learn more. link for second check box/P3A to go to: https://support.brave.com/hc/en-us/articles/9140465918093-What-is-P3A-in-Brave-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release/blocking release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants