Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboarding fixes (Uplift to 1.47.x) #16321

Merged
merged 3 commits into from
Dec 15, 2022
Merged

Onboarding fixes (Uplift to 1.47.x) #16321

merged 3 commits into from
Dec 15, 2022

Conversation

nullhook
Copy link
Contributor

@nullhook nullhook commented Dec 10, 2022 •
edited by kjozwiak
Loading

Uplift of #16208
Uplift of #16164
Uplift of #16363
Resolves brave/brave-browser#27126
Resolves brave/brave-browser#27253
Resolves brave/brave-browser#26851
Resolves brave/brave-browser#27060
Resolves brave/brave-browser#27061
Resolves brave/brave-browser#27105
Resolves brave/brave-browser#27339

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@nullhook nullhook requested a review from a team as a code owner December 10, 2022 03:44
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Dec 10, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@kjozwiak kjozwiak added this to the 1.47.x - Beta milestone Dec 15, 2022
@nullhook
Enabled diagnostic reporting by default (#16208)
26569f3 
Enabled diagnostic reporting by default and swapped handles of the two checkboxes on help improve screen
@nullhook
Optimized the new Welcome UI and style fixes (#16164)
5071645 
* Converted assets to webp format
* Lazy loading
* Style fixes
* Added background image loading handle
@nullhook
Revised copy for help improve UI on the new onboarding page (#16363)
4481981
@nullhook nullhook force-pushed the onboarding-fixes-1.47.x branch from 759aa6e to 4481981 Compare December 15, 2022 07:47
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

kjozwiak
kjozwiak approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.47.x approved 👍 QA has verified the PR on Nightly as per #16208 (comment), #16164 (comment) & #16363 (comment).

@kjozwiak kjozwiak merged commit 44a334e into 1.47.x Dec 15, 2022
@kjozwiak kjozwiak deleted the onboarding-fixes-1.47.x branch December 15, 2022 16:33
@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: 4481981
reason: unsigned
Please follow the handbook to configure commit signing
cc: @nullhook

@LaurenWags LaurenWags mentioned this pull request Dec 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@nullhook nullhook

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.47.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@nullhook @brave-builds @kjozwiak