Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CR 109] New setting Certificates managed by Brave shown in brave://settings/security page #27476

Closed
MadhaviSeelam opened this issue Dec 20, 2022 · 2 comments · Fixed by brave/brave-core#16445

Comments

@MadhaviSeelam
Copy link

MadhaviSeelam commented Dec 20, 2022

Description

Steps to Reproduce

  1. Install 1.48,71
  2. launch Brave
  3. open brave://settings/security
  4. click on Certificate managed by Brave

Actual result:

New setting Certificate managed by Brave is shown on brave://settings/security
Clicking the link redirects to https://chromium.googlesource.com/chromium/src/+/main/net/data/ssl/chrome_root_store/root_store.md
image|image

Expected result:

No additional setting.

Reproduces how often:

Easily

Brave version (brave://version info)

Brave | 1.48.71 Chromium: 109.0.5414.46 (Official Build) nightly (64-bit)
-- | --
Revision | 6e36b77363ef3febbe792af680fa1367993ddcf0-refs/branch-heads/5414@{#709}
OS | Windows 11 Version 21H2 (Build 22000.1335)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron
@kjozwiak
Copy link
Member

The above will require 1.47.140 or higher for 1.47.x verification 👍

@stephendonner
Copy link

Verified PASSED using

Brave 1.47.143 Chromium: 109.0.5414.46 (Official Build) beta (x86_64)
Revision 6e36b77363ef3febbe792af680fa1367993ddcf0-refs/branch-heads/5414@{#709}
OS macOS Version 11.7.2 (Build 20G1020)

Followed the steps to reproduce from #27476 (comment)

Confirmed there's no Certificates managed by Brave setting in brave://settings/security, and Manage device certificates still opens up the macOS system Keychain Access app

Screen Shot 2022-12-23 at 12 22 56 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants