Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFT icon is squished when an unusually long name is given for an NFT #28276

Closed
srirambv opened this issue Feb 3, 2023 · 1 comment · Fixed by brave/brave-core#17110
Closed

NFT icon is squished when an unusually long name is given for an NFT #28276

srirambv opened this issue Feb 3, 2023 · 1 comment · Fixed by brave/brave-core#17110
Assignees
@Douglashdaniel
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.50.x - Release

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 3, 2023

Description

NFT icon is squished when an unusually long name is given for an NFT

Steps to Reproduce

  1. Add unusually long name for an NFT
  2. Search for the token in Visible asset list
  3. Check the icon

Actual result:

image

Expected result:

Icon size should remain same

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.48.155 Chromium: 110.0.5481.77 (Official Build) (64-bit)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? Not checked
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @Douglashdaniel @muliswilliam
@srirambv srirambv added bug QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Feb 3, 2023
@srirambv srirambv added this to Web3 Feb 3, 2023
@Douglashdaniel Douglashdaniel self-assigned this Feb 3, 2023
@Douglashdaniel Douglashdaniel added the front-end-change This task is a front end task and doesn't need any C++ changes label Feb 3, 2023
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Feb 3, 2023
@srirambv srirambv mentioned this issue Feb 3, 2023
Closed
@Douglashdaniel Douglashdaniel mentioned this issue Feb 8, 2023
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Feb 8, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Feb 8, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 8, 2023
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Linux
  • Verified steps from brave/brave-core#17110
  • Verified NFT icon is not squished when a really long name is used
    image

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Windows 11 Version 22H2 (Build 22621.1344)
  • Verified steps from brave/brave-core#17110
  • Verified NFT icon is not squished when a really long name is used
    brave_v0rrQR3MVZ

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (arm64)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#17110
  • Verified NFT icon is not squished when a really long name is used
  • image

@LaurenWags LaurenWags mentioned this issue Apr 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.50.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Virtualized Token List Dynamic Height brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds