Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long NFT Names need to Be Wrapped in Send Tab #27521

Closed
Douglashdaniel opened this issue Dec 22, 2022 · 2 comments · Fixed by brave/brave-core#16460
Closed

Long NFT Names need to Be Wrapped in Send Tab #27521

Douglashdaniel opened this issue Dec 22, 2022 · 2 comments · Fixed by brave/brave-core#16460
Assignees
@Douglashdaniel
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/Blocked QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.48.x - Release

Comments

@Douglashdaniel
Copy link

Description

We need to wrap long NFT names in the Send tab.

Screenshot 2022-12-22 at 9 58 33 AM
@Douglashdaniel Douglashdaniel added bug QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Dec 22, 2022
@Douglashdaniel Douglashdaniel self-assigned this Dec 22, 2022
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Dec 22, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Dec 22, 2022
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Dec 22, 2022
Repository owner moved this from In Review to Done in Web3 Dec 22, 2022
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Dec 22, 2022
@srirambv
Copy link
Contributor

QA Blocked on #28131

@srirambv
Copy link
Contributor

srirambv commented Feb 3, 2023

Verification passed on

Brave 1.48.155 Chromium: 110.0.5481.77 (Official Build) (64-bit)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS Linux
27521.mp4

Verification passed on

Brave 1.48.155 Chromium: 110.0.5481.77 (Official Build) (64-bit)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS Windows 11 Version 22H2 (Build 22621.755)
27251.mp4

Verification passed on

Brave 1.48.155 Chromium: 110.0.5481.77 (Official Build) (arm64)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS macOS Version 13.0 (Build 22A380)
27521.mov

@srirambv srirambv mentioned this issue Feb 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/Blocked QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.48.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Wrap Long NFT Names in Send brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds