Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending Filecoin transactions cannot be approved #28376

Closed
josheleonard opened this issue Feb 8, 2023 · 2 comments · Fixed by brave/brave-core#17103
Closed

Pending Filecoin transactions cannot be approved #28376

josheleonard opened this issue Feb 8, 2023 · 2 comments · Fixed by brave/brave-core#17103
Assignees
Labels

Comments

@josheleonard
Copy link

Description

Regression caused by: brave/brave-core#16945 (comment)
Filecoin transactions cannot be approve due to it waiting for EIP1559 gas estimates for the TX, which never resolve for FIL txs.

Steps to Reproduce

  1. Create a Filecoin Send transaction
  2. View the pending transaction in the panel

Actual result:

The confirm button is disabled, even though network fees are available and visible
Additional loading indicators are shown

Expected result:

The confirm button should be enabled and gas fees should be shown
No loading indicators should be shown for gas/network fee values

Reproduces how often:

Easy

Brave version (brave://version info)

1.50.x - Nightly as of brave/brave-core#16945 (comment)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@josheleonard
Copy link
Author

duplicate of #28369

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Linux
28376.mp4

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Windows 11 Version 22H2 (Build 22621.1344)
28376.mp4

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (arm64)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS macOS Version 13.0 (Build 22A380)
28376.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants