Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add tx fee value loading indicators to panel #16945

Merged
merged 1 commit into from
Feb 3, 2023
Merged

fix: add tx fee value loading indicators to panel #16945

merged 1 commit into from
Feb 3, 2023

Conversation

josheleonard
Copy link
Contributor

@josheleonard josheleonard commented Jan 31, 2023 •
edited
Loading

Resolves brave/brave-browser#23663

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Scenario 1: Shows loading indicator while loading transaction fees

Screen.Recording.2023-01-31.at.5.39.36.PM.mov

Scenario 2: Shows an error message if an error occurs while loading transaction fees
(use a different selected network than the transaction's network)

Screen.Recording.2023-01-31.at.5.41.09.PM.mov

@josheleonard josheleonard requested review from a team as code owners January 31, 2023 22:55
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jan 31, 2023
@josheleonard josheleonard force-pushed the fix-panel-transaction-value-loading-indicator branch 2 times, most recently from 71638cb to 9f43cd6 Compare January 31, 2023 23:23
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

onyb
onyb reviewed Feb 1, 2023
View reviewed changes
components/brave_wallet_ui/common/async/handlers.ts
return
}
store.dispatch(WalletActions.setSolFeeEstimates({ fee: getSolFee.fee }))
store.dispatch(WalletActions.setSolFeeEstimates({ fee }))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a remark not related to your PR - I've always felt it's weird to store transaction-specific fees in a global state that's shared by everyone.

onyb
onyb approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josheleonard josheleonard force-pushed the fix-panel-transaction-value-loading-indicator branch from 9f43cd6 to c6be81c Compare February 1, 2023 16:52
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard force-pushed the fix-panel-transaction-value-loading-indicator branch from c6be81c to 684088a Compare February 2, 2023 02:18
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard force-pushed the fix-panel-transaction-value-loading-indicator branch from 684088a to 7880b1d Compare February 2, 2023 14:05
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard force-pushed the fix-panel-transaction-value-loading-indicator branch from 7880b1d to 9740978 Compare February 2, 2023 16:48
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard merged commit 2116c45 into master Feb 3, 2023
@josheleonard josheleonard deleted the fix-panel-transaction-value-loading-indicator branch February 3, 2023 16:27
@github-actions github-actions bot added this to the 1.50.x - Nightly milestone Feb 3, 2023
@josheleonard josheleonard restored the fix-panel-transaction-value-loading-indicator branch February 8, 2023 13:33
josheleonard added a commit that referenced this pull request Feb 8, 2023
@josheleonard
Revert "fix: add tx fee value loading indicators to panel (#16945)"
14cfe07 
This reverts commit 2116c45.
This was referenced Feb 8, 2023
Closed
Closed
@srirambv srirambv mentioned this pull request Mar 17, 2023
Closed
@bsclifton bsclifton deleted the fix-panel-transaction-value-loading-indicator branch November 10, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onyb onyb onyb approved these changes

@darkdh darkdh darkdh approved these changes

Assignees

@josheleonard josheleonard

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.50.x - Release
Development

Successfully merging this pull request may close these issues.

Have a place holder text while panel is loading the transaction values
4 participants
@josheleonard @brave-builds @onyb @darkdh