Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet is showing the last screen instead of lock screen when browser is reopened #28402

Closed
Pavneet-Sing opened this issue Feb 9, 2023 · 1 comment · Fixed by brave/brave-core#17180
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Feb 9, 2023

Description

Steps to Reproduce

  1. Open Buy/Deposit
  2. Close browser and open again
  3. Buy/Deposit is still there, close buy and lock screen is shown

Actual result:

wallet.is.showing.the.last.screen.instead.of.lock.screen.when.closing.browser.webm

Expected result:

Should show the wallet lock screen (I think)

Reproduces how often:

Easily

Brave version (brave://version info)

Version 1.50.20 Chromium: 110.0.5481.77

Version/Channel Information:

  • Can you reproduce this issue with the current release? N
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel? Y
@Pavneet-Sing Pavneet-Sing added this to Web3 Feb 9, 2023
@Pavneet-Sing Pavneet-Sing changed the title Wallet is showing the last screen instead of lock screen when closing browser Wallet is showing the last screen instead of lock screen when browser is reopened Feb 9, 2023
@Douglashdaniel Douglashdaniel self-assigned this Feb 10, 2023
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Feb 10, 2023
@Douglashdaniel Douglashdaniel added the front-end-change This task is a front end task and doesn't need any C++ changes label Feb 10, 2023
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Feb 13, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Feb 15, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 15, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Linux
  • Verified steps from issue description
  • Verified closing browser with Buy/Deposit screens shows unlock wallet screen after restart
28402.mp4

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Windows 11 Version 22H2 (Build 22621.1344)
  • Verified steps from issue description
  • Verified closing browser with Buy/Deposit screens shows unlock wallet screen after restart
28402.mp4

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (arm64)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from issue description
  • Verified closing browser with Buy/Deposit screens shows unlock wallet screen after restart
28402.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants