Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Updated Fund Screens With Nav #17180

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

Douglashdaniel
Copy link
Contributor

@Douglashdaniel Douglashdaniel commented Feb 13, 2023

Description

Updates to the Fund Wallet and Deposit Funds screens to be similar to the Send/Swap screens:

  • Added the new Side Nav
  • Added the tab Header
  • Updated the border-radius and added a drop-shadow
  • Removed the Done buttons
  • Now only shows the back button if selecting a Buy option, Account or Create account.
  • Makes the Fund Wallet and Deposit Funds screens a private route.

Resolves brave/brave-browser#28490
Resolves brave/brave-browser#28402

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Testing Fund Wallet

  1. Create a new wallet and skip the Wallet Backup
  2. Click on the Buy crypto button
  3. It should route to the fund-wallet page
  4. There should be a header with the BraveLogo | Buy
  5. There should be the new Nav on the left side of the screen
  6. You should not see a Done button
  7. You should only see a back button for Selecting a Buy Option, Switching Accounts or Creating a new account

Before:

19

After:

17

Testing Deposit Funds

  1. Create a new wallet and skip the Wallet Backup
  2. Click on the Deposit button
  3. It should route to the deposit-funds page
  4. There should be a header with the BraveLogo | Deposit
  5. There should be the new Nav on the left side of the screen
  6. You should not see a Done button
  7. You should only see a back button for Deposit view (QR code screen), Switching Accounts or Creating a new account

Before:

20

After:

18

@Douglashdaniel Douglashdaniel requested a review from a team as a code owner February 13, 2023 23:27
@Douglashdaniel Douglashdaniel self-assigned this Feb 13, 2023
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Feb 13, 2023
@Douglashdaniel Douglashdaniel force-pushed the update-fund-screens-with-nav branch from 68dd914 to b725d27 Compare February 14, 2023 05:41
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Contributor

@josheleonard josheleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@mihaiplesa mihaiplesa merged commit def5598 into master Feb 15, 2023
@mihaiplesa mihaiplesa deleted the update-fund-screens-with-nav branch February 15, 2023 06:21
@github-actions github-actions bot added this to the 1.50.x - Nightly milestone Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
4 participants