Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom background image is not rendered #28493

Closed
simonhong opened this issue Feb 14, 2023 · 2 comments · Fixed by brave/brave-core#17251
Closed

Custom background image is not rendered #28493

simonhong opened this issue Feb 14, 2023 · 2 comments · Fixed by brave/brave-core#17251

Comments

@simonhong
Copy link
Member

simonhong commented Feb 14, 2023

Description

When custom image is used for NTP background, sometimes NTP background is not rendered well

Steps to Reproduce

  1. Load New tab and goto customize dashboard
  2. Select Background Image tab and upload image (large sized jpg(> 1mb) can cause this issue more easily)
  3. Refresh New tab or create new tab

Actual result:

image

Expected result:

Uploaded custom image should be rendered.

Reproduces how often:

Not easily but reproduced

Brave version (brave://version info)

Version 1.50.32 Chromium: 110.0.5481.77 (Official Build) nightly (x86_64)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes - Version 1.49.91
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@kjozwiak
Copy link
Member

kjozwiak commented Mar 8, 2023

The above requires 1.49.120 or higher for 1.49.x verification 👍

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.49.120 Chromium: 111.0.5563.64 (Official Build) (64-bit)
-- | --
Revision | c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS | Windows 11 Version 22H2 (Build 22621.1265)

Reproduced the issue using STR #28493 (comment) in 1.50.32 Chromium: 110.0.5481.77

example example
image image

Confirmed background images > 1mb are rendered correctly as expected.

example example example
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment