Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide accounts that don't hold an asset balance (asset detail view) #28761

Closed
jamesmudgett opened this issue Feb 26, 2023 · 1 comment · Fixed by brave/brave-core#17395
Closed

Hide accounts that don't hold an asset balance (asset detail view) #28761

jamesmudgett opened this issue Feb 26, 2023 · 1 comment · Fixed by brave/brave-core#17395
Assignees
@Douglashdaniel
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.50.x - Release

Comments

@jamesmudgett
Copy link

Accounts with 0 holdings should be hidden from the accounts list.

Image
@jamesmudgett jamesmudgett converted this from a draft issue Feb 26, 2023
@jamesmudgett jamesmudgett added priority/P3 The next thing for us to work on. It'll ride the trains. feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes labels Feb 26, 2023
@Douglashdaniel Douglashdaniel self-assigned this Feb 27, 2023
@Douglashdaniel Douglashdaniel moved this from Backlog to In Progress in Web3 Feb 27, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Feb 27, 2023
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Feb 27, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Feb 27, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 27, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.50.91 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Linux
  • Verified steps from brave/brave-core#17395
  • Verified only accounts with balance is shown on token details page
28761.mp4

Verification passed on

Brave 1.50.91 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Windows 11 Version 22H2 (Build 22621.1344)
  • Verified steps from brave/brave-core#17395
  • Verified only accounts with balance is shown on token details page
28761.mp4

Verification passed on

Brave 1.50.91 Chromium: 111.0.5563.64 (Official Build) beta (arm64)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#17395
  • Verified only accounts with balance is shown on token details page
28761.mov

@stephendonner stephendonner changed the title Hide accounts that don't hold a the asset balance (asset detail view) Hide accounts that don't hold an asset balance (asset detail view) Mar 23, 2023
@LaurenWags LaurenWags mentioned this issue Apr 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.50.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Hide Accounts With Zero Balance in Asset Details brave/brave-core
4 participants
@jamesmudgett @srirambv @Douglashdaniel @brave-builds